chore: add missing .babelrc.json to @fluentui/react-input - #20385
Merged
Conversation
Collaborator
📊 Bundle size report
🤖 This report was generated against 1dfd97b0655ff80c2c6e6f91e9ff24cf50e7ca30 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d5511ca6b8861539424bc435e7d86971342fabb3 (build) |
…hore/babel-input � Conflicts: � packages/react-input/package.json
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e65a478:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1000 | 1000 | 5000 | |
| BaseButton | mount | 953 | 988 | 5000 | |
| Breadcrumb | mount | 2904 | 2798 | 1000 | |
| ButtonNext | mount | 542 | 557 | 5000 | |
| Checkbox | mount | 1618 | 1642 | 5000 | |
| CheckboxBase | mount | 1329 | 1310 | 5000 | |
| ChoiceGroup | mount | 5003 | 4895 | 5000 | |
| ComboBox | mount | 1018 | 1037 | 1000 | |
| CommandBar | mount | 10794 | 10968 | 1000 | |
| ContextualMenu | mount | 6827 | 6872 | 1000 | |
| DefaultButton | mount | 1206 | 1209 | 5000 | |
| DetailsRow | mount | 3946 | 3863 | 5000 | |
| DetailsRowFast | mount | 3912 | 3950 | 5000 | |
| DetailsRowNoStyles | mount | 3699 | 3786 | 5000 | |
| Dialog | mount | 2739 | 2699 | 1000 | |
| DocumentCardTitle | mount | 170 | 176 | 1000 | |
| Dropdown | mount | 3406 | 3407 | 5000 | |
| FluentProviderNext | mount | 3543 | 3589 | 5000 | |
| FluentProviderWithTheme | mount | 223 | 217 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 120 | 104 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 245 | 262 | 10 | |
| FocusTrapZone | mount | 1952 | 1946 | 5000 | |
| FocusZone | mount | 1928 | 1894 | 5000 | |
| IconButton | mount | 1810 | 1801 | 5000 | |
| Label | mount | 381 | 384 | 5000 | |
| Layer | mount | 3156 | 3102 | 5000 | |
| Link | mount | 505 | 497 | 5000 | |
| MakeStyles | mount | 1926 | 1906 | 50000 | |
| MenuButton | mount | 1596 | 1575 | 5000 | |
| MessageBar | mount | 2197 | 2179 | 5000 | |
| Nav | mount | 3447 | 3507 | 1000 | |
| OverflowSet | mount | 1163 | 1211 | 5000 | |
| Panel | mount | 2582 | 2617 | 1000 | |
| Persona | mount | 890 | 853 | 1000 | |
| Pivot | mount | 1533 | 1528 | 1000 | |
| PrimaryButton | mount | 1382 | 1392 | 5000 | |
| Rating | mount | 8105 | 8043 | 5000 | |
| SearchBox | mount | 1389 | 1373 | 5000 | |
| Shimmer | mount | 2688 | 2579 | 5000 | |
| Slider | mount | 2111 | 2047 | 5000 | |
| SpinButton | mount | 5222 | 5312 | 5000 | |
| Spinner | mount | 471 | 467 | 5000 | |
| SplitButton | mount | 3394 | 3320 | 5000 | |
| Stack | mount | 569 | 529 | 5000 | |
| StackWithIntrinsicChildren | mount | 1874 | 1745 | 5000 | |
| StackWithTextChildren | mount | 4936 | 4935 | 5000 | |
| SwatchColorPicker | mount | 10906 | 11057 | 5000 | |
| Tabs | mount | 1520 | 1497 | 1000 | |
| TagPicker | mount | 2703 | 2817 | 5000 | |
| TeachingBubble | mount | 13676 | 13631 | 5000 | |
| Text | mount | 447 | 459 | 5000 | |
| TextField | mount | 1470 | 1462 | 5000 | |
| ThemeProvider | mount | 1247 | 1258 | 5000 | |
| ThemeProvider | virtual-rerender | 651 | 645 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2037 | 1985 | 5000 | |
| Toggle | mount | 866 | 844 | 5000 | |
| buttonNative | mount | 146 | 151 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ChatWithPopoverPerf.default | 409 | 380 | 1.08:1 |
| ListWith60ListItems.default | 688 | 645 | 1.07:1 |
| LoaderMinimalPerf.default | 767 | 714 | 1.07:1 |
| StatusMinimalPerf.default | 728 | 680 | 1.07:1 |
| LabelMinimalPerf.default | 417 | 395 | 1.06:1 |
| ButtonMinimalPerf.default | 191 | 182 | 1.05:1 |
| CarouselMinimalPerf.default | 501 | 476 | 1.05:1 |
| DropdownManyItemsPerf.default | 734 | 697 | 1.05:1 |
| FormMinimalPerf.default | 427 | 406 | 1.05:1 |
| AttachmentMinimalPerf.default | 164 | 157 | 1.04:1 |
| AvatarMinimalPerf.default | 219 | 211 | 1.04:1 |
| DialogMinimalPerf.default | 786 | 759 | 1.04:1 |
| SegmentMinimalPerf.default | 371 | 358 | 1.04:1 |
| SliderMinimalPerf.default | 1779 | 1716 | 1.04:1 |
| TableMinimalPerf.default | 423 | 405 | 1.04:1 |
| PopupMinimalPerf.default | 625 | 609 | 1.03:1 |
| IconMinimalPerf.default | 634 | 616 | 1.03:1 |
| TooltipMinimalPerf.default | 1118 | 1087 | 1.03:1 |
| ButtonSlotsPerf.default | 580 | 567 | 1.02:1 |
| PortalMinimalPerf.default | 189 | 185 | 1.02:1 |
| TreeMinimalPerf.default | 830 | 816 | 1.02:1 |
| VideoMinimalPerf.default | 654 | 644 | 1.02:1 |
| AccordionMinimalPerf.default | 166 | 164 | 1.01:1 |
| ButtonOverridesMissPerf.default | 1834 | 1822 | 1.01:1 |
| CheckboxMinimalPerf.default | 2858 | 2823 | 1.01:1 |
| DropdownMinimalPerf.default | 3321 | 3293 | 1.01:1 |
| InputMinimalPerf.default | 1360 | 1353 | 1.01:1 |
| ListMinimalPerf.default | 540 | 534 | 1.01:1 |
| MenuMinimalPerf.default | 866 | 858 | 1.01:1 |
| TextMinimalPerf.default | 360 | 355 | 1.01:1 |
| CustomToolbarPrototype.default | 4365 | 4329 | 1.01:1 |
| CardMinimalPerf.default | 570 | 571 | 1:1 |
| FlexMinimalPerf.default | 311 | 310 | 1:1 |
| ImageMinimalPerf.default | 384 | 383 | 1:1 |
| ItemLayoutMinimalPerf.default | 1264 | 1261 | 1:1 |
| ProviderMergeThemesPerf.default | 1821 | 1825 | 1:1 |
| ReactionMinimalPerf.default | 382 | 383 | 1:1 |
| SkeletonMinimalPerf.default | 373 | 372 | 1:1 |
| SplitButtonMinimalPerf.default | 4387 | 4383 | 1:1 |
| ToolbarMinimalPerf.default | 969 | 972 | 1:1 |
| BoxMinimalPerf.default | 357 | 359 | 0.99:1 |
| ChatDuplicateMessagesPerf.default | 310 | 312 | 0.99:1 |
| DatepickerMinimalPerf.default | 5916 | 5950 | 0.99:1 |
| DividerMinimalPerf.default | 376 | 379 | 0.99:1 |
| EmbedMinimalPerf.default | 4380 | 4407 | 0.99:1 |
| HeaderMinimalPerf.default | 380 | 383 | 0.99:1 |
| HeaderSlotsPerf.default | 779 | 784 | 0.99:1 |
| ListCommonPerf.default | 658 | 662 | 0.99:1 |
| MenuButtonMinimalPerf.default | 1702 | 1716 | 0.99:1 |
| ProviderMinimalPerf.default | 1176 | 1182 | 0.99:1 |
| TableManyItemsPerf.default | 1930 | 1952 | 0.99:1 |
| ListNestedPerf.default | 568 | 581 | 0.98:1 |
| RefMinimalPerf.default | 237 | 242 | 0.98:1 |
| TextAreaMinimalPerf.default | 495 | 505 | 0.98:1 |
| AnimationMinimalPerf.default | 417 | 428 | 0.97:1 |
| AttachmentSlotsPerf.default | 1105 | 1145 | 0.97:1 |
| GridMinimalPerf.default | 346 | 356 | 0.97:1 |
| RosterPerf.default | 1206 | 1247 | 0.97:1 |
| TreeWith60ListItems.default | 190 | 195 | 0.97:1 |
| AlertMinimalPerf.default | 279 | 291 | 0.96:1 |
| ChatMinimalPerf.default | 699 | 725 | 0.96:1 |
| LayoutMinimalPerf.default | 372 | 388 | 0.96:1 |
| RadioGroupMinimalPerf.default | 469 | 488 | 0.96:1 |
khmakoto
approved these changes
Oct 27, 2021
ecraig12345
approved these changes
Oct 27, 2021
Co-authored-by: Makoto Morimoto <humbertomakotomorimoto@gmail.com>
layershifter
enabled auto-merge (squash)
October 28, 2021 09:32
mlp73
pushed a commit
to mlp73/fluentui
that referenced
this pull request
Jan 17, 2022
…20385) * chore: add missing .babelrc.json to @fluentui/react-input * add missing dependency * fix version * Update packages/react-input/package.json Co-authored-by: Makoto Morimoto <humbertomakotomorimoto@gmail.com> Co-authored-by: Makoto Morimoto <humbertomakotomorimoto@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Addresses an existing issue: Fixes #0000Include a change request file using$ yarn changeDescription of changes
During work on #20383 I noticed that
@fluentui/react-inputdoes not have.babelrc.json, this PR adds it 👌