feat(accordion, provider): add static classes - #20451
Merged
Merged
Conversation
layershifter
commented
Nov 2, 2021
| } | ||
|
|
||
| #docs-root div[class^='fluent-provider'] { | ||
| #docs-root div[class^='fui-FluentProvider'] { |
Member
Author
There was a problem hiding this comment.
Well, this should be renamed as well.
layershifter
commented
Nov 2, 2021
| const { targetDocument, theme } = options; | ||
|
|
||
| const styleTagId = useId('fluent-provider'); | ||
| const styleTagId = useId(fluentProviderClassName); |
Member
Author
There was a problem hiding this comment.
It's also reasonable to rename classname generated for CSS variables classes
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 08bd47e97c2a14080793f78ccb57ebfb798c32eb (build) |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8725334:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1015 | 1053 | 5000 | |
| BaseButton | mount | 1063 | 1049 | 5000 | |
| Breadcrumb | mount | 2831 | 2814 | 1000 | |
| ButtonNext | mount | 573 | 542 | 5000 | |
| Checkbox | mount | 1741 | 1786 | 5000 | |
| CheckboxBase | mount | 1481 | 1442 | 5000 | |
| ChoiceGroup | mount | 5415 | 5352 | 5000 | |
| ComboBox | mount | 1093 | 1084 | 1000 | |
| CommandBar | mount | 10943 | 11052 | 1000 | |
| ContextualMenu | mount | 6824 | 6869 | 1000 | |
| DefaultButton | mount | 1232 | 1288 | 5000 | |
| DetailsRow | mount | 4123 | 4120 | 5000 | |
| DetailsRowFast | mount | 4082 | 4177 | 5000 | |
| DetailsRowNoStyles | mount | 3946 | 3979 | 5000 | |
| Dialog | mount | 2735 | 2802 | 1000 | |
| DocumentCardTitle | mount | 185 | 194 | 1000 | |
| Dropdown | mount | 3632 | 3590 | 5000 | |
| FluentProviderNext | mount | 3472 | 3531 | 5000 | |
| FluentProviderWithTheme | mount | 227 | 218 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 116 | 118 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 252 | 266 | 10 | |
| FocusTrapZone | mount | 1979 | 2057 | 5000 | |
| FocusZone | mount | 1950 | 1877 | 5000 | |
| IconButton | mount | 2034 | 1996 | 5000 | |
| Label | mount | 395 | 393 | 5000 | |
| Layer | mount | 3286 | 3276 | 5000 | |
| Link | mount | 539 | 535 | 5000 | |
| MakeStyles | mount | 1903 | 1918 | 50000 | |
| MenuButton | mount | 1711 | 1682 | 5000 | |
| MessageBar | mount | 2135 | 2091 | 5000 | |
| Nav | mount | 3771 | 3620 | 1000 | |
| OverflowSet | mount | 1229 | 1219 | 5000 | |
| Panel | mount | 2720 | 2649 | 1000 | |
| Persona | mount | 946 | 912 | 1000 | |
| Pivot | mount | 1601 | 1541 | 1000 | |
| PrimaryButton | mount | 1418 | 1427 | 5000 | |
| Rating | mount | 8964 | 8687 | 5000 | |
| SearchBox | mount | 1497 | 1540 | 5000 | |
| Shimmer | mount | 2894 | 2876 | 5000 | |
| Slider | mount | 2102 | 2193 | 5000 | |
| SpinButton | mount | 5515 | 5504 | 5000 | |
| Spinner | mount | 448 | 453 | 5000 | |
| SplitButton | mount | 3494 | 3493 | 5000 | |
| Stack | mount | 549 | 575 | 5000 | |
| StackWithIntrinsicChildren | mount | 2027 | 2027 | 5000 | |
| StackWithTextChildren | mount | 5331 | 5362 | 5000 | |
| SwatchColorPicker | mount | 11497 | 11675 | 5000 | |
| TagPicker | mount | 2891 | 2954 | 5000 | |
| TeachingBubble | mount | 13779 | 13802 | 5000 | |
| Text | mount | 502 | 489 | 5000 | |
| TextField | mount | 1536 | 1598 | 5000 | |
| ThemeProvider | mount | 1344 | 1307 | 5000 | |
| ThemeProvider | virtual-rerender | 681 | 661 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2119 | 2126 | 5000 | |
| Toggle | mount | 882 | 911 | 5000 | |
| buttonNative | mount | 147 | 137 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ButtonMinimalPerf.default | 217 | 199 | 1.09:1 |
| ChatMinimalPerf.default | 778 | 722 | 1.08:1 |
| MenuMinimalPerf.default | 986 | 925 | 1.07:1 |
| BoxMinimalPerf.default | 401 | 380 | 1.06:1 |
| CardMinimalPerf.default | 665 | 628 | 1.06:1 |
| FormMinimalPerf.default | 517 | 492 | 1.05:1 |
| HeaderMinimalPerf.default | 432 | 410 | 1.05:1 |
| RadioGroupMinimalPerf.default | 546 | 518 | 1.05:1 |
| ChatDuplicateMessagesPerf.default | 356 | 342 | 1.04:1 |
| ListNestedPerf.default | 636 | 614 | 1.04:1 |
| LoaderMinimalPerf.default | 787 | 754 | 1.04:1 |
| MenuButtonMinimalPerf.default | 1901 | 1828 | 1.04:1 |
| RefMinimalPerf.default | 265 | 255 | 1.04:1 |
| AvatarMinimalPerf.default | 233 | 226 | 1.03:1 |
| DatepickerMinimalPerf.default | 6276 | 6086 | 1.03:1 |
| InputMinimalPerf.default | 1430 | 1395 | 1.03:1 |
| SegmentMinimalPerf.default | 414 | 403 | 1.03:1 |
| ToolbarMinimalPerf.default | 1081 | 1049 | 1.03:1 |
| VideoMinimalPerf.default | 721 | 697 | 1.03:1 |
| ListCommonPerf.default | 720 | 704 | 1.02:1 |
| ListMinimalPerf.default | 579 | 569 | 1.02:1 |
| SliderMinimalPerf.default | 1897 | 1859 | 1.02:1 |
| StatusMinimalPerf.default | 767 | 750 | 1.02:1 |
| TableMinimalPerf.default | 472 | 463 | 1.02:1 |
| TextMinimalPerf.default | 407 | 398 | 1.02:1 |
| ButtonSlotsPerf.default | 641 | 632 | 1.01:1 |
| CarouselMinimalPerf.default | 539 | 535 | 1.01:1 |
| FlexMinimalPerf.default | 335 | 331 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 1384 | 1365 | 1.01:1 |
| ListWith60ListItems.default | 724 | 718 | 1.01:1 |
| SplitButtonMinimalPerf.default | 4819 | 4769 | 1.01:1 |
| IconMinimalPerf.default | 722 | 713 | 1.01:1 |
| TableManyItemsPerf.default | 2216 | 2203 | 1.01:1 |
| ButtonOverridesMissPerf.default | 1997 | 1989 | 1:1 |
| DropdownMinimalPerf.default | 3528 | 3513 | 1:1 |
| HeaderSlotsPerf.default | 856 | 852 | 1:1 |
| LayoutMinimalPerf.default | 400 | 400 | 1:1 |
| RosterPerf.default | 1348 | 1349 | 1:1 |
| ProviderMinimalPerf.default | 1268 | 1264 | 1:1 |
| ReactionMinimalPerf.default | 449 | 447 | 1:1 |
| SkeletonMinimalPerf.default | 405 | 405 | 1:1 |
| TooltipMinimalPerf.default | 1176 | 1177 | 1:1 |
| AnimationMinimalPerf.default | 458 | 463 | 0.99:1 |
| ChatWithPopoverPerf.default | 450 | 455 | 0.99:1 |
| CheckboxMinimalPerf.default | 3014 | 3049 | 0.99:1 |
| DividerMinimalPerf.default | 421 | 424 | 0.99:1 |
| DropdownManyItemsPerf.default | 801 | 809 | 0.99:1 |
| EmbedMinimalPerf.default | 4785 | 4822 | 0.99:1 |
| LabelMinimalPerf.default | 446 | 450 | 0.99:1 |
| PortalMinimalPerf.default | 188 | 189 | 0.99:1 |
| TextAreaMinimalPerf.default | 582 | 590 | 0.99:1 |
| AttachmentSlotsPerf.default | 1218 | 1241 | 0.98:1 |
| PopupMinimalPerf.default | 651 | 667 | 0.98:1 |
| ProviderMergeThemesPerf.default | 1804 | 1843 | 0.98:1 |
| CustomToolbarPrototype.default | 4484 | 4562 | 0.98:1 |
| TreeWith60ListItems.default | 218 | 222 | 0.98:1 |
| DialogMinimalPerf.default | 837 | 863 | 0.97:1 |
| TreeMinimalPerf.default | 888 | 912 | 0.97:1 |
| GridMinimalPerf.default | 396 | 413 | 0.96:1 |
| ImageMinimalPerf.default | 411 | 430 | 0.96:1 |
| AccordionMinimalPerf.default | 173 | 182 | 0.95:1 |
| AttachmentMinimalPerf.default | 174 | 185 | 0.94:1 |
| AlertMinimalPerf.default | 306 | 330 | 0.93:1 |
khmakoto
approved these changes
Nov 2, 2021
ling1726
approved these changes
Nov 3, 2021
mlp73
pushed a commit
to mlp73/fluentui
that referenced
this pull request
Jan 17, 2022
* feat(accordion, provider): add static classes * use import * fix change files * Change files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
✅ Extracted from #20383, these changes passed conformance test on that PR
This PR adds static classes to components
@fluentui/react-accordion&@fluentui/react-provider.fui-ComponentNamecomponentNameClassName