Skip to content

feat(avatar, badge): add static classes - #20453

Merged
layershifter merged 1 commit into
masterfrom
feat/classname-p5
Nov 3, 2021
Merged

feat(avatar, badge): add static classes#20453
layershifter merged 1 commit into
masterfrom
feat/classname-p5

Conversation

@layershifter

Copy link
Copy Markdown
Member

Pull request checklist

Description of changes

Extracted from #20383, these changes passed conformance test on that PR

This PR adds static classes to components @fluentui/react-avatar & @fluentui/react-badge.

  • All classes follow fui-ComponentName
  • All classes are publicly exported as componentNameClassName
  • Snapshots were updated

@fabricteam

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-avatar
Avatar
54.966 kB
15.674 kB
55.013 kB
15.693 kB
47 B
19 B
react-badge
Badge
23.195 kB
6.992 kB
23.207 kB
6.998 kB
12 B
6 B
react-badge
CounterBadge
25.655 kB
7.688 kB
25.686 kB
7.698 kB
31 B
10 B
react-badge
PresenceBadge
30.674 kB
8.821 kB
30.706 kB
8.831 kB
32 B
10 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
169.429 kB
48.08 kB
react-components
react-components: FluentProvider & webLightTheme
32.201 kB
10.665 kB
🤖 This report was generated against 08bd47e97c2a14080793f78ccb57ebfb798c32eb

@size-auditor

size-auditor Bot commented Nov 2, 2021

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 08bd47e97c2a14080793f78ccb57ebfb798c32eb (build)

@fabricteam

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 950 969 5000
BaseButton mount 952 934 5000
Breadcrumb mount 2742 2725 1000
ButtonNext mount 534 534 5000
Checkbox mount 1601 1621 5000
CheckboxBase mount 1369 1346 5000
ChoiceGroup mount 4856 4858 5000
ComboBox mount 969 1015 1000
CommandBar mount 10790 10572 1000
ContextualMenu mount 6715 6733 1000
DefaultButton mount 1157 1165 5000
DetailsRow mount 3886 3917 5000
DetailsRowFast mount 3890 3911 5000
DetailsRowNoStyles mount 3795 3770 5000
Dialog mount 2626 2676 1000
DocumentCardTitle mount 170 187 1000
Dropdown mount 3275 3350 5000
FluentProviderNext mount 3504 3482 5000
FluentProviderWithTheme mount 212 211 10
FluentProviderWithTheme virtual-rerender 101 112 10
FluentProviderWithTheme virtual-rerender-with-unmount 257 249 10
FocusTrapZone mount 1853 1813 5000
FocusZone mount 1900 1865 5000
IconButton mount 1778 1849 5000
Label mount 363 368 5000
Layer mount 3050 3056 5000
Link mount 494 500 5000
MakeStyles mount 1866 1895 50000
MenuButton mount 1580 1521 5000
MessageBar mount 2120 2113 5000
Nav mount 3432 3390 1000
OverflowSet mount 1176 1143 5000
Panel mount 2518 2584 1000
Persona mount 885 844 1000
Pivot mount 1502 1463 1000
PrimaryButton mount 1345 1321 5000
Rating mount 8137 7951 5000
SearchBox mount 1361 1361 5000
Shimmer mount 2575 2573 5000
Slider mount 1957 1987 5000
SpinButton mount 5066 5127 5000
Spinner mount 449 446 5000
SplitButton mount 3275 3227 5000
Stack mount 518 521 5000
StackWithIntrinsicChildren mount 1746 1710 5000
StackWithTextChildren mount 4702 4712 5000
SwatchColorPicker mount 10582 10799 5000
TagPicker mount 2690 2611 5000
TeachingBubble mount 13511 13431 5000
Text mount 478 484 5000
TextField mount 1412 1386 5000
ThemeProvider mount 1233 1241 5000
ThemeProvider virtual-rerender 652 669 5000
ThemeProvider virtual-rerender-with-unmount 1948 1952 5000
Toggle mount 847 855 5000
buttonNative mount 140 145 5000

Perf Analysis (@fluentui/react-northstar)

⚠️ 2 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
AccordionMinimalPerf.default 155 153 1.01:1 analysis
TextMinimalPerf.default 347 349 0.99:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
LabelMinimalPerf.default 408 374 1.09:1
TreeWith60ListItems.default 197 181 1.09:1
RefMinimalPerf.default 254 238 1.07:1
ChatDuplicateMessagesPerf.default 313 295 1.06:1
PortalMinimalPerf.default 188 177 1.06:1
AvatarMinimalPerf.default 201 194 1.04:1
HeaderSlotsPerf.default 769 742 1.04:1
StatusMinimalPerf.default 709 679 1.04:1
TableMinimalPerf.default 415 398 1.04:1
DropdownManyItemsPerf.default 693 670 1.03:1
HeaderMinimalPerf.default 362 353 1.03:1
ListCommonPerf.default 642 625 1.03:1
PopupMinimalPerf.default 617 600 1.03:1
TreeMinimalPerf.default 825 801 1.03:1
ButtonSlotsPerf.default 557 545 1.02:1
DividerMinimalPerf.default 362 356 1.02:1
SkeletonMinimalPerf.default 355 348 1.02:1
VideoMinimalPerf.default 654 639 1.02:1
AttachmentMinimalPerf.default 162 160 1.01:1
AttachmentSlotsPerf.default 1076 1061 1.01:1
ButtonOverridesMissPerf.default 1829 1812 1.01:1
DatepickerMinimalPerf.default 5607 5525 1.01:1
ImageMinimalPerf.default 378 373 1.01:1
InputMinimalPerf.default 1326 1318 1.01:1
ItemLayoutMinimalPerf.default 1243 1233 1.01:1
ListMinimalPerf.default 520 515 1.01:1
SliderMinimalPerf.default 1720 1705 1.01:1
ToolbarMinimalPerf.default 952 943 1.01:1
ChatMinimalPerf.default 650 652 1:1
ChatWithPopoverPerf.default 389 389 1:1
CheckboxMinimalPerf.default 2754 2760 1:1
DialogMinimalPerf.default 742 741 1:1
FlexMinimalPerf.default 285 286 1:1
LayoutMinimalPerf.default 377 378 1:1
MenuButtonMinimalPerf.default 1676 1668 1:1
RadioGroupMinimalPerf.default 453 452 1:1
SplitButtonMinimalPerf.default 4280 4291 1:1
CustomToolbarPrototype.default 4182 4186 1:1
TooltipMinimalPerf.default 1059 1060 1:1
CardMinimalPerf.default 543 550 0.99:1
DropdownMinimalPerf.default 3200 3234 0.99:1
EmbedMinimalPerf.default 4280 4335 0.99:1
GridMinimalPerf.default 330 334 0.99:1
ProviderMinimalPerf.default 1136 1145 0.99:1
SegmentMinimalPerf.default 347 351 0.99:1
ButtonMinimalPerf.default 177 180 0.98:1
CarouselMinimalPerf.default 460 470 0.98:1
MenuMinimalPerf.default 834 854 0.98:1
ProviderMergeThemesPerf.default 1792 1824 0.98:1
ReactionMinimalPerf.default 378 385 0.98:1
IconMinimalPerf.default 617 631 0.98:1
TableManyItemsPerf.default 1896 1934 0.98:1
TextAreaMinimalPerf.default 506 518 0.98:1
AnimationMinimalPerf.default 415 426 0.97:1
ListWith60ListItems.default 649 666 0.97:1
LoaderMinimalPerf.default 694 712 0.97:1
RosterPerf.default 1213 1248 0.97:1
BoxMinimalPerf.default 352 365 0.96:1
ListNestedPerf.default 551 582 0.95:1
AlertMinimalPerf.default 263 287 0.92:1
FormMinimalPerf.default 389 425 0.92:1

@layershifter
layershifter merged commit e42f506 into master Nov 3, 2021
@layershifter
layershifter deleted the feat/classname-p5 branch November 8, 2021 10:51
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants