fix(react-conformance): update paths generated in defaultErrorMessages by layershifter · Pull Request #20580 · microsoft/fluentui

layershifter · 2021-11-11T11:05:09Z

Pull request checklist

~~Addresses an existing issue: Fixes #0000~~
Include a change request file using $ yarn change

Description of changes

This PR is a follow up based on @ecraig12345 comment (#20383 (comment)).

Fixes paths that are used in defaultErrorMessages.tsx, uses the same function as in defaultTests.tsx.

…ix/conformance-paths

size-auditor · 2021-11-11T11:20:16Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 9e6977945782df1cc997c92804a1b214cc4e4f43 (build)

fabricteam · 2021-11-11T11:26:38Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`react-accordion` Accordion (including children components)	`57.542 kB` `18.214 kB`
`react-avatar` Avatar	`54.097 kB` `15.331 kB`
`react-badge` Badge	`22.394 kB` `6.707 kB`
`react-badge` CounterBadge	`24.773 kB` `7.387 kB`
`react-badge` PresenceBadge	`29.768 kB` `8.517 kB`
`react-button` Button	`24.651 kB` `7.462 kB`
`react-button` CompoundButton	`29.939 kB` `8.418 kB`
`react-button` MenuButton	`27.046 kB` `8.227 kB`
`react-button` SplitButton	`33.261 kB` `9.328 kB`
`react-button` ToggleButton	`33.78 kB` `8.065 kB`
`react-card` Card - All	`50.038 kB` `14.802 kB`
`react-card` Card	`45.458 kB` `13.574 kB`
`react-card` CardFooter	`7.418 kB` `3.182 kB`
`react-card` CardHeader	`8.778 kB` `3.64 kB`
`react-card` CardPreview	`7.682 kB` `3.341 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`169.304 kB` `48.469 kB`
`react-components` react-components: FluentProvider & webLightTheme	`32.54 kB` `10.63 kB`
`react-divider` Divider	`14.828 kB` `5.375 kB`
`react-image` Image	`9.041 kB` `3.734 kB`
`react-input` Input	`13.842 kB` `4.965 kB`
`react-label` Label	`8.177 kB` `3.445 kB`
`react-link` Link	`10.883 kB` `4.449 kB`
`react-menu` Menu (including children components)	`105.392 kB` `32.533 kB`
`react-menu` Menu (including selectable components)	`107.78 kB` `32.898 kB`
`react-popover` Popover	`101.092 kB` `30.67 kB`
`react-portal` Portal	`6.621 kB` `2.226 kB`
`react-provider` FluentProvider	`14.056 kB` `5.267 kB`
`react-slider` RangedSlider	`39.807 kB` `11.491 kB`
`react-slider` Slider	`33.196 kB` `10.312 kB`
`react-switch` Switch	`25.311 kB` `8.143 kB`
`react-text` Text - Default	`10.603 kB` `4.172 kB`
`react-text` Text - Wrappers	`13.899 kB` `4.513 kB`
`react-tooltip` Tooltip	`43.871 kB` `15.165 kB`

_{🤖 This report was generated against fe9829e4818f9bb7206df37747d5da332706ae4b}

fabricteam · 2021-11-11T11:36:04Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	922	930	5000
BaseButton	mount	909	901	5000
Breadcrumb	mount	2613	2600	1000
ButtonNext	mount	513	499	5000
Checkbox	mount	1524	1561	5000
CheckboxBase	mount	1284	1295	5000
ChoiceGroup	mount	4699	4636	5000
ComboBox	mount	967	973	1000
CommandBar	mount	10106	10093	1000
ContextualMenu	mount	8347	8477	1000
DefaultButton	mount	1123	1117	5000
DetailsRow	mount	3843	3721	5000
DetailsRowFast	mount	3717	3690	5000
DetailsRowNoStyles	mount	3605	3586	5000
Dialog	mount	2606	2554	1000
DocumentCardTitle	mount	171	165	1000
Dropdown	mount	3167	3181	5000
FluentProviderNext	mount	4075	4127	5000
FluentProviderWithTheme	mount	248	246	10
FluentProviderWithTheme	virtual-rerender	114	98	10
FluentProviderWithTheme	virtual-rerender-with-unmount	275	243	10
FocusTrapZone	mount	1816	1820	5000
FocusZone	mount	1835	1811	5000
IconButton	mount	1791	1771	5000
Label	mount	347	343	5000
Layer	mount	3006	2981	5000
Link	mount	479	483	5000
MakeStyles	mount	1769	1829	50000
MenuButton	mount	1472	1509	5000
MessageBar	mount	2005	2004	5000
Nav	mount	3324	3330	1000
OverflowSet	mount	1111	1131	5000
Panel	mount	2507	2518	1000
Persona	mount	851	855	1000
Pivot	mount	1413	1414	1000
PrimaryButton	mount	1279	1314	5000
Rating	mount	7597	7669	5000
SearchBox	mount	1361	1319	5000
Shimmer	mount	2514	2535	5000
Slider	mount	1939	1933	5000
SpinButton	mount	5004	4967	5000
Spinner	mount	452	433	5000
SplitButton	mount	3140	3221	5000
Stack	mount	508	511	5000
StackWithIntrinsicChildren	mount	1682	1702	5000
StackWithTextChildren	mount	4569	4616	5000
SwatchColorPicker	mount	10435	10442	5000
TagPicker	mount	2585	2659	5000
TeachingBubble	mount	12968	12980	5000
Text	mount	444	428	5000
TextField	mount	1352	1402	5000
ThemeProvider	mount	1198	1192	5000
ThemeProvider	virtual-rerender	595	611	5000
ThemeProvider	virtual-rerender-with-unmount	1895	1932	5000
Toggle	mount	791	819	5000
buttonNative	mount	130	130	5000

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
AttachmentMinimalPerf.default	168	154	1.09:1
TextMinimalPerf.default	351	330	1.06:1
CardMinimalPerf.default	556	532	1.05:1
HeaderMinimalPerf.default	367	348	1.05:1
RefMinimalPerf.default	242	230	1.05:1
TreeMinimalPerf.default	820	783	1.05:1
VideoMinimalPerf.default	620	591	1.05:1
FlexMinimalPerf.default	286	276	1.04:1
AttachmentSlotsPerf.default	1065	1030	1.03:1
ChatDuplicateMessagesPerf.default	308	298	1.03:1
ChatMinimalPerf.default	663	646	1.03:1
ChatWithPopoverPerf.default	388	377	1.03:1
DropdownManyItemsPerf.default	694	673	1.03:1
MenuMinimalPerf.default	843	822	1.03:1
PopupMinimalPerf.default	599	579	1.03:1
PortalMinimalPerf.default	183	178	1.03:1
RadioGroupMinimalPerf.default	453	438	1.03:1
ReactionMinimalPerf.default	385	375	1.03:1
SkeletonMinimalPerf.default	358	347	1.03:1
AnimationMinimalPerf.default	412	404	1.02:1
ButtonOverridesMissPerf.default	1782	1751	1.02:1
DividerMinimalPerf.default	363	355	1.02:1
FormMinimalPerf.default	403	394	1.02:1
InputMinimalPerf.default	1322	1298	1.02:1
ProviderMergeThemesPerf.default	1727	1694	1.02:1
IconMinimalPerf.default	616	603	1.02:1
CarouselMinimalPerf.default	465	459	1.01:1
CheckboxMinimalPerf.default	2757	2725	1.01:1
GridMinimalPerf.default	334	330	1.01:1
ListMinimalPerf.default	502	497	1.01:1
ListWith60ListItems.default	659	653	1.01:1
LoaderMinimalPerf.default	700	690	1.01:1
CustomToolbarPrototype.default	4087	4065	1.01:1
ButtonSlotsPerf.default	540	541	1:1
DialogMinimalPerf.default	761	760	1:1
DropdownMinimalPerf.default	3167	3169	1:1
EmbedMinimalPerf.default	4271	4257	1:1
HeaderSlotsPerf.default	750	749	1:1
ImageMinimalPerf.default	366	367	1:1
ItemLayoutMinimalPerf.default	1211	1216	1:1
LabelMinimalPerf.default	385	384	1:1
ListCommonPerf.default	615	616	1:1
MenuButtonMinimalPerf.default	1651	1653	1:1
RosterPerf.default	1197	1196	1:1
ProviderMinimalPerf.default	1121	1116	1:1
SegmentMinimalPerf.default	336	336	1:1
SliderMinimalPerf.default	1718	1718	1:1
SplitButtonMinimalPerf.default	4207	4227	1:1
TableMinimalPerf.default	386	386	1:1
TextAreaMinimalPerf.default	487	487	1:1
TooltipMinimalPerf.default	1005	1008	1:1
BoxMinimalPerf.default	341	344	0.99:1
LayoutMinimalPerf.default	354	357	0.99:1
ListNestedPerf.default	560	563	0.99:1
TableManyItemsPerf.default	1856	1880	0.99:1
ToolbarMinimalPerf.default	925	936	0.99:1
AvatarMinimalPerf.default	192	196	0.98:1
DatepickerMinimalPerf.default	5344	5456	0.98:1
AlertMinimalPerf.default	260	269	0.97:1
ButtonMinimalPerf.default	174	179	0.97:1
AccordionMinimalPerf.default	149	155	0.96:1
StatusMinimalPerf.default	650	678	0.96:1
TreeWith60ListItems.default	174	183	0.95:1

codesandbox-ci · 2021-11-11T11:47:46Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8b36c45:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

ecraig12345

Thanks for fixing this!

…ecb0fb58e.json Co-authored-by: Elizabeth Craig <elcraig@microsoft.com>

microsoft#20580) * fix * fix paths * Change files * Update change/@fluentui-react-conformance-90ba2958-fc3c-4b00-9180-740ecb0fb58e.json Co-authored-by: Elizabeth Craig <elcraig@microsoft.com> Co-authored-by: Elizabeth Craig <elcraig@microsoft.com>

layershifter added 4 commits November 11, 2021 11:58

fix

b0b172b

Merge branch 'master' of https://github.com/microsoft/fluentui into f…

0225f7f

…ix/conformance-paths

fix paths

c1f4815

Change files

8c47bf2

msft-fluent-ui-bot assigned khmakoto Nov 11, 2021

ecraig12345 approved these changes Nov 11, 2021

View reviewed changes

Comment thread change/@fluentui-react-conformance-90ba2958-fc3c-4b00-9180-740ecb0fb58e.json Outdated

Update change/@fluentui-react-conformance-90ba2958-fc3c-4b00-9180-740…

8b36c45

…ecb0fb58e.json Co-authored-by: Elizabeth Craig <elcraig@microsoft.com>

layershifter enabled auto-merge (squash) November 12, 2021 09:33

layershifter merged commit afe1d6b into master Nov 12, 2021

layershifter deleted the fix/conformance-paths branch November 24, 2021 11:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(react-conformance): update paths generated in defaultErrorMessages - #20580

fix(react-conformance): update paths generated in defaultErrorMessages#20580
layershifter merged 5 commits into
masterfrom
fix/conformance-paths

layershifter commented Nov 11, 2021

Uh oh!

size-auditor Bot commented Nov 11, 2021 •

edited

Loading

Uh oh!

fabricteam commented Nov 11, 2021 •

edited

Loading

Uh oh!

fabricteam commented Nov 11, 2021 •

edited

Loading

Uh oh!

codesandbox-ci Bot commented Nov 11, 2021 •

edited

Loading

Uh oh!

ecraig12345 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

layershifter commented Nov 11, 2021

Pull request checklist

Description of changes

Uh oh!

size-auditor Bot commented Nov 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

fabricteam commented Nov 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

fabricteam commented Nov 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Perf Analysis (@fluentui/react-northstar)

Uh oh!

codesandbox-ci Bot commented Nov 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ecraig12345 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

size-auditor Bot commented Nov 11, 2021 •

edited

Loading

fabricteam commented Nov 11, 2021 •

edited

Loading

fabricteam commented Nov 11, 2021 •

edited

Loading

Perf Analysis (`@fluentui/react`)

Perf Analysis (`@fluentui/react-northstar`)

codesandbox-ci Bot commented Nov 11, 2021 •

edited

Loading