Skip to content

chore(babel-make-styles): update fixtures#20784

Merged
layershifter merged 2 commits into
masterfrom
chore/update-b-fixtures
Nov 25, 2021
Merged

chore(babel-make-styles): update fixtures#20784
layershifter merged 2 commits into
masterfrom
chore/update-b-fixtures

Conversation

@layershifter

Copy link
Copy Markdown
Member

Pull request checklist

Description of changes

This PR updates Babel plugin fixtures to not use CSS shorthands as in #20573 we agreed to not support them.

@codesandbox-ci

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7ef35a9:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

🤖 This report was generated against 395532884d45107a9c536778774e65151c1ba123

@size-auditor

size-auditor Bot commented Nov 25, 2021

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4e92e7760740dd2f6a57bade6eeebb0b250b4898 (build)

@fabricteam

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1100 1113 5000
BaseButton mount 1146 1142 5000
Breadcrumb mount 2789 2842 1000
ButtonNext mount 697 677 5000
Checkbox mount 1787 1779 5000
CheckboxBase mount 1524 1539 5000
ChoiceGroup mount 5347 5182 5000
ComboBox mount 1226 1197 1000
CommandBar mount 10433 10410 1000
ContextualMenu mount 8612 8623 1000
DefaultButton mount 1363 1365 5000
DetailsRow mount 4257 4164 5000
DetailsRowFast mount 4177 4146 5000
DetailsRowNoStyles mount 4058 3926 5000
Dialog mount 2891 2823 1000
DocumentCardTitle mount 340 298 1000
Dropdown mount 3580 3491 5000
FluentProviderNext mount 4094 4144 5000
FluentProviderWithTheme mount 378 403 10
FluentProviderWithTheme virtual-rerender 256 258 10
FluentProviderWithTheme virtual-rerender-with-unmount 419 398 10
FocusTrapZone mount 2038 1994 5000
FocusZone mount 2050 2029 5000
IconButton mount 2043 2019 5000
Label mount 513 530 5000
Layer mount 3323 3301 5000
Link mount 664 629 5000
MakeStyles mount 1912 1945 50000
MenuButton mount 1773 1739 5000
MessageBar mount 2175 2191 5000
Nav mount 3619 3626 1000
OverflowSet mount 1334 1343 5000
Panel mount 2707 2742 1000
Persona mount 996 1051 1000
Pivot mount 1641 1653 1000
PrimaryButton mount 1526 1527 5000
Rating mount 8700 8675 5000
SearchBox mount 1605 1600 5000
Shimmer mount 2871 2923 5000
Slider mount 2223 2234 5000
SpinButton mount 5356 5367 5000
Spinner mount 578 577 5000
SplitButton mount 3570 3528 5000
Stack mount 677 684 5000
StackWithIntrinsicChildren mount 2013 2010 5000
StackWithTextChildren mount 5227 5256 5000
SwatchColorPicker mount 12163 11256 5000
TagPicker mount 2968 2912 5000
TeachingBubble mount 13485 13651 5000
Text mount 601 606 5000
TextField mount 1640 1641 5000
ThemeProvider mount 1373 1392 5000
ThemeProvider virtual-rerender 772 798 5000
ThemeProvider virtual-rerender-with-unmount 2213 2195 5000
Toggle mount 1010 1013 5000
buttonNative mount 263 304 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 215 187 1.15:1
PortalMinimalPerf.default 186 174 1.07:1
AlertMinimalPerf.default 312 295 1.06:1
ButtonSlotsPerf.default 607 572 1.06:1
ChatMinimalPerf.default 738 696 1.06:1
ChatWithPopoverPerf.default 427 401 1.06:1
FormMinimalPerf.default 459 434 1.06:1
BoxMinimalPerf.default 382 365 1.05:1
ListWith60ListItems.default 699 666 1.05:1
SegmentMinimalPerf.default 401 381 1.05:1
TextMinimalPerf.default 378 361 1.05:1
VideoMinimalPerf.default 666 633 1.05:1
AnimationMinimalPerf.default 459 443 1.04:1
InputMinimalPerf.default 1367 1314 1.04:1
DialogMinimalPerf.default 821 795 1.03:1
LayoutMinimalPerf.default 390 378 1.03:1
ProviderMergeThemesPerf.default 1710 1659 1.03:1
SkeletonMinimalPerf.default 407 396 1.03:1
IconMinimalPerf.default 648 631 1.03:1
EmbedMinimalPerf.default 4372 4301 1.02:1
HeaderMinimalPerf.default 426 418 1.02:1
ImageMinimalPerf.default 421 414 1.02:1
LabelMinimalPerf.default 421 411 1.02:1
ListNestedPerf.default 593 584 1.02:1
RosterPerf.default 1366 1345 1.02:1
TableManyItemsPerf.default 2083 2045 1.02:1
TableMinimalPerf.default 433 426 1.02:1
CustomToolbarPrototype.default 4166 4076 1.02:1
ToolbarMinimalPerf.default 1009 989 1.02:1
AttachmentMinimalPerf.default 177 176 1.01:1
AvatarMinimalPerf.default 216 214 1.01:1
CardMinimalPerf.default 617 612 1.01:1
CarouselMinimalPerf.default 502 498 1.01:1
DropdownManyItemsPerf.default 736 728 1.01:1
DropdownMinimalPerf.default 3101 3077 1.01:1
FlexMinimalPerf.default 311 307 1.01:1
ListCommonPerf.default 697 688 1.01:1
MenuMinimalPerf.default 904 891 1.01:1
PopupMinimalPerf.default 608 601 1.01:1
TreeMinimalPerf.default 861 853 1.01:1
AccordionMinimalPerf.default 177 177 1:1
ButtonOverridesMissPerf.default 1777 1770 1:1
DatepickerMinimalPerf.default 5688 5662 1:1
DividerMinimalPerf.default 394 395 1:1
GridMinimalPerf.default 373 374 1:1
ListMinimalPerf.default 546 548 1:1
ReactionMinimalPerf.default 405 403 1:1
SliderMinimalPerf.default 1751 1750 1:1
SplitButtonMinimalPerf.default 4525 4505 1:1
TextAreaMinimalPerf.default 555 555 1:1
AttachmentSlotsPerf.default 1115 1127 0.99:1
HeaderSlotsPerf.default 834 839 0.99:1
ItemLayoutMinimalPerf.default 1262 1269 0.99:1
LoaderMinimalPerf.default 696 702 0.99:1
MenuButtonMinimalPerf.default 1731 1740 0.99:1
ProviderMinimalPerf.default 1153 1170 0.99:1
RadioGroupMinimalPerf.default 489 492 0.99:1
RefMinimalPerf.default 242 245 0.99:1
TooltipMinimalPerf.default 1103 1118 0.99:1
CheckboxMinimalPerf.default 2763 2829 0.98:1
StatusMinimalPerf.default 725 750 0.97:1
ChatDuplicateMessagesPerf.default 299 331 0.9:1
TreeWith60ListItems.default 196 224 0.88:1

@layershifter
layershifter merged commit b851427 into master Nov 25, 2021
@layershifter
layershifter deleted the chore/update-b-fixtures branch November 25, 2021 14:43
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
* chore(babel-make-styles): update fixtures

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants