Skip to content

chore(react-provider): update stories to not use CSS shorthands#20790

Merged
layershifter merged 1 commit into
masterfrom
chore/shorthands-provider
Nov 26, 2021
Merged

chore(react-provider): update stories to not use CSS shorthands#20790
layershifter merged 1 commit into
masterfrom
chore/shorthands-provider

Conversation

@layershifter

Copy link
Copy Markdown
Member

Pull request checklist

Description of changes

This PR updates stories to not use CSS shorthands. Also removes codesandbox-dependency comments.

@fabricteam

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

🤖 This report was generated against bd3e92b5193176665879abd667db4350ffcc35ea

@codesandbox-ci

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 616e262:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor

size-auditor Bot commented Nov 26, 2021

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: bd3e92b5193176665879abd667db4350ffcc35ea (build)

@fabricteam

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1036 1064 5000
BaseButton mount 1059 1076 5000
Breadcrumb mount 2812 2961 1000
ButtonNext mount 666 639 5000
Checkbox mount 1718 1732 5000
CheckboxBase mount 1479 1454 5000
ChoiceGroup mount 5103 5008 5000
ComboBox mount 1102 1137 1000
CommandBar mount 10765 10651 1000
ContextualMenu mount 8831 8954 1000
DefaultButton mount 1332 1316 5000
DetailsRow mount 4076 4124 5000
DetailsRowFast mount 4180 3975 5000
DetailsRowNoStyles mount 3816 3891 5000
Dialog mount 2779 2721 1000
DocumentCardTitle mount 280 288 1000
Dropdown mount 3424 3422 5000
FluentProviderNext mount 4356 4312 5000
FluentProviderWithTheme mount 377 368 10
FluentProviderWithTheme virtual-rerender 232 225 10
FluentProviderWithTheme virtual-rerender-with-unmount 404 406 10
FocusTrapZone mount 1993 2030 5000
FocusZone mount 2064 2005 5000
IconButton mount 1940 1968 5000
Label mount 481 507 5000
Layer mount 3171 3201 5000
Link mount 658 603 5000
MakeStyles mount 2042 1980 50000
MenuButton mount 1703 1668 5000
MessageBar mount 2212 2155 5000
Nav mount 3599 3477 1000
OverflowSet mount 1298 1232 5000
Panel mount 2658 2673 1000
Persona mount 985 1015 1000
Pivot mount 1592 1622 1000
PrimaryButton mount 1471 1453 5000
Rating mount 7939 8074 5000
SearchBox mount 1534 1526 5000
Shimmer mount 2801 2748 5000
Slider mount 2121 2104 5000
SpinButton mount 5358 5234 5000
Spinner mount 575 564 5000
SplitButton mount 3363 3385 5000
Stack mount 622 641 5000
StackWithIntrinsicChildren mount 1911 1839 5000
StackWithTextChildren mount 4881 4894 5000
SwatchColorPicker mount 10834 10840 5000
TagPicker mount 2897 2799 5000
TeachingBubble mount 13591 13697 5000
Text mount 574 604 5000
TextField mount 1543 1616 5000
ThemeProvider mount 1363 1327 5000
ThemeProvider virtual-rerender 758 758 5000
ThemeProvider virtual-rerender-with-unmount 2086 2098 5000
Toggle mount 955 968 5000
buttonNative mount 272 266 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TreeWith60ListItems.default 199 183 1.09:1
AvatarMinimalPerf.default 208 192 1.08:1
FormMinimalPerf.default 427 397 1.08:1
LayoutMinimalPerf.default 377 353 1.07:1
ProviderMinimalPerf.default 1261 1179 1.07:1
PopupMinimalPerf.default 639 604 1.06:1
ChatWithPopoverPerf.default 403 382 1.05:1
RadioGroupMinimalPerf.default 485 462 1.05:1
SegmentMinimalPerf.default 368 351 1.05:1
IconMinimalPerf.default 646 615 1.05:1
AnimationMinimalPerf.default 445 429 1.04:1
ChatMinimalPerf.default 690 665 1.04:1
DropdownManyItemsPerf.default 704 677 1.04:1
HeaderSlotsPerf.default 798 769 1.04:1
ImageMinimalPerf.default 396 380 1.04:1
ReactionMinimalPerf.default 386 372 1.04:1
DialogMinimalPerf.default 791 765 1.03:1
LabelMinimalPerf.default 405 394 1.03:1
ToolbarMinimalPerf.default 990 965 1.03:1
AlertMinimalPerf.default 291 286 1.02:1
AttachmentMinimalPerf.default 165 162 1.02:1
AttachmentSlotsPerf.default 1132 1108 1.02:1
ButtonSlotsPerf.default 581 571 1.02:1
CarouselMinimalPerf.default 492 480 1.02:1
EmbedMinimalPerf.default 4306 4207 1.02:1
FlexMinimalPerf.default 293 288 1.02:1
ListNestedPerf.default 567 554 1.02:1
PortalMinimalPerf.default 188 185 1.02:1
TooltipMinimalPerf.default 1047 1027 1.02:1
AccordionMinimalPerf.default 163 161 1.01:1
BoxMinimalPerf.default 355 351 1.01:1
CheckboxMinimalPerf.default 2702 2677 1.01:1
HeaderMinimalPerf.default 366 361 1.01:1
ListWith60ListItems.default 673 664 1.01:1
SplitButtonMinimalPerf.default 4396 4367 1.01:1
StatusMinimalPerf.default 688 680 1.01:1
ButtonOverridesMissPerf.default 1740 1743 1:1
InputMinimalPerf.default 1328 1323 1:1
ItemLayoutMinimalPerf.default 1241 1242 1:1
ListCommonPerf.default 659 660 1:1
ProviderMergeThemesPerf.default 1768 1767 1:1
SkeletonMinimalPerf.default 363 364 1:1
TableManyItemsPerf.default 1960 1962 1:1
DatepickerMinimalPerf.default 5811 5841 0.99:1
DividerMinimalPerf.default 379 381 0.99:1
MenuButtonMinimalPerf.default 1679 1698 0.99:1
RosterPerf.default 1240 1256 0.99:1
RefMinimalPerf.default 246 249 0.99:1
SliderMinimalPerf.default 1701 1718 0.99:1
TextMinimalPerf.default 358 361 0.99:1
TextAreaMinimalPerf.default 513 519 0.99:1
CustomToolbarPrototype.default 4208 4274 0.98:1
DropdownMinimalPerf.default 3025 3124 0.97:1
ListMinimalPerf.default 512 530 0.97:1
MenuMinimalPerf.default 883 907 0.97:1
TableMinimalPerf.default 415 427 0.97:1
VideoMinimalPerf.default 639 657 0.97:1
CardMinimalPerf.default 572 598 0.96:1
ChatDuplicateMessagesPerf.default 292 308 0.95:1
LoaderMinimalPerf.default 693 726 0.95:1
TreeMinimalPerf.default 786 828 0.95:1
GridMinimalPerf.default 341 364 0.94:1
ButtonMinimalPerf.default 172 186 0.92:1

@layershifter
layershifter merged commit d11a238 into master Nov 26, 2021
@layershifter
layershifter deleted the chore/shorthands-provider branch November 26, 2021 12:01
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants