chore(react-portal): update stories to not use CSS shorthands in styles#20791
Merged
Conversation
Collaborator
📊 Bundle size report🤖 This report was generated against bd3e92b5193176665879abd667db4350ffcc35ea |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d157d82:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: bd3e92b5193176665879abd667db4350ffcc35ea (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 863 | 869 | 5000 | |
| BaseButton | mount | 878 | 888 | 5000 | |
| Breadcrumb | mount | 2356 | 2378 | 1000 | |
| ButtonNext | mount | 543 | 538 | 5000 | |
| Checkbox | mount | 1426 | 1404 | 5000 | |
| CheckboxBase | mount | 1167 | 1218 | 5000 | |
| ChoiceGroup | mount | 4214 | 4233 | 5000 | |
| ComboBox | mount | 950 | 913 | 1000 | |
| CommandBar | mount | 9151 | 8860 | 1000 | |
| ContextualMenu | mount | 7316 | 7313 | 1000 | |
| DefaultButton | mount | 1064 | 1062 | 5000 | |
| DetailsRow | mount | 3320 | 3365 | 5000 | |
| DetailsRowFast | mount | 3334 | 3360 | 5000 | |
| DetailsRowNoStyles | mount | 3157 | 3203 | 5000 | |
| Dialog | mount | 2319 | 2295 | 1000 | |
| DocumentCardTitle | mount | 251 | 243 | 1000 | |
| Dropdown | mount | 2842 | 2815 | 5000 | |
| FluentProviderNext | mount | 3670 | 3673 | 5000 | |
| FluentProviderWithTheme | mount | 292 | 302 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 171 | 189 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 328 | 345 | 10 | |
| FocusTrapZone | mount | 1690 | 1653 | 5000 | |
| FocusZone | mount | 1683 | 1688 | 5000 | |
| IconButton | mount | 1614 | 1590 | 5000 | |
| Label | mount | 407 | 408 | 5000 | |
| Layer | mount | 2618 | 2613 | 5000 | |
| Link | mount | 504 | 522 | 5000 | |
| MakeStyles | mount | 1685 | 1691 | 50000 | |
| MenuButton | mount | 1353 | 1358 | 5000 | |
| MessageBar | mount | 1780 | 1814 | 5000 | |
| Nav | mount | 2896 | 2878 | 1000 | |
| OverflowSet | mount | 1044 | 1058 | 5000 | |
| Panel | mount | 2203 | 2270 | 1000 | |
| Persona | mount | 816 | 815 | 1000 | |
| Pivot | mount | 1312 | 1307 | 1000 | |
| PrimaryButton | mount | 1218 | 1206 | 5000 | |
| Rating | mount | 6614 | 6654 | 5000 | |
| SearchBox | mount | 1233 | 1238 | 5000 | |
| Shimmer | mount | 2310 | 2254 | 5000 | |
| Slider | mount | 1797 | 1803 | 5000 | |
| SpinButton | mount | 4362 | 4397 | 5000 | |
| Spinner | mount | 464 | 462 | 5000 | |
| SplitButton | mount | 2783 | 2792 | 5000 | |
| Stack | mount | 529 | 520 | 5000 | |
| StackWithIntrinsicChildren | mount | 1570 | 1570 | 5000 | |
| StackWithTextChildren | mount | 4032 | 4026 | 5000 | |
| SwatchColorPicker | mount | 9033 | 9101 | 5000 | |
| TagPicker | mount | 2303 | 2336 | 5000 | |
| TeachingBubble | mount | 11304 | 11259 | 5000 | |
| Text | mount | 453 | 471 | 5000 | |
| TextField | mount | 1252 | 1284 | 5000 | |
| ThemeProvider | mount | 1119 | 1103 | 5000 | |
| ThemeProvider | virtual-rerender | 632 | 632 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1702 | 1724 | 5000 | |
| Toggle | mount | 818 | 796 | 5000 | |
| buttonNative | mount | 225 | 208 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AvatarMinimalPerf.default | 182 | 162 | 1.12:1 |
| TreeWith60ListItems.default | 157 | 144 | 1.09:1 |
| AttachmentMinimalPerf.default | 139 | 129 | 1.08:1 |
| AccordionMinimalPerf.default | 135 | 126 | 1.07:1 |
| SegmentMinimalPerf.default | 308 | 289 | 1.07:1 |
| IconMinimalPerf.default | 512 | 479 | 1.07:1 |
| ListNestedPerf.default | 478 | 453 | 1.06:1 |
| ReactionMinimalPerf.default | 324 | 307 | 1.06:1 |
| TextAreaMinimalPerf.default | 427 | 406 | 1.05:1 |
| ChatDuplicateMessagesPerf.default | 269 | 259 | 1.04:1 |
| GridMinimalPerf.default | 296 | 285 | 1.04:1 |
| RefMinimalPerf.default | 217 | 208 | 1.04:1 |
| AlertMinimalPerf.default | 237 | 230 | 1.03:1 |
| BoxMinimalPerf.default | 304 | 296 | 1.03:1 |
| ButtonMinimalPerf.default | 152 | 147 | 1.03:1 |
| ImageMinimalPerf.default | 320 | 310 | 1.03:1 |
| MenuMinimalPerf.default | 725 | 707 | 1.03:1 |
| PopupMinimalPerf.default | 517 | 503 | 1.03:1 |
| PortalMinimalPerf.default | 157 | 152 | 1.03:1 |
| AnimationMinimalPerf.default | 368 | 361 | 1.02:1 |
| CarouselMinimalPerf.default | 402 | 394 | 1.02:1 |
| DividerMinimalPerf.default | 313 | 308 | 1.02:1 |
| ListMinimalPerf.default | 437 | 430 | 1.02:1 |
| LoaderMinimalPerf.default | 587 | 577 | 1.02:1 |
| ProviderMinimalPerf.default | 962 | 946 | 1.02:1 |
| ToolbarMinimalPerf.default | 791 | 778 | 1.02:1 |
| ButtonSlotsPerf.default | 470 | 466 | 1.01:1 |
| ChatMinimalPerf.default | 549 | 544 | 1.01:1 |
| CheckboxMinimalPerf.default | 2266 | 2246 | 1.01:1 |
| DatepickerMinimalPerf.default | 4753 | 4700 | 1.01:1 |
| DialogMinimalPerf.default | 649 | 641 | 1.01:1 |
| EmbedMinimalPerf.default | 3487 | 3462 | 1.01:1 |
| SplitButtonMinimalPerf.default | 3595 | 3575 | 1.01:1 |
| TextMinimalPerf.default | 302 | 299 | 1.01:1 |
| CustomToolbarPrototype.default | 3474 | 3443 | 1.01:1 |
| TooltipMinimalPerf.default | 873 | 867 | 1.01:1 |
| ButtonOverridesMissPerf.default | 1421 | 1425 | 1:1 |
| DropdownMinimalPerf.default | 2569 | 2575 | 1:1 |
| FlexMinimalPerf.default | 243 | 243 | 1:1 |
| FormMinimalPerf.default | 341 | 341 | 1:1 |
| HeaderSlotsPerf.default | 638 | 637 | 1:1 |
| InputMinimalPerf.default | 1090 | 1095 | 1:1 |
| LabelMinimalPerf.default | 326 | 325 | 1:1 |
| LayoutMinimalPerf.default | 312 | 312 | 1:1 |
| MenuButtonMinimalPerf.default | 1378 | 1373 | 1:1 |
| ProviderMergeThemesPerf.default | 1459 | 1462 | 1:1 |
| RadioGroupMinimalPerf.default | 377 | 378 | 1:1 |
| SliderMinimalPerf.default | 1415 | 1421 | 1:1 |
| TableMinimalPerf.default | 338 | 339 | 1:1 |
| TreeMinimalPerf.default | 676 | 673 | 1:1 |
| CardMinimalPerf.default | 464 | 467 | 0.99:1 |
| HeaderMinimalPerf.default | 299 | 303 | 0.99:1 |
| ListWith60ListItems.default | 544 | 549 | 0.99:1 |
| SkeletonMinimalPerf.default | 292 | 295 | 0.99:1 |
| TableManyItemsPerf.default | 1574 | 1590 | 0.99:1 |
| AttachmentSlotsPerf.default | 902 | 923 | 0.98:1 |
| DropdownManyItemsPerf.default | 574 | 585 | 0.98:1 |
| ItemLayoutMinimalPerf.default | 999 | 1019 | 0.98:1 |
| StatusMinimalPerf.default | 565 | 576 | 0.98:1 |
| ChatWithPopoverPerf.default | 321 | 330 | 0.97:1 |
| ListCommonPerf.default | 549 | 567 | 0.97:1 |
| RosterPerf.default | 990 | 1017 | 0.97:1 |
| VideoMinimalPerf.default | 526 | 540 | 0.97:1 |
ling1726
reviewed
Nov 26, 2021
ling1726
reviewed
Nov 26, 2021
Co-authored-by: ling1726 <lingfan.gao@microsoft.com>
ling1726
approved these changes
Nov 26, 2021
mlp73
pushed a commit
to mlp73/fluentui
that referenced
this pull request
Jan 17, 2022
…es (microsoft#20791) * chore(react-portal): update stories to not use CSS shorthands in styles * Apply suggestions from code review Co-authored-by: ling1726 <lingfan.gao@microsoft.com> Co-authored-by: ling1726 <lingfan.gao@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
makeStyles()calls #20573$ yarn changeDescription of changes
This PR updates stories to not use CSS shorthands. Also removes
codesandbox-dependencycomments.