Skip to content

fix(react-card): update styles to not use CSS shorthands#20794

Merged
layershifter merged 1 commit into
masterfrom
fix/shorthands-card
Nov 26, 2021
Merged

fix(react-card): update styles to not use CSS shorthands#20794
layershifter merged 1 commit into
masterfrom
fix/shorthands-card

Conversation

@layershifter

Copy link
Copy Markdown
Member

Pull request checklist

Description of changes

This PR updates styles to not use CSS shorthands.

@fabricteam

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

🤖 This report was generated against bd3e92b5193176665879abd667db4350ffcc35ea

@size-auditor

size-auditor Bot commented Nov 26, 2021

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: bd3e92b5193176665879abd667db4350ffcc35ea (build)

@codesandbox-ci

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 37c6234:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react)

Scenario Render type Master Ticks PR Ticks Iterations Status
Panel mount 2213 4706 1000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 873 866 5000
BaseButton mount 881 906 5000
Breadcrumb mount 2387 2420 1000
ButtonNext mount 541 538 5000
Checkbox mount 1426 1400 5000
CheckboxBase mount 1219 1207 5000
ChoiceGroup mount 4178 4178 5000
ComboBox mount 976 967 1000
CommandBar mount 8899 8930 1000
ContextualMenu mount 7334 7365 1000
DefaultButton mount 1079 1066 5000
DetailsRow mount 3372 3269 5000
DetailsRowFast mount 3379 3381 5000
DetailsRowNoStyles mount 3189 3234 5000
Dialog mount 2283 2306 1000
DocumentCardTitle mount 263 254 1000
Dropdown mount 2857 2863 5000
FluentProviderNext mount 3678 3672 5000
FluentProviderWithTheme mount 308 300 10
FluentProviderWithTheme virtual-rerender 181 174 10
FluentProviderWithTheme virtual-rerender-with-unmount 316 338 10
FocusTrapZone mount 1642 1684 5000
FocusZone mount 1733 1716 5000
IconButton mount 1620 1617 5000
Label mount 417 426 5000
Layer mount 2610 2670 5000
Link mount 503 519 5000
MakeStyles mount 1685 1727 50000
MenuButton mount 1375 1387 5000
MessageBar mount 1828 1795 5000
Nav mount 2943 2895 1000
OverflowSet mount 1059 1057 5000
Panel mount 2213 4706 1000 Possible regression
Persona mount 820 829 1000
Pivot mount 1351 1348 1000
PrimaryButton mount 1206 1213 5000
Rating mount 6681 6692 5000
SearchBox mount 1231 1244 5000
Shimmer mount 2301 2255 5000
Slider mount 1790 1765 5000
SpinButton mount 4395 4383 5000
Spinner mount 472 461 5000
SplitButton mount 2807 2833 5000
Stack mount 532 567 5000
StackWithIntrinsicChildren mount 1551 1579 5000
StackWithTextChildren mount 4056 4078 5000
SwatchColorPicker mount 8940 9074 5000
TagPicker mount 2345 2334 5000
TeachingBubble mount 11310 11263 5000
Text mount 455 478 5000
TextField mount 1282 1269 5000
ThemeProvider mount 1128 1100 5000
ThemeProvider virtual-rerender 616 647 5000
ThemeProvider virtual-rerender-with-unmount 1687 1669 5000
Toggle mount 809 789 5000
buttonNative mount 207 222 5000

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
AlertMinimalPerf.default 227 239 0.95:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
FormMinimalPerf.default 353 331 1.07:1
AvatarMinimalPerf.default 177 169 1.05:1
ChatDuplicateMessagesPerf.default 274 262 1.05:1
MenuMinimalPerf.default 749 711 1.05:1
AccordionMinimalPerf.default 138 133 1.04:1
ChatWithPopoverPerf.default 334 322 1.04:1
DividerMinimalPerf.default 318 305 1.04:1
FlexMinimalPerf.default 258 249 1.04:1
RadioGroupMinimalPerf.default 383 369 1.04:1
ButtonMinimalPerf.default 151 147 1.03:1
HeaderMinimalPerf.default 311 303 1.03:1
HeaderSlotsPerf.default 650 633 1.03:1
ImageMinimalPerf.default 326 317 1.03:1
ListNestedPerf.default 481 469 1.03:1
ReactionMinimalPerf.default 323 315 1.03:1
SegmentMinimalPerf.default 299 291 1.03:1
StatusMinimalPerf.default 563 544 1.03:1
AnimationMinimalPerf.default 369 360 1.02:1
BoxMinimalPerf.default 299 293 1.02:1
CardMinimalPerf.default 485 474 1.02:1
CarouselMinimalPerf.default 410 402 1.02:1
ChatMinimalPerf.default 569 557 1.02:1
DialogMinimalPerf.default 655 643 1.02:1
LayoutMinimalPerf.default 316 311 1.02:1
PopupMinimalPerf.default 514 505 1.02:1
RefMinimalPerf.default 208 203 1.02:1
TableMinimalPerf.default 347 340 1.02:1
TextMinimalPerf.default 298 291 1.02:1
TextAreaMinimalPerf.default 428 419 1.02:1
ButtonOverridesMissPerf.default 1440 1425 1.01:1
ButtonSlotsPerf.default 473 469 1.01:1
CheckboxMinimalPerf.default 2295 2263 1.01:1
DropdownManyItemsPerf.default 579 574 1.01:1
DropdownMinimalPerf.default 2584 2546 1.01:1
GridMinimalPerf.default 292 289 1.01:1
MenuButtonMinimalPerf.default 1387 1369 1.01:1
PortalMinimalPerf.default 151 150 1.01:1
SkeletonMinimalPerf.default 300 298 1.01:1
SplitButtonMinimalPerf.default 3655 3605 1.01:1
CustomToolbarPrototype.default 3515 3488 1.01:1
TooltipMinimalPerf.default 880 867 1.01:1
TreeMinimalPerf.default 694 686 1.01:1
TreeWith60ListItems.default 162 161 1.01:1
VideoMinimalPerf.default 545 540 1.01:1
DatepickerMinimalPerf.default 4829 4832 1:1
EmbedMinimalPerf.default 3513 3503 1:1
InputMinimalPerf.default 1098 1098 1:1
LabelMinimalPerf.default 324 324 1:1
ListMinimalPerf.default 437 439 1:1
ProviderMergeThemesPerf.default 1482 1475 1:1
ProviderMinimalPerf.default 967 967 1:1
TableManyItemsPerf.default 1584 1583 1:1
ItemLayoutMinimalPerf.default 1019 1027 0.99:1
ListWith60ListItems.default 561 564 0.99:1
LoaderMinimalPerf.default 580 587 0.99:1
ToolbarMinimalPerf.default 802 811 0.99:1
SliderMinimalPerf.default 1413 1449 0.98:1
IconMinimalPerf.default 529 538 0.98:1
AttachmentSlotsPerf.default 890 924 0.96:1
ListCommonPerf.default 527 552 0.95:1
RosterPerf.default 980 1029 0.95:1
AttachmentMinimalPerf.default 128 138 0.93:1

@theerebuss
theerebuss self-requested a review November 26, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants