chore(react-components): update stories to not use CSS shorthands in styles#20798
Merged
Conversation
layershifter
changed the title
layershifter
commented
Nov 26, 2021
| import { Button } from '@fluentui/react-button'; | ||
| import { PositioningShorthand } from '@fluentui/react-positioning'; | ||
|
|
||
| const useExampleStyles = makeStyles({ |
Member
Author
There was a problem hiding this comment.
It was just moved from bottom to be consistent with other usages
Collaborator
📊 Bundle size report🤖 This report was generated against bd3e92b5193176665879abd667db4350ffcc35ea |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 31ab44d:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: bd3e92b5193176665879abd667db4350ffcc35ea (build) |
ling1726
approved these changes
Nov 26, 2021
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| MessageBar | mount | 3941 | 1788 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 866 | 891 | 5000 | |
| BaseButton | mount | 879 | 901 | 5000 | |
| Breadcrumb | mount | 2407 | 2371 | 1000 | |
| ButtonNext | mount | 537 | 529 | 5000 | |
| Checkbox | mount | 1424 | 1398 | 5000 | |
| CheckboxBase | mount | 1172 | 1167 | 5000 | |
| ChoiceGroup | mount | 4141 | 4166 | 5000 | |
| ComboBox | mount | 933 | 937 | 1000 | |
| CommandBar | mount | 8779 | 8786 | 1000 | |
| ContextualMenu | mount | 7237 | 7290 | 1000 | |
| DefaultButton | mount | 1056 | 1085 | 5000 | |
| DetailsRow | mount | 3399 | 3305 | 5000 | |
| DetailsRowFast | mount | 3305 | 3327 | 5000 | |
| DetailsRowNoStyles | mount | 3302 | 3227 | 5000 | |
| Dialog | mount | 2281 | 2301 | 1000 | |
| DocumentCardTitle | mount | 226 | 241 | 1000 | |
| Dropdown | mount | 2828 | 2848 | 5000 | |
| FluentProviderNext | mount | 3667 | 3635 | 5000 | |
| FluentProviderWithTheme | mount | 301 | 289 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 186 | 190 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 318 | 327 | 10 | |
| FocusTrapZone | mount | 1670 | 1620 | 5000 | |
| FocusZone | mount | 1672 | 1645 | 5000 | |
| IconButton | mount | 1578 | 1611 | 5000 | |
| Label | mount | 406 | 411 | 5000 | |
| Layer | mount | 2590 | 2623 | 5000 | |
| Link | mount | 1166 | 503 | 5000 | |
| MakeStyles | mount | 3310 | 5176 | 50000 | |
| MenuButton | mount | 2432 | 3252 | 5000 | |
| MessageBar | mount | 3941 | 1788 | 5000 | Possible regression |
| Nav | mount | 2915 | 2934 | 1000 | |
| OverflowSet | mount | 1065 | 1059 | 5000 | |
| Panel | mount | 2591 | 2768 | 1000 | |
| Persona | mount | 2483 | 806 | 1000 | |
| Pivot | mount | 1562 | 3962 | 1000 | |
| PrimaryButton | mount | 1203 | 1200 | 5000 | |
| Rating | mount | 7145 | 6693 | 5000 | |
| SearchBox | mount | 1241 | 1215 | 5000 | |
| Shimmer | mount | 2256 | 2294 | 5000 | |
| Slider | mount | 1752 | 1772 | 5000 | |
| SpinButton | mount | 7781 | 4765 | 5000 | |
| Spinner | mount | 1465 | 1200 | 5000 | |
| SplitButton | mount | 3167 | 2788 | 5000 | |
| Stack | mount | 557 | 530 | 5000 | |
| StackWithIntrinsicChildren | mount | 1572 | 1568 | 5000 | |
| StackWithTextChildren | mount | 4068 | 4049 | 5000 | |
| SwatchColorPicker | mount | 8989 | 9019 | 5000 | |
| TagPicker | mount | 2342 | 2319 | 5000 | |
| TeachingBubble | mount | 11305 | 11289 | 5000 | |
| Text | mount | 457 | 457 | 5000 | |
| TextField | mount | 1279 | 1267 | 5000 | |
| ThemeProvider | mount | 1109 | 1121 | 5000 | |
| ThemeProvider | virtual-rerender | 622 | 634 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1656 | 1706 | 5000 | |
| Toggle | mount | 781 | 801 | 5000 | |
| buttonNative | mount | 214 | 210 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| PortalMinimalPerf.default | 161 | 148 | 1.09:1 |
| RefMinimalPerf.default | 216 | 201 | 1.07:1 |
| DividerMinimalPerf.default | 326 | 308 | 1.06:1 |
| ImageMinimalPerf.default | 330 | 310 | 1.06:1 |
| TableMinimalPerf.default | 347 | 328 | 1.06:1 |
| AccordionMinimalPerf.default | 137 | 131 | 1.05:1 |
| ButtonMinimalPerf.default | 152 | 145 | 1.05:1 |
| LayoutMinimalPerf.default | 318 | 302 | 1.05:1 |
| IconMinimalPerf.default | 521 | 495 | 1.05:1 |
| BoxMinimalPerf.default | 300 | 289 | 1.04:1 |
| FormMinimalPerf.default | 352 | 338 | 1.04:1 |
| RadioGroupMinimalPerf.default | 379 | 365 | 1.04:1 |
| AnimationMinimalPerf.default | 368 | 359 | 1.03:1 |
| AvatarMinimalPerf.default | 168 | 163 | 1.03:1 |
| ChatMinimalPerf.default | 558 | 543 | 1.03:1 |
| LabelMinimalPerf.default | 335 | 325 | 1.03:1 |
| ReactionMinimalPerf.default | 321 | 312 | 1.03:1 |
| TreeMinimalPerf.default | 681 | 663 | 1.03:1 |
| AttachmentMinimalPerf.default | 132 | 129 | 1.02:1 |
| DialogMinimalPerf.default | 648 | 634 | 1.02:1 |
| ItemLayoutMinimalPerf.default | 1006 | 988 | 1.02:1 |
| ListCommonPerf.default | 536 | 524 | 1.02:1 |
| ListNestedPerf.default | 470 | 461 | 1.02:1 |
| ToolbarMinimalPerf.default | 805 | 786 | 1.02:1 |
| AlertMinimalPerf.default | 230 | 227 | 1.01:1 |
| AttachmentSlotsPerf.default | 905 | 895 | 1.01:1 |
| ButtonOverridesMissPerf.default | 1431 | 1414 | 1.01:1 |
| CheckboxMinimalPerf.default | 2267 | 2249 | 1.01:1 |
| DropdownMinimalPerf.default | 2557 | 2536 | 1.01:1 |
| TableManyItemsPerf.default | 1600 | 1588 | 1.01:1 |
| TextMinimalPerf.default | 291 | 288 | 1.01:1 |
| TooltipMinimalPerf.default | 872 | 860 | 1.01:1 |
| ButtonSlotsPerf.default | 467 | 465 | 1:1 |
| CardMinimalPerf.default | 462 | 460 | 1:1 |
| CarouselMinimalPerf.default | 406 | 406 | 1:1 |
| DropdownManyItemsPerf.default | 571 | 573 | 1:1 |
| FlexMinimalPerf.default | 250 | 251 | 1:1 |
| HeaderSlotsPerf.default | 629 | 631 | 1:1 |
| InputMinimalPerf.default | 1090 | 1092 | 1:1 |
| ListMinimalPerf.default | 433 | 434 | 1:1 |
| MenuButtonMinimalPerf.default | 1371 | 1371 | 1:1 |
| PopupMinimalPerf.default | 500 | 501 | 1:1 |
| ProviderMergeThemesPerf.default | 1458 | 1457 | 1:1 |
| ProviderMinimalPerf.default | 951 | 950 | 1:1 |
| SkeletonMinimalPerf.default | 302 | 301 | 1:1 |
| SliderMinimalPerf.default | 1428 | 1423 | 1:1 |
| SplitButtonMinimalPerf.default | 3601 | 3589 | 1:1 |
| TextAreaMinimalPerf.default | 416 | 415 | 1:1 |
| DatepickerMinimalPerf.default | 4629 | 4667 | 0.99:1 |
| EmbedMinimalPerf.default | 3471 | 3490 | 0.99:1 |
| GridMinimalPerf.default | 285 | 287 | 0.99:1 |
| ListWith60ListItems.default | 547 | 551 | 0.99:1 |
| StatusMinimalPerf.default | 562 | 568 | 0.99:1 |
| CustomToolbarPrototype.default | 3428 | 3464 | 0.99:1 |
| ChatDuplicateMessagesPerf.default | 254 | 259 | 0.98:1 |
| HeaderMinimalPerf.default | 302 | 307 | 0.98:1 |
| MenuMinimalPerf.default | 705 | 717 | 0.98:1 |
| LoaderMinimalPerf.default | 566 | 581 | 0.97:1 |
| RosterPerf.default | 963 | 995 | 0.97:1 |
| SegmentMinimalPerf.default | 286 | 295 | 0.97:1 |
| TreeWith60ListItems.default | 154 | 159 | 0.97:1 |
| ChatWithPopoverPerf.default | 303 | 329 | 0.92:1 |
| VideoMinimalPerf.default | 506 | 548 | 0.92:1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
makeStyles()calls #20573$ yarn changeDescription of changes
This PR updates stories to not use CSS shorthands.