Skip to content

fix(react-avatar): update styles to not use CSS shorthands #20801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
layershifter merged 2 commits into from
Nov 30, 2021
Merged

fix(react-avatar): update styles to not use CSS shorthands #20801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52542ee
fix(react-avatar): update stories to not use CSS shorthands in styles
layershifter Nov 8, 2021
5671365
Update change/@fluentui-react-avatar-8bb1e8aa-bfd9-4c42-aa44-390bae8c…
layershifter Nov 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-avatar-8bb1e8aa-bfd9-4c42-aa44-390bae8c5d03.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "update styles to not use CSS shorthands",
"packageName": "@fluentui/react-avatar",
"email": "olfedias@microsoft.com",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion packages/react-avatar/src/AvatarActive.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from 'react';
import { Avatar, AvatarProps } from './index'; // codesandbox-dependency: @fluentui/react-components ^9.0.0-beta
import { Avatar, AvatarProps } from './index';

export const Active = (props: Partial<AvatarProps>) => (
<div style={{ display: 'flex', gap: '32px' }}>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-avatar/src/AvatarActiveAppearance.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from 'react';
import { Avatar, AvatarProps } from './index'; // codesandbox-dependency: @fluentui/react-components ^9.0.0-beta
import { Avatar, AvatarProps } from './index';

export const ActiveAppearance = (props: Partial<AvatarProps>) => (
<div style={{ display: 'flex', gap: '32px' }}>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-avatar/src/AvatarBadge.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from 'react';
import { Avatar, AvatarProps } from './index'; // codesandbox-dependency: @fluentui/react-components ^9.0.0-beta
import { Avatar, AvatarProps } from './index';

export const Badge = (props: Partial<AvatarProps>) => (
<>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-avatar/src/AvatarColor.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from 'react';
import { Avatar, AvatarProps } from './index'; // codesandbox-dependency: @fluentui/react-components ^9.0.0-beta
import { Avatar, AvatarProps } from './index';

export const Color = (props: Partial<AvatarProps>) => (
<>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-avatar/src/AvatarColorBrand.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from 'react';
import { Avatar, AvatarProps } from './index'; // codesandbox-dependency: @fluentui/react-components ^9.0.0-beta
import { Avatar, AvatarProps } from './index';

export const ColorBrand = (props: Partial<AvatarProps>) => <Avatar {...props} color="brand" />;

Expand Down
2 changes: 1 addition & 1 deletion packages/react-avatar/src/AvatarColorColorful.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from 'react';
import { Avatar, AvatarProps } from './index'; // codesandbox-dependency: @fluentui/react-components ^9.0.0-beta
import { Avatar, AvatarProps } from './index';

export const ColorColorful = (props: Partial<AvatarProps>) => (
<>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-avatar/src/AvatarColorNeutral.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from 'react';
import { Avatar, AvatarProps } from './index'; // codesandbox-dependency: @fluentui/react-components ^9.0.0-beta
import { Avatar, AvatarProps } from './index';

export const ColorNeutral = (props: Partial<AvatarProps>) => <Avatar color="neutral" />;

Expand Down
2 changes: 1 addition & 1 deletion packages/react-avatar/src/AvatarDefault.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import * as React from 'react';
import { Avatar, AvatarProps } from './index'; // codesandbox-dependency: @fluentui/react-components ^9.0.0-beta
import { Avatar, AvatarProps } from './index';

export const Default = (props: Partial<AvatarProps>) => <Avatar {...props} />;
2 changes: 1 addition & 1 deletion packages/react-avatar/src/AvatarGetInitials.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from 'react';
import { Avatar, AvatarProps } from './index'; // codesandbox-dependency: @fluentui/react-components ^9.0.0-beta
import { Avatar, AvatarProps } from './index';

const formatter = (name: string, isRTL: boolean) => {
return `${name[0]} ${name[name.length - 1]}`;
Expand Down
3 changes: 2 additions & 1 deletion packages/react-avatar/src/AvatarIcon.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import * as React from 'react';
import { Avatar, AvatarProps } from './index'; // codesandbox-dependency: @fluentui/react-components ^9.0.0-beta
import { Guest20Regular } from '@fluentui/react-icons';

import { Avatar, AvatarProps } from './index';

export const Icon = (props: Partial<AvatarProps>) => {
return <Avatar {...props} icon={<Guest20Regular />} />;
};
Expand Down
2 changes: 1 addition & 1 deletion packages/react-avatar/src/AvatarIdForColor.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from 'react';
import { Avatar, AvatarProps } from './index'; // codesandbox-dependency: @fluentui/react-components ^9.0.0-beta
import { Avatar, AvatarProps } from './index';

export const IdForColor = (props: Partial<AvatarProps>) => (
<>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-avatar/src/AvatarImage.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from 'react';
import { Avatar, AvatarProps } from './index'; // codesandbox-dependency: @fluentui/react-components ^9.0.0-beta
import { Avatar, AvatarProps } from './index';

export const Image = (props: Partial<AvatarProps>) => (
<Avatar
Expand Down
2 changes: 1 addition & 1 deletion packages/react-avatar/src/AvatarName.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from 'react';
import { Avatar, AvatarProps } from './index'; // codesandbox-dependency: @fluentui/react-components ^9.0.0-beta
import { Avatar, AvatarProps } from './index';

export const Name = (props: Partial<AvatarProps>) => <Avatar {...props} name="Katri Athokas" />;

Expand Down
2 changes: 1 addition & 1 deletion packages/react-avatar/src/AvatarShape.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from 'react';
import { Avatar, AvatarProps } from './index'; // codesandbox-dependency: @fluentui/react-components ^9.0.0-beta
import { Avatar, AvatarProps } from './index';

export const Shape = (props: Partial<AvatarProps>) => (
<>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-avatar/src/AvatarSize.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from 'react';
import { Avatar, AvatarProps } from './index'; // codesandbox-dependency: @fluentui/react-components ^9.0.0-beta
import { Avatar, AvatarProps } from './index';

export const Size = (props: Partial<AvatarProps>) => (
<>
Expand Down
Loading