fix(react-slider): update styles to not use CSS shorthands#20823
Closed
layershifter wants to merge 0 commit into
Closed
fix(react-slider): update styles to not use CSS shorthands#20823layershifter wants to merge 0 commit into
layershifter wants to merge 0 commit into
Conversation
layershifter
requested review from
a team,
behowell,
czearing,
ecraig12345 and
khmakoto
as code owners
November 29, 2021 09:39
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c6c745b:
|
Collaborator
📊 Bundle size report🤖 This report was generated against a76afe26daad901ff5458ffdda7e66e600d5bcac |
Asset size changesUnable to find bundle size details for Baseline commit: cfb9eea Possible causes
Recommendations
|
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 891 | 882 | 5000 | |
| BaseButton | mount | 909 | 903 | 5000 | |
| Breadcrumb | mount | 2442 | 2433 | 1000 | |
| ButtonNext | mount | 567 | 545 | 5000 | |
| Checkbox | mount | 1413 | 1400 | 5000 | |
| CheckboxBase | mount | 1214 | 1206 | 5000 | |
| ChoiceGroup | mount | 4187 | 4188 | 5000 | |
| ComboBox | mount | 921 | 928 | 1000 | |
| CommandBar | mount | 8842 | 8832 | 1000 | |
| ContextualMenu | mount | 7361 | 7334 | 1000 | |
| DefaultButton | mount | 1078 | 1083 | 5000 | |
| DetailsRow | mount | 3355 | 3339 | 5000 | |
| DetailsRowFast | mount | 3330 | 3375 | 5000 | |
| DetailsRowNoStyles | mount | 3218 | 3211 | 5000 | |
| Dialog | mount | 2295 | 2320 | 1000 | |
| DocumentCardTitle | mount | 233 | 253 | 1000 | |
| Dropdown | mount | 2818 | 2884 | 5000 | |
| FluentProviderNext | mount | 3664 | 3687 | 5000 | |
| FluentProviderWithTheme | mount | 287 | 311 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 178 | 200 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 335 | 337 | 10 | |
| FocusTrapZone | mount | 1656 | 1669 | 5000 | |
| FocusZone | mount | 1764 | 1699 | 5000 | |
| IconButton | mount | 1592 | 1600 | 5000 | |
| Label | mount | 404 | 407 | 5000 | |
| Layer | mount | 2652 | 2634 | 5000 | |
| Link | mount | 518 | 515 | 5000 | |
| MakeStyles | mount | 1670 | 1706 | 50000 | |
| MenuButton | mount | 1368 | 1354 | 5000 | |
| MessageBar | mount | 1806 | 1800 | 5000 | |
| Nav | mount | 2936 | 2916 | 1000 | |
| OverflowSet | mount | 1044 | 1054 | 5000 | |
| Panel | mount | 2193 | 2227 | 1000 | |
| Persona | mount | 829 | 826 | 1000 | |
| Pivot | mount | 1320 | 1328 | 1000 | |
| PrimaryButton | mount | 1217 | 1197 | 5000 | |
| Rating | mount | 6613 | 6665 | 5000 | |
| SearchBox | mount | 1234 | 1222 | 5000 | |
| Shimmer | mount | 2318 | 2264 | 5000 | |
| Slider | mount | 1775 | 1765 | 5000 | |
| SpinButton | mount | 4402 | 4388 | 5000 | |
| Spinner | mount | 477 | 467 | 5000 | |
| SplitButton | mount | 2792 | 2843 | 5000 | |
| Stack | mount | 549 | 548 | 5000 | |
| StackWithIntrinsicChildren | mount | 1568 | 1559 | 5000 | |
| StackWithTextChildren | mount | 4068 | 4062 | 5000 | |
| SwatchColorPicker | mount | 9047 | 9159 | 5000 | |
| TagPicker | mount | 2402 | 2368 | 5000 | |
| TeachingBubble | mount | 11392 | 11413 | 5000 | |
| Text | mount | 480 | 480 | 5000 | |
| TextField | mount | 1316 | 1281 | 5000 | |
| ThemeProvider | mount | 1113 | 1118 | 5000 | |
| ThemeProvider | virtual-rerender | 634 | 638 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1697 | 1714 | 5000 | |
| Toggle | mount | 806 | 786 | 5000 | |
| buttonNative | mount | 223 | 219 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Potential regressions comparing to master
| Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
|---|---|---|---|---|
| MenuButtonMinimalPerf.default | 1385 | 1378 | 1.01:1 | analysis |
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ChatWithPopoverPerf.default | 330 | 300 | 1.1:1 |
| StatusMinimalPerf.default | 598 | 552 | 1.08:1 |
| ReactionMinimalPerf.default | 331 | 308 | 1.07:1 |
| BoxMinimalPerf.default | 299 | 283 | 1.06:1 |
| ImageMinimalPerf.default | 330 | 311 | 1.06:1 |
| PortalMinimalPerf.default | 162 | 153 | 1.06:1 |
| RefMinimalPerf.default | 217 | 204 | 1.06:1 |
| TreeWith60ListItems.default | 166 | 157 | 1.06:1 |
| ListCommonPerf.default | 558 | 532 | 1.05:1 |
| IconMinimalPerf.default | 534 | 507 | 1.05:1 |
| AttachmentMinimalPerf.default | 137 | 132 | 1.04:1 |
| ChatDuplicateMessagesPerf.default | 252 | 242 | 1.04:1 |
| HeaderMinimalPerf.default | 315 | 304 | 1.04:1 |
| LabelMinimalPerf.default | 336 | 323 | 1.04:1 |
| SkeletonMinimalPerf.default | 308 | 297 | 1.04:1 |
| TextAreaMinimalPerf.default | 429 | 413 | 1.04:1 |
| TreeMinimalPerf.default | 686 | 661 | 1.04:1 |
| CardMinimalPerf.default | 470 | 457 | 1.03:1 |
| GridMinimalPerf.default | 296 | 288 | 1.03:1 |
| LoaderMinimalPerf.default | 587 | 569 | 1.03:1 |
| SegmentMinimalPerf.default | 296 | 286 | 1.03:1 |
| SliderMinimalPerf.default | 1451 | 1415 | 1.03:1 |
| VideoMinimalPerf.default | 550 | 533 | 1.03:1 |
| ButtonOverridesMissPerf.default | 1454 | 1422 | 1.02:1 |
| ChatMinimalPerf.default | 570 | 560 | 1.02:1 |
| DatepickerMinimalPerf.default | 4706 | 4623 | 1.02:1 |
| DialogMinimalPerf.default | 654 | 640 | 1.02:1 |
| FlexMinimalPerf.default | 252 | 246 | 1.02:1 |
| FormMinimalPerf.default | 340 | 332 | 1.02:1 |
| InputMinimalPerf.default | 1095 | 1077 | 1.02:1 |
| TableManyItemsPerf.default | 1609 | 1585 | 1.02:1 |
| ToolbarMinimalPerf.default | 805 | 787 | 1.02:1 |
| TooltipMinimalPerf.default | 879 | 866 | 1.02:1 |
| AccordionMinimalPerf.default | 132 | 131 | 1.01:1 |
| AlertMinimalPerf.default | 236 | 234 | 1.01:1 |
| AnimationMinimalPerf.default | 370 | 365 | 1.01:1 |
| DropdownManyItemsPerf.default | 582 | 574 | 1.01:1 |
| EmbedMinimalPerf.default | 3511 | 3478 | 1.01:1 |
| PopupMinimalPerf.default | 506 | 501 | 1.01:1 |
| SplitButtonMinimalPerf.default | 3613 | 3581 | 1.01:1 |
| TextMinimalPerf.default | 299 | 295 | 1.01:1 |
| AttachmentSlotsPerf.default | 905 | 909 | 1:1 |
| ButtonMinimalPerf.default | 149 | 149 | 1:1 |
| DividerMinimalPerf.default | 313 | 314 | 1:1 |
| ItemLayoutMinimalPerf.default | 1015 | 1014 | 1:1 |
| ListMinimalPerf.default | 445 | 447 | 1:1 |
| ListNestedPerf.default | 467 | 468 | 1:1 |
| ListWith60ListItems.default | 541 | 541 | 1:1 |
| ProviderMergeThemesPerf.default | 1459 | 1456 | 1:1 |
| RadioGroupMinimalPerf.default | 372 | 371 | 1:1 |
| TableMinimalPerf.default | 343 | 342 | 1:1 |
| CustomToolbarPrototype.default | 3463 | 3456 | 1:1 |
| ButtonSlotsPerf.default | 452 | 455 | 0.99:1 |
| CheckboxMinimalPerf.default | 2257 | 2274 | 0.99:1 |
| DropdownMinimalPerf.default | 2556 | 2589 | 0.99:1 |
| HeaderSlotsPerf.default | 632 | 639 | 0.99:1 |
| LayoutMinimalPerf.default | 306 | 310 | 0.99:1 |
| MenuMinimalPerf.default | 716 | 722 | 0.99:1 |
| ProviderMinimalPerf.default | 953 | 966 | 0.99:1 |
| CarouselMinimalPerf.default | 393 | 400 | 0.98:1 |
| AvatarMinimalPerf.default | 163 | 169 | 0.96:1 |
| RosterPerf.default | 966 | 1010 | 0.96:1 |
Member
|
This will cause a lot of conflicts with @micahgodbolt's Slider refactor #20657 where he's rewriting most of the CSS. It might be better to just close this PR and let Micah make the appropriate changes in his PR. |
layershifter
force-pushed
the
fix/shorthands-slider
branch
from
December 6, 2021 14:47
d80e34e to
c6c745b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
makeStyles()calls #20573$ yarn changeDescription of changes
This PR updates styles to not use CSS shorthands.
Blocked, requires #20657.