SpinButton implementation and styles#22233
Merged
spmonahan merged 10 commits intoApr 5, 2022
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8a00e50:
|
Collaborator
📊 Bundle size report🤖 This report was generated against c77cf524675779b63cf18c193b8c496ad172d530 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: c77cf524675779b63cf18c193b8c496ad172d530 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 877 | 924 | 5000 | |
| Button | mount | 539 | 529 | 5000 | |
| FluentProvider | mount | 1902 | 1818 | 5000 | |
| FluentProviderWithTheme | mount | 257 | 218 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 214 | 225 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 318 | 301 | 10 | |
| MakeStyles | mount | 1554 | 1493 | 50000 |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
spmonahan
force-pushed
the
spin-button/implementation
branch
2 times, most recently
from
March 29, 2022 20:46
29180c4 to
dfa9e33
Compare
tomi-msft
reviewed
Mar 31, 2022
spmonahan
changed the title
smhigley
reviewed
Apr 4, 2022
smhigley
left a comment
smhigley
left a comment
Contributor
There was a problem hiding this comment.
A few suggestions, but the only one I'm really tied to is handling enter to commit
Rework the class name for active buttons to be simpler.
clampWhenInRange() now handles the case when the min value is greater than the max value. In this case the new value is simply returned with no clamping applied. In dev mode an error is written to the console as this is an invalid state. Tests have been added to verify the behavior.
Adds support for the Enter key to SpinButton. When focused on the text input field hitting the enter key will now commit the value.
Size prop was being passed down to the input slot. This was a left over from attempting to use `Input` rather than `input` for this slot. It is no longer needed.
spmonahan
force-pushed
the
spin-button/implementation
branch
from
April 4, 2022 21:05
eaa0882 to
8a00e50
Compare
smhigley
approved these changes
Apr 4, 2022
tomi-msft
approved these changes
Apr 5, 2022
raghavthind2005
approved these changes
Apr 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converged SpinButton Implementation
This pull request is the first pass implementation of SpinButton. There is still design work on-going, particularly around the different appearances but the functionality is well-defined and the code in this PR represents a fully working SpinButton. Since I have a working SpinButton I want to get it up for review now. Follow PRs will be made to address missing pieces.
This PR includes:
This PR does not include:
Relates to #20930