Repo maintenance: update a11y issue template, and add a11y test to convergence checklist#22363
Merged
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 25b6c01:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 9b558cf266817f6499fece14e71bd90e98385a6b (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1087 | 1071 | 5000 | |
| Button | mount | 639 | 651 | 5000 | |
| FluentProvider | mount | 2113 | 2088 | 5000 | |
| FluentProviderWithTheme | mount | 310 | 313 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 298 | 302 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 347 | 372 | 10 | |
| MakeStyles | mount | 1868 | 1843 | 50000 |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AvatarMinimalPerf.default | 163 | 153 | 1.07:1 |
| DividerMinimalPerf.default | 302 | 283 | 1.07:1 |
| ListCommonPerf.default | 539 | 503 | 1.07:1 |
| FlexMinimalPerf.default | 240 | 226 | 1.06:1 |
| ReactionMinimalPerf.default | 313 | 294 | 1.06:1 |
| TreeWith60ListItems.default | 146 | 138 | 1.06:1 |
| RadioGroupMinimalPerf.default | 377 | 360 | 1.05:1 |
| DropdownMinimalPerf.default | 2553 | 2444 | 1.04:1 |
| GridMinimalPerf.default | 283 | 271 | 1.04:1 |
| AttachmentMinimalPerf.default | 125 | 121 | 1.03:1 |
| BoxMinimalPerf.default | 286 | 277 | 1.03:1 |
| HeaderMinimalPerf.default | 297 | 289 | 1.03:1 |
| MenuButtonMinimalPerf.default | 1428 | 1384 | 1.03:1 |
| PortalMinimalPerf.default | 145 | 141 | 1.03:1 |
| SkeletonMinimalPerf.default | 287 | 278 | 1.03:1 |
| TextAreaMinimalPerf.default | 407 | 396 | 1.03:1 |
| ButtonMinimalPerf.default | 133 | 130 | 1.02:1 |
| CarouselMinimalPerf.default | 395 | 387 | 1.02:1 |
| DropdownManyItemsPerf.default | 577 | 568 | 1.02:1 |
| FormMinimalPerf.default | 333 | 328 | 1.02:1 |
| HeaderSlotsPerf.default | 632 | 620 | 1.02:1 |
| InputMinimalPerf.default | 1084 | 1066 | 1.02:1 |
| LabelMinimalPerf.default | 316 | 309 | 1.02:1 |
| LoaderMinimalPerf.default | 575 | 565 | 1.02:1 |
| RefMinimalPerf.default | 198 | 195 | 1.02:1 |
| SliderMinimalPerf.default | 1418 | 1395 | 1.02:1 |
| IconMinimalPerf.default | 507 | 497 | 1.02:1 |
| TableMinimalPerf.default | 332 | 326 | 1.02:1 |
| TextMinimalPerf.default | 282 | 277 | 1.02:1 |
| ToolbarMinimalPerf.default | 791 | 777 | 1.02:1 |
| VideoMinimalPerf.default | 534 | 523 | 1.02:1 |
| AlertMinimalPerf.default | 230 | 227 | 1.01:1 |
| AnimationMinimalPerf.default | 459 | 455 | 1.01:1 |
| ButtonOverridesMissPerf.default | 1247 | 1238 | 1.01:1 |
| ChatMinimalPerf.default | 618 | 612 | 1.01:1 |
| DialogMinimalPerf.default | 639 | 633 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 983 | 977 | 1.01:1 |
| LayoutMinimalPerf.default | 297 | 295 | 1.01:1 |
| ListNestedPerf.default | 454 | 449 | 1.01:1 |
| MenuMinimalPerf.default | 717 | 708 | 1.01:1 |
| RosterPerf.default | 906 | 895 | 1.01:1 |
| PopupMinimalPerf.default | 525 | 518 | 1.01:1 |
| SplitButtonMinimalPerf.default | 3694 | 3669 | 1.01:1 |
| TooltipMinimalPerf.default | 893 | 886 | 1.01:1 |
| TreeMinimalPerf.default | 681 | 674 | 1.01:1 |
| ChatWithPopoverPerf.default | 326 | 325 | 1:1 |
| CheckboxMinimalPerf.default | 2256 | 2259 | 1:1 |
| DatepickerMinimalPerf.default | 4800 | 4780 | 1:1 |
| EmbedMinimalPerf.default | 3444 | 3431 | 1:1 |
| ListMinimalPerf.default | 436 | 434 | 1:1 |
| ListWith60ListItems.default | 537 | 539 | 1:1 |
| StatusMinimalPerf.default | 559 | 559 | 1:1 |
| CustomToolbarPrototype.default | 2257 | 2263 | 1:1 |
| ButtonSlotsPerf.default | 451 | 454 | 0.99:1 |
| ProviderMergeThemesPerf.default | 1048 | 1054 | 0.99:1 |
| SegmentMinimalPerf.default | 282 | 286 | 0.99:1 |
| TableManyItemsPerf.default | 1592 | 1605 | 0.99:1 |
| ChatDuplicateMessagesPerf.default | 244 | 249 | 0.98:1 |
| ImageMinimalPerf.default | 297 | 302 | 0.98:1 |
| AttachmentSlotsPerf.default | 884 | 908 | 0.97:1 |
| CardMinimalPerf.default | 451 | 463 | 0.97:1 |
| ProviderMinimalPerf.default | 324 | 334 | 0.97:1 |
| AccordionMinimalPerf.default | 117 | 122 | 0.96:1 |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| TeachingBubble | mount | 46597 | 76240 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 699 | 737 | 5000 | |
| Breadcrumb | mount | 2328 | 2132 | 1000 | |
| Checkbox | mount | 1278 | 1234 | 5000 | |
| CheckboxBase | mount | 1002 | 961 | 5000 | |
| ChoiceGroup | mount | 3851 | 3858 | 5000 | |
| ComboBox | mount | 749 | 851 | 1000 | |
| CommandBar | mount | 8680 | 8693 | 1000 | |
| ContextualMenu | mount | 8895 | 9148 | 1000 | |
| DefaultButton | mount | 854 | 925 | 5000 | |
| DetailsRow | mount | 3120 | 3232 | 5000 | |
| DetailsRowFast | mount | 3195 | 3141 | 5000 | |
| DetailsRowNoStyles | mount | 2869 | 3145 | 5000 | |
| Dialog | mount | 1718 | 1886 | 1000 | |
| DocumentCardTitle | mount | 141 | 135 | 1000 | |
| Dropdown | mount | 2719 | 2695 | 5000 | |
| FocusTrapZone | mount | 1432 | 1487 | 5000 | |
| FocusZone | mount | 1420 | 1551 | 5000 | |
| IconButton | mount | 1531 | 1421 | 5000 | |
| Label | mount | 274 | 300 | 5000 | |
| Layer | mount | 2470 | 2350 | 5000 | |
| Link | mount | 339 | 371 | 5000 | |
| MenuButton | mount | 1235 | 1247 | 5000 | |
| MessageBar | mount | 1754 | 1712 | 5000 | |
| Nav | mount | 2837 | 2718 | 1000 | |
| OverflowSet | mount | 858 | 854 | 5000 | |
| Panel | mount | 1819 | 1697 | 1000 | |
| Persona | mount | 871 | 846 | 1000 | |
| Pivot | mount | 1213 | 1203 | 1000 | |
| PrimaryButton | mount | 1013 | 1125 | 5000 | |
| Rating | mount | 6475 | 6168 | 5000 | |
| SearchBox | mount | 1005 | 1091 | 5000 | |
| Shimmer | mount | 1930 | 1974 | 5000 | |
| Slider | mount | 1472 | 1507 | 5000 | |
| SpinButton | mount | 4166 | 4003 | 5000 | |
| Spinner | mount | 323 | 339 | 5000 | |
| SplitButton | mount | 2390 | 2583 | 5000 | |
| Stack | mount | 390 | 436 | 5000 | |
| StackWithIntrinsicChildren | mount | 1867 | 1802 | 5000 | |
| StackWithTextChildren | mount | 4134 | 4148 | 5000 | |
| SwatchColorPicker | mount | 9559 | 9419 | 5000 | |
| TagPicker | mount | 2263 | 2114 | 5000 | |
| TeachingBubble | mount | 46597 | 76240 | 5000 | Possible regression |
| Text | mount | 323 | 366 | 5000 | |
| TextField | mount | 1203 | 1078 | 5000 | |
| ThemeProvider | mount | 915 | 940 | 5000 | |
| ThemeProvider | virtual-rerender | 566 | 504 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1599 | 1626 | 5000 | |
| Toggle | mount | 695 | 634 | 5000 | |
| buttonNative | mount | 113 | 112 | 5000 |
jurokapsiar
approved these changes
Apr 7, 2022
Collaborator
|
can we make sure to apply the same text updates to the new templates when they get merged? See PR: #22337 |
JustSlone
approved these changes
Apr 8, 2022
spmonahan
approved these changes
Apr 12, 2022
Collaborator
|
This pull request has been automatically marked as stale because it was marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 5 days of this comment. Thank you for your contributions to Fluent UI! |
smhigley
force-pushed
the
issue-template-updates
branch
from
April 22, 2022 21:33
4aafb6d to
25b6c01
Compare
Hotell
approved these changes
Apr 25, 2022
marwan38
pushed a commit
to marwan38/fluentui
that referenced
this pull request
Jun 13, 2022
…nvergence checklist (microsoft#22363) * update a11y issue template, and add a11y test to convergence checklist * add wording about internal tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two issue template changes for the repo: