Skip to content

fix: restore SSRProvider export#22560

Merged
layershifter merged 1 commit into
microsoft:masterfrom
layershifter:fix/restore-ssr-provider
Apr 20, 2022
Merged

fix: restore SSRProvider export#22560
layershifter merged 1 commit into
microsoft:masterfrom
layershifter:fix/restore-ssr-provider

Conversation

@layershifter

Copy link
Copy Markdown
Member

New Behavior

Restores an export for SSRProvider i.e. a regression introduced in #22367.

For context: SSRProvider is required for SSR configuration:

image

2. Add the Fluent UI dependencies: `@fluentui/react-components`.

```sh
yarn add @fluentui/react-components@alpha

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alpha can be removed now

@codesandbox-ci

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 64933cf:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
174.881 kB
49.118 kB
react-components
react-components: FluentProvider & webLightTheme
32.671 kB
10.696 kB
🤖 This report was generated against d1ac3a2a447caff9c48724a964cf736d4b2678ce

@size-auditor

size-auditor Bot commented Apr 20, 2022

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: d1ac3a2a447caff9c48724a964cf736d4b2678ce (build)

@fabricteam

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 927 919 5000
Button mount 563 552 5000
FluentProvider mount 2050 1788 5000
FluentProviderWithTheme mount 288 275 10
FluentProviderWithTheme virtual-rerender 239 241 10
FluentProviderWithTheme virtual-rerender-with-unmount 327 301 10
MakeStyles mount 1551 1571 50000

@layershifter
layershifter merged commit 319234c into microsoft:master Apr 20, 2022
@layershifter
layershifter deleted the fix/restore-ssr-provider branch April 20, 2022 09:30
marwan38 pushed a commit to marwan38/fluentui that referenced this pull request Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants