pass in icon props to presence badge icon slot, and use default strings#22901
Merged
Conversation
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: e5f896d0098d23b01a4f0ab4b154fca0a47a1a89 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d0df13b:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1035 | 1022 | 5000 | |
| Button | mount | 648 | 682 | 5000 | |
| FluentProvider | mount | 2097 | 2149 | 5000 | |
| FluentProviderWithTheme | mount | 321 | 312 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 276 | 274 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 354 | 364 | 10 | |
| MakeStyles | mount | 1851 | 1851 | 50000 |
micahgodbolt
marked this pull request as ready for review
May 11, 2022 21:22
khmakoto
reviewed
May 11, 2022
…adge.tsx Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
spmonahan
approved these changes
May 13, 2022
marwan38
pushed a commit
to marwan38/fluentui
that referenced
this pull request
Jun 13, 2022
…gs (microsoft#22901) * pass in icon props to presence badge icon slot, and use default strings * change file * remove unused import * update api file * Update packages/react-badge/src/components/PresenceBadge/usePresenceBadge.tsx Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com> * Update packages/react-badge/src/stories/PresenceBadgeStatus.stories.tsx Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com> Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presence badge icon is not getting slot props, therefore you can't override the aria-label. Assuming we remove the aria-hidden, this will be necessary to allow for customization of the icon.