docs(react-components): Add theming docs#23080
Merged
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 69f4a53:
|
Collaborator
📊 Bundle size report🤖 This report was generated against bad6ad63ff7e2287519e7117f8a1963b623ae18e |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: bad6ad63ff7e2287519e7117f8a1963b623ae18e (build) |
ling1726
reviewed
May 19, 2022
ling1726
reviewed
May 19, 2022
|
|
||
| Fluent UI Theme is represented by a set of tokens. Each token resolves to a single value which can be assigned to a CSS property. | ||
|
|
||
| You can browse all the available tokens in **Theme** section of the docs. |
Contributor
There was a problem hiding this comment.
You can actually hyperlink to other pages or other parts of the same page. You can find some examples on the docs of build time optimization of Griffel
Member
Author
There was a problem hiding this comment.
Yeah, I know. the problem is Theme is a non-linkable section, not a page :-/
Contributor
There was a problem hiding this comment.
maybe just link to the most 'natural' part of that section like the color tokens ?
ling1726
reviewed
May 19, 2022
ling1726
reviewed
May 19, 2022
ling1726
reviewed
May 19, 2022
ling1726
reviewed
May 19, 2022
ling1726
reviewed
May 19, 2022
ling1726
reviewed
May 19, 2022
ling1726
reviewed
May 19, 2022
ling1726
reviewed
May 19, 2022
ling1726
reviewed
May 19, 2022
ling1726
reviewed
May 19, 2022
ling1726
reviewed
May 19, 2022
ling1726
approved these changes
May 19, 2022
Co-authored-by: ling1726 <lingfangao@hotmail.com>
|
|
||
| # Theming | ||
|
|
||
| The Fluent UI Theme is represented by a set of tokens. Each token resolves to a single value which can be assigned to a CSS property. |
Member
There was a problem hiding this comment.
Suggested change
| The Fluent UI Theme is represented by a set of tokens. Each token resolves to a single value which can be assigned to a CSS property. | |
| The Fluent UI Theme is represented by a set of tokens. Each token resolves to a single value which can be assigned to a CSS property. | |
| ```tsx | |
| const theme = { | |
| tokenA: 'var(--tokenA)', | |
| // etc. | |
| } | |
| ``` |
Will it be helpful to show what it actually means?
Member
Author
There was a problem hiding this comment.
Sure, but the theme object is semantic name -> raw value, so I added an example of that. The later sections explain how that is added to DOM and consumed in styles.
Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
marwan38
pushed a commit
to marwan38/fluentui
that referenced
this pull request
Jun 13, 2022
* docs(react-components): Add theming docs * Apply suggestions from code review Co-authored-by: ling1726 <lingfangao@hotmail.com> * Apply suggestions from code review Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * address PR comments * remove broken import Co-authored-by: ling1726 <lingfangao@hotmail.com> Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add theming docs for v9.
PREVIEW
Fixes #22358