Skip to content

Fixing high contrast for Link#239

Closed
antonlabunets wants to merge 3 commits into
microsoft:masterfrom
antonlabunets:antonla/highContrastLink
Closed

Fixing high contrast for Link#239
antonlabunets wants to merge 3 commits into
microsoft:masterfrom
antonlabunets:antonla/highContrastLink

Conversation

@antonlabunets

@antonlabunets antonlabunets commented Sep 2, 2016

Copy link
Copy Markdown
Collaborator

After a discussion with designers, removing all the overrides to ensure the defaults are met AND the end user can customize as with the rest of the links.

I've played with all the high contrast settings and confirmed they match the expectations and pass WebAIM.

@msftclas

msftclas commented Sep 2, 2016

Copy link
Copy Markdown

Hi @antonlabunets, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@mikewheaton

mikewheaton commented Sep 6, 2016

Copy link
Copy Markdown
Contributor

Approved, thanks 😄

Approved with PullApprove

@atneik

atneik commented Sep 6, 2016

Copy link
Copy Markdown
Contributor

This is being addressed in MDL2 PR: #123

@antonlabunets

Copy link
Copy Markdown
Collaborator Author

Feel free to abandon then.
On Tue, Sep 6, 2016 at 11:18 Aniket Handa notifications@github.com wrote:

This is being addressed in MDL2 PR: #123
#123


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#239 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQnHAJZZ389qVr8pnv8RMc3WbcB3q7nqks5qna5xgaJpZM4Jz5y1
.

@atneik

atneik commented Sep 7, 2016

Copy link
Copy Markdown
Contributor

Addressed in b158fc4. Closing

@atneik atneik closed this Sep 7, 2016
@microsoft microsoft locked as resolved and limited conversation to collaborators Sep 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants