Skip to content

Screener cleanup - #24170

Closed
ralucapelin wants to merge 17 commits into
microsoft:masterfrom
ralucapelin:screenerCleanup
Closed

Screener cleanup#24170
ralucapelin wants to merge 17 commits into
microsoft:masterfrom
ralucapelin:screenerCleanup

Conversation

@ralucapelin

Copy link
Copy Markdown
Contributor

Current Behavior

The screener checks code uses a large array of environment variables, some of which are not even used.

Parts of the configuration files need to be updated accordingly after recent changes to the CI/CD environment. (PR #24106 )

New Behavior

Screener code uses only necessary environment variables and code is more maintainable.

Related Issue(s)

Addresses #24102

@codesandbox-ci

codesandbox-ci Bot commented Aug 1, 2022

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 455e2d0:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor

size-auditor Bot commented Aug 1, 2022

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 5d2617e9b90046a13a6e493c1e54c4b45101f509 (build)

@fabricteam

fabricteam commented Aug 1, 2022

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1362 1314 5000
Button mount 951 934 5000
FluentProvider mount 1562 1572 5000
FluentProviderWithTheme mount 659 634 10
FluentProviderWithTheme virtual-rerender 593 583 10
FluentProviderWithTheme virtual-rerender-with-unmount 640 626 10
MakeStyles mount 1936 1957 50000
SpinButton mount 2445 2484 5000

@fabricteam

fabricteam commented Aug 1, 2022

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
533 B
341 B
global-context
createContextSelector
554 B
348 B
priority-overflow
createOverflowManager
2.936 kB
1.212 kB
react-accordion
Accordion (including children components)
79.485 kB
24.082 kB
react-alert
Alert
82.763 kB
20.582 kB
react-avatar
Avatar
48.172 kB
13.615 kB
react-avatar
AvatarGroup
13.43 kB
5.382 kB
react-avatar
AvatarGroupItem
64.878 kB
18.284 kB
react-badge
Badge
22.494 kB
7.157 kB
react-badge
CounterBadge
23.397 kB
7.449 kB
react-badge
PresenceBadge
23.947 kB
7.022 kB
react-button
Button
36.396 kB
9.575 kB
react-button
CompoundButton
43.469 kB
10.812 kB
react-button
MenuButton
39.014 kB
10.456 kB
react-button
SplitButton
46.506 kB
11.827 kB
react-button
ToggleButton
51.91 kB
11.003 kB
react-card
Card - All
67.42 kB
19.249 kB
react-card
Card
63.102 kB
18.167 kB
react-card
CardFooter
8.461 kB
3.555 kB
react-card
CardHeader
9.504 kB
3.896 kB
react-card
CardPreview
8.562 kB
3.61 kB
react-combobox
Combobox (including child components)
75.081 kB
24.145 kB
react-combobox
Dropdown (including child components)
74.594 kB
24.134 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
192.719 kB
52.784 kB
react-components
react-components: FluentProvider & webLightTheme
32.688 kB
10.736 kB
react-dialog
Dialog (including children components)
85.064 kB
25.293 kB
react-divider
Divider
16.321 kB
5.837 kB
react-image
Image
10.68 kB
4.215 kB
react-input
Input
23.554 kB
7.644 kB
react-label
Label
9.238 kB
3.815 kB
react-link
Link
12.197 kB
4.912 kB
react-menu
Menu (including children components)
118.878 kB
36.004 kB
react-menu
Menu (including selectable components)
122.077 kB
36.497 kB
react-overflow
hooks only
10.839 kB
4.146 kB
react-popover
Popover
106.135 kB
32.236 kB
react-portal
Portal
10.49 kB
3.845 kB
react-positioning
usePositioning
23.854 kB
8.299 kB
react-provider
FluentProvider
15.565 kB
5.818 kB
react-radio
Radio
36.13 kB
11.947 kB
react-radio
RadioGroup
14.319 kB
5.711 kB
react-select
Select
20.746 kB
7.299 kB
react-slider
Slider
31.988 kB
10.019 kB
react-spinbutton
SpinButton
43.899 kB
12.362 kB
react-spinner
Spinner
19.932 kB
6.363 kB
react-switch
Switch
32.438 kB
10.218 kB
react-text
Text - Default
11.572 kB
4.537 kB
react-text
Text - Wrappers
14.882 kB
4.977 kB
react-textarea
Textarea
23.078 kB
7.707 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
28.995 kB
6.215 kB
react-theme
Teams: Light theme
16.973 kB
4.86 kB
react-tooltip
Tooltip
45.515 kB
15.545 kB
react-utilities
SSRProvider
189 B
161 B
🤖 This report was generated against 5d2617e9b90046a13a6e493c1e54c4b45101f509

@fabricteam

fabricteam commented Aug 1, 2022

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
CarouselMinimalPerf.default 412 335 1.23:1
AnimationMinimalPerf.default 466 397 1.17:1
GridMinimalPerf.default 277 237 1.17:1
TableManyItemsPerf.default 1569 1358 1.16:1
TableMinimalPerf.default 329 284 1.16:1
HeaderMinimalPerf.default 303 263 1.15:1
LayoutMinimalPerf.default 292 255 1.15:1
SkeletonMinimalPerf.default 285 248 1.15:1
LabelMinimalPerf.default 318 284 1.12:1
MenuMinimalPerf.default 710 634 1.12:1
VideoMinimalPerf.default 511 457 1.12:1
HeaderSlotsPerf.default 610 555 1.1:1
IconMinimalPerf.default 503 457 1.1:1
TextAreaMinimalPerf.default 377 343 1.1:1
BoxMinimalPerf.default 251 236 1.06:1
CardMinimalPerf.default 431 412 1.05:1
ListNestedPerf.default 413 395 1.05:1
AttachmentMinimalPerf.default 111 107 1.04:1
ItemLayoutMinimalPerf.default 933 896 1.04:1
RefMinimalPerf.default 162 156 1.04:1
EmbedMinimalPerf.default 3366 3273 1.03:1
MenuButtonMinimalPerf.default 1363 1329 1.03:1
SplitButtonMinimalPerf.default 3521 3407 1.03:1
RosterPerf.default 857 839 1.02:1
CustomToolbarPrototype.default 2116 2075 1.02:1
ChatMinimalPerf.default 550 542 1.01:1
FlexMinimalPerf.default 205 203 1.01:1
PortalMinimalPerf.default 126 125 1.01:1
ProviderMinimalPerf.default 301 297 1.01:1
RadioGroupMinimalPerf.default 329 326 1.01:1
ReactionMinimalPerf.default 305 301 1.01:1
TextMinimalPerf.default 250 248 1.01:1
ButtonMinimalPerf.default 124 124 1:1
ChatWithPopoverPerf.default 284 283 1:1
DropdownMinimalPerf.default 2338 2337 1:1
ListCommonPerf.default 534 532 1:1
ListMinimalPerf.default 413 411 1:1
ChatDuplicateMessagesPerf.default 209 212 0.99:1
DialogMinimalPerf.default 557 565 0.99:1
ProviderMergeThemesPerf.default 931 939 0.99:1
ListWith60ListItems.default 499 507 0.98:1
SegmentMinimalPerf.default 245 250 0.98:1
SliderMinimalPerf.default 1237 1276 0.97:1
TooltipMinimalPerf.default 857 879 0.97:1
AccordionMinimalPerf.default 103 107 0.96:1
CheckboxMinimalPerf.default 1992 2078 0.96:1
DatepickerMinimalPerf.default 4414 4576 0.96:1
TreeWith60ListItems.default 130 136 0.96:1
AttachmentSlotsPerf.default 796 847 0.94:1
ImageMinimalPerf.default 288 306 0.94:1
StatusMinimalPerf.default 489 528 0.93:1
AvatarMinimalPerf.default 139 153 0.91:1
ButtonSlotsPerf.default 452 495 0.91:1
InputMinimalPerf.default 977 1070 0.91:1
FormMinimalPerf.default 293 327 0.9:1
ButtonOverridesMissPerf.default 1107 1247 0.89:1
DropdownManyItemsPerf.default 497 559 0.89:1
LoaderMinimalPerf.default 504 568 0.89:1
TreeMinimalPerf.default 610 684 0.89:1
AlertMinimalPerf.default 193 220 0.88:1
PopupMinimalPerf.default 471 539 0.87:1
ToolbarMinimalPerf.default 699 807 0.87:1
DividerMinimalPerf.default 258 301 0.86:1

@fabricteam

fabricteam commented Aug 1, 2022

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react)

Scenario Render type Master Ticks PR Ticks Iterations Status
TeachingBubble mount 49719 83319 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 757 727 5000
Breadcrumb mount 2114 2417 1000
Checkbox mount 2181 2188 5000
CheckboxBase mount 1929 1805 5000
ChoiceGroup mount 3835 4055 5000
ComboBox mount 829 817 1000
CommandBar mount 8856 9122 1000
ContextualMenu mount 9935 10099 1000
DefaultButton mount 997 924 5000
DetailsRow mount 3297 3259 5000
DetailsRowFast mount 3250 3306 5000
DetailsRowNoStyles mount 2956 3107 5000
Dialog mount 2480 2373 1000
DocumentCardTitle mount 153 153 1000
Dropdown mount 2833 2794 5000
FocusTrapZone mount 1533 1462 5000
FocusZone mount 1588 1430 5000
IconButton mount 1524 1438 5000
Label mount 298 309 5000
Layer mount 2677 2590 5000
Link mount 417 386 5000
MenuButton mount 1278 1206 5000
MessageBar mount 1845 1727 5000
Nav mount 2802 2686 1000
OverflowSet mount 948 840 5000
Panel mount 1888 1791 1000
Persona mount 832 867 1000
Pivot mount 1242 1257 1000
PrimaryButton mount 1148 1081 5000
Rating mount 6279 6372 5000
SearchBox mount 1117 1116 5000
Shimmer mount 2113 2064 5000
Slider mount 1573 1516 5000
SpinButton mount 4291 4201 5000
Spinner mount 374 313 5000
SplitButton mount 2543 2569 5000
Stack mount 388 394 5000
StackWithIntrinsicChildren mount 1974 1954 5000
StackWithTextChildren mount 4160 4434 5000
SwatchColorPicker mount 9715 9375 5000
TagPicker mount 2308 2328 5000
TeachingBubble mount 49719 83319 5000 Possible regression
Text mount 371 374 5000
TextField mount 1205 1194 5000
ThemeProvider mount 978 1033 5000
ThemeProvider virtual-rerender 577 601 5000
ThemeProvider virtual-rerender-with-unmount 1518 1508 5000
Toggle mount 717 618 5000
buttonNative mount 118 124 5000

@TristanWatanabe TristanWatanabe removed their assignment Aug 12, 2022
@ralucapelin
ralucapelin deleted the screenerCleanup branch September 30, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants