Skip to content

Add ref option to checkout action#24185

Merged
ralucapelin merged 1 commit into
masterfrom
update-screener-run-workflow
Aug 2, 2022
Merged

Add ref option to checkout action#24185
ralucapelin merged 1 commit into
masterfrom
update-screener-run-workflow

Conversation

@ralucapelin

Copy link
Copy Markdown
Contributor

Current Behavior

Screener run workflow runs on the master branch. the triggering PR source branch.

New Behavior

Screener run workflow runs on the triggering PR source branch.

Related Issue(s)

Addresses #24178

@codesandbox-ci

codesandbox-ci Bot commented Aug 2, 2022

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7613fd8:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1292 1329 5000
Button mount 927 926 5000
FluentProvider mount 1566 1598 5000
FluentProviderWithTheme mount 615 623 10
FluentProviderWithTheme virtual-rerender 590 588 10
FluentProviderWithTheme virtual-rerender-with-unmount 614 629 10
MakeStyles mount 1911 1878 50000
SpinButton mount 2615 2552 5000

@size-auditor

size-auditor Bot commented Aug 2, 2022

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 421f249b6b3f0887477551cbc97a889c7efecc73 (build)

@fabricteam

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
533 B
341 B
global-context
createContextSelector
554 B
348 B
priority-overflow
createOverflowManager
2.936 kB
1.212 kB
react-accordion
Accordion (including children components)
79.023 kB
24.029 kB
react-alert
Alert
82.173 kB
20.519 kB
react-avatar
Avatar
48.533 kB
13.78 kB
react-avatar
AvatarGroup
138.314 kB
40.998 kB
react-avatar
AvatarGroupItem
68.248 kB
19.109 kB
react-badge
Badge
22.494 kB
7.157 kB
react-badge
CounterBadge
23.397 kB
7.449 kB
react-badge
PresenceBadge
23.947 kB
7.022 kB
react-button
Button
35.766 kB
9.51 kB
react-button
CompoundButton
42.839 kB
10.74 kB
react-button
MenuButton
38.384 kB
10.375 kB
react-button
SplitButton
45.717 kB
11.718 kB
react-button
ToggleButton
50.991 kB
10.931 kB
react-card
Card - All
67.014 kB
19.206 kB
react-card
Card
62.696 kB
18.126 kB
react-card
CardFooter
8.461 kB
3.555 kB
react-card
CardHeader
9.504 kB
3.896 kB
react-card
CardPreview
8.562 kB
3.61 kB
react-combobox
Combobox (including child components)
74.425 kB
23.999 kB
react-combobox
Dropdown (including child components)
73.938 kB
23.991 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
190.59 kB
52.497 kB
react-components
react-components: FluentProvider & webLightTheme
32.036 kB
10.577 kB
react-dialog
Dialog (including children components)
83.94 kB
25.082 kB
react-divider
Divider
16.321 kB
5.837 kB
react-image
Image
10.68 kB
4.215 kB
react-input
Input
23.554 kB
7.644 kB
react-label
Label
9.238 kB
3.815 kB
react-link
Link
12.082 kB
4.88 kB
react-menu
Menu (including children components)
117.801 kB
35.808 kB
react-menu
Menu (including selectable components)
121 kB
36.288 kB
react-overflow
hooks only
10.839 kB
4.146 kB
react-popover
Popover
105.483 kB
32.077 kB
react-portal
Portal
9.844 kB
3.677 kB
react-positioning
usePositioning
23.854 kB
8.299 kB
react-provider
FluentProvider
14.913 kB
5.658 kB
react-radio
Radio
30.481 kB
10.406 kB
react-radio
RadioGroup
14.319 kB
5.711 kB
react-select
Select
20.746 kB
7.299 kB
react-slider
Slider
26.136 kB
8.387 kB
react-spinbutton
SpinButton
44.227 kB
12.492 kB
react-spinner
Spinner
19.932 kB
6.363 kB
react-switch
Switch
26.951 kB
8.688 kB
react-text
Text - Default
11.572 kB
4.537 kB
react-text
Text - Wrappers
14.882 kB
4.977 kB
react-textarea
Textarea
23.078 kB
7.707 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
28.995 kB
6.215 kB
react-theme
Teams: Light theme
16.973 kB
4.86 kB
react-tooltip
Tooltip
44.853 kB
15.406 kB
react-utilities
SSRProvider
189 B
161 B
🤖 This report was generated against 421f249b6b3f0887477551cbc97a889c7efecc73

@fabricteam

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
PortalMinimalPerf.default 160 145 1.1:1
RefMinimalPerf.default 217 205 1.06:1
ReactionMinimalPerf.default 345 331 1.04:1
IconMinimalPerf.default 544 525 1.04:1
AccordionMinimalPerf.default 125 121 1.03:1
AvatarMinimalPerf.default 169 164 1.03:1
ButtonSlotsPerf.default 425 414 1.03:1
CardMinimalPerf.default 507 494 1.03:1
GridMinimalPerf.default 307 297 1.03:1
AnimationMinimalPerf.default 495 485 1.02:1
CarouselMinimalPerf.default 371 365 1.02:1
ImageMinimalPerf.default 348 340 1.02:1
ListMinimalPerf.default 471 462 1.02:1
RosterPerf.default 866 853 1.02:1
ProviderMinimalPerf.default 328 321 1.02:1
RadioGroupMinimalPerf.default 404 395 1.02:1
SegmentMinimalPerf.default 313 308 1.02:1
SkeletonMinimalPerf.default 309 304 1.02:1
TextMinimalPerf.default 309 303 1.02:1
ToolbarMinimalPerf.default 851 831 1.02:1
TreeMinimalPerf.default 717 701 1.02:1
VideoMinimalPerf.default 580 570 1.02:1
AttachmentMinimalPerf.default 127 126 1.01:1
ChatWithPopoverPerf.default 318 315 1.01:1
DialogMinimalPerf.default 699 689 1.01:1
HeaderSlotsPerf.default 691 682 1.01:1
LabelMinimalPerf.default 346 341 1.01:1
MenuMinimalPerf.default 758 752 1.01:1
PopupMinimalPerf.default 562 554 1.01:1
SliderMinimalPerf.default 1344 1333 1.01:1
TableManyItemsPerf.default 1647 1629 1.01:1
AlertMinimalPerf.default 226 226 1:1
AttachmentSlotsPerf.default 865 861 1:1
BoxMinimalPerf.default 303 302 1:1
ChatDuplicateMessagesPerf.default 237 236 1:1
CheckboxMinimalPerf.default 1940 1949 1:1
DropdownMinimalPerf.default 2612 2605 1:1
EmbedMinimalPerf.default 2996 2991 1:1
FormMinimalPerf.default 370 369 1:1
InputMinimalPerf.default 1013 1011 1:1
ItemLayoutMinimalPerf.default 992 993 1:1
LayoutMinimalPerf.default 324 324 1:1
ListNestedPerf.default 485 483 1:1
SplitButtonMinimalPerf.default 3340 3339 1:1
StatusMinimalPerf.default 621 619 1:1
ButtonOverridesMissPerf.default 1166 1183 0.99:1
ChatMinimalPerf.default 658 662 0.99:1
DatepickerMinimalPerf.default 4938 5005 0.99:1
DividerMinimalPerf.default 315 319 0.99:1
DropdownManyItemsPerf.default 553 559 0.99:1
ListCommonPerf.default 515 521 0.99:1
LoaderMinimalPerf.default 533 537 0.99:1
MenuButtonMinimalPerf.default 1365 1382 0.99:1
TooltipMinimalPerf.default 968 974 0.99:1
ButtonMinimalPerf.default 135 138 0.98:1
HeaderMinimalPerf.default 313 318 0.98:1
ProviderMergeThemesPerf.default 989 1005 0.98:1
TableMinimalPerf.default 352 360 0.98:1
CustomToolbarPrototype.default 2221 2260 0.98:1
TextAreaMinimalPerf.default 415 434 0.96:1
FlexMinimalPerf.default 241 255 0.95:1
ListWith60ListItems.default 485 515 0.94:1
TreeWith60ListItems.default 125 135 0.93:1

@fabricteam

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 737 751 5000
Breadcrumb mount 2408 2138 1000
Checkbox mount 2107 2066 5000
CheckboxBase mount 1841 1859 5000
ChoiceGroup mount 3900 3603 5000
ComboBox mount 811 836 1000
CommandBar mount 8766 8707 1000
ContextualMenu mount 9486 9992 1000
DefaultButton mount 958 902 5000
DetailsRow mount 3225 3043 5000
DetailsRowFast mount 2933 2952 5000
DetailsRowNoStyles mount 3036 3097 5000
Dialog mount 2309 2355 1000
DocumentCardTitle mount 146 143 1000
Dropdown mount 2633 2675 5000
FocusTrapZone mount 1644 1588 5000
FocusZone mount 1511 1374 5000
IconButton mount 1384 1335 5000
Label mount 264 311 5000
Layer mount 2482 2560 5000
Link mount 353 381 5000
MenuButton mount 1269 1256 5000
MessageBar mount 1732 1577 5000
Nav mount 2617 2627 1000
OverflowSet mount 857 882 5000
Panel mount 1771 1845 1000
Persona mount 871 769 1000
Pivot mount 1121 1142 1000
PrimaryButton mount 996 1028 5000
Rating mount 6381 6141 5000
SearchBox mount 1079 1037 5000
Shimmer mount 1952 1939 5000
Slider mount 1512 1522 5000
SpinButton mount 3876 4047 5000
Spinner mount 328 392 5000
SplitButton mount 2576 2527 5000
Stack mount 465 394 5000
StackWithIntrinsicChildren mount 1841 1781 5000
StackWithTextChildren mount 4147 4057 5000
SwatchColorPicker mount 9660 9179 5000
TagPicker mount 2177 2246 5000
TeachingBubble mount 80311 45684 5000
Text mount 356 374 5000
TextField mount 1155 1161 5000
ThemeProvider mount 985 927 5000
ThemeProvider virtual-rerender 591 580 5000
ThemeProvider virtual-rerender-with-unmount 1523 1376 5000
Toggle mount 606 628 5000
buttonNative mount 97 106 5000

@ralucapelin
ralucapelin marked this pull request as ready for review August 2, 2022 14:57
@ralucapelin
ralucapelin requested a review from a team as a code owner August 2, 2022 14:57
@ralucapelin
ralucapelin merged commit 9100e12 into master Aug 2, 2022
@ralucapelin
ralucapelin deleted the update-screener-run-workflow branch August 2, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants