Enable proxy triggering by ralucapelin · Pull Request #24248 · microsoft/fluentui

ralucapelin · 2022-08-05T08:06:45Z

Current Behavior

Screener workflows are triggered by pull request events.

New Behavior

Screener workflow can only be manually triggered and are able to receive inputs.

Related Issue(s)

Follow-up for #24178

Co-authored-by: ling1726 <lingfangao@hotmail.com>

…ft/fluentui into screenerChecksTransition

author Raluca Pelin <t-rpelin@microsoft.com> 1659439645 +0300 committer Raluca Pelin <t-rpelin@microsoft.com> 1659439711 +0300 parent e25a471 author Raluca Pelin <t-rpelin@microsoft.com> 1659439645 +0300 committer Raluca Pelin <t-rpelin@microsoft.com> 1659439665 +0300 Solve rebase conflict Remove screener jobs from pipeline Additional documentation Add checkout action option Add change suggested by review Restore pipeline from master branch Make changes proposed in review Update step name Co-authored-by: ling1726 <lingfangao@hotmail.com> Fix typo for environment variable value Change workflow trigger event and remove ADO screener jobs Comment out screener code check Remove screener code check

…oft/fluentui into enable-screener-workflows

…orkflows

fabricteam · 2022-08-05T08:17:22Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`554 B` `348 B`
`priority-overflow` createOverflowManager	`2.936 kB` `1.212 kB`
`react-accordion` Accordion (including children components)	`79.485 kB` `24.082 kB`
`react-alert` Alert	`82.803 kB` `20.582 kB`
`react-avatar` Avatar	`48.533 kB` `13.78 kB`
`react-avatar` AvatarGroup	`13.43 kB` `5.382 kB`
`react-avatar` AvatarGroupItem	`65.094 kB` `18.361 kB`
`react-badge` Badge	`22.494 kB` `7.157 kB`
`react-badge` CounterBadge	`23.397 kB` `7.449 kB`
`react-badge` PresenceBadge	`23.947 kB` `7.022 kB`
`react-button` Button	`36.396 kB` `9.575 kB`
`react-button` CompoundButton	`43.469 kB` `10.812 kB`
`react-button` MenuButton	`39.014 kB` `10.456 kB`
`react-button` SplitButton	`46.506 kB` `11.827 kB`
`react-button` ToggleButton	`51.912 kB` `11.004 kB`
`react-card` Card - All	`67.42 kB` `19.249 kB`
`react-card` Card	`63.102 kB` `18.167 kB`
`react-card` CardFooter	`8.461 kB` `3.555 kB`
`react-card` CardHeader	`9.504 kB` `3.896 kB`
`react-card` CardPreview	`8.562 kB` `3.61 kB`
`react-combobox` Combobox (including child components)	`75.081 kB` `24.145 kB`
`react-combobox` Dropdown (including child components)	`74.594 kB` `24.134 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`192.699 kB` `52.786 kB`
`react-components` react-components: FluentProvider & webLightTheme	`32.688 kB` `10.736 kB`
`react-dialog` Dialog (including children components)	`85.064 kB` `25.293 kB`
`react-divider` Divider	`16.321 kB` `5.837 kB`
`react-image` Image	`10.68 kB` `4.215 kB`
`react-input` Input	`23.554 kB` `7.644 kB`
`react-label` Label	`9.238 kB` `3.815 kB`
`react-link` Link	`12.197 kB` `4.912 kB`
`react-menu` Menu (including children components)	`118.866 kB` `36.006 kB`
`react-menu` Menu (including selectable components)	`122.065 kB` `36.499 kB`
`react-overflow` hooks only	`10.839 kB` `4.146 kB`
`react-popover` Popover	`106.133 kB` `32.244 kB`
`react-portal` Portal	`10.49 kB` `3.845 kB`
`react-positioning` usePositioning	`23.854 kB` `8.299 kB`
`react-provider` FluentProvider	`15.565 kB` `5.818 kB`
`react-radio` Radio	`36.329 kB` `12.024 kB`
`react-radio` RadioGroup	`14.319 kB` `5.711 kB`
`react-select` Select	`20.746 kB` `7.299 kB`
`react-slider` Slider	`31.988 kB` `10.019 kB`
`react-spinbutton` SpinButton	`44.227 kB` `12.492 kB`
`react-spinner` Spinner	`19.932 kB` `6.363 kB`
`react-switch` Switch	`32.781 kB` `10.348 kB`
`react-text` Text - Default	`11.572 kB` `4.537 kB`
`react-text` Text - Wrappers	`14.882 kB` `4.977 kB`
`react-textarea` Textarea	`23.078 kB` `7.707 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`28.995 kB` `6.215 kB`
`react-theme` Teams: Light theme	`16.973 kB` `4.86 kB`
`react-tooltip` Tooltip	`45.509 kB` `15.537 kB`
`react-utilities` SSRProvider	`189 B` `161 B`

_{🤖 This report was generated against b9b2c4cf2b69e8d5e4b0a8a01fcc8458b1c8efc6}

size-auditor · 2022-08-05T08:19:12Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 9253171aac6e08d6830361d125d657f21ddfc90a (build)

fabricteam · 2022-08-05T08:22:17Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1310	1152	5000
Button	mount	2920	893	5000
FluentProvider	mount	1509	1527	5000
FluentProviderWithTheme	mount	549	592	10
FluentProviderWithTheme	virtual-rerender	579	576	10
FluentProviderWithTheme	virtual-rerender-with-unmount	544	557	10
MakeStyles	mount	1849	1764	50000
SpinButton	mount	2472	2331	5000

fabricteam · 2022-08-05T08:31:31Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
AccordionMinimalPerf.default	132	123	1.07:1
AlertMinimalPerf.default	228	218	1.05:1
HeaderMinimalPerf.default	333	317	1.05:1
LabelMinimalPerf.default	346	330	1.05:1
AvatarMinimalPerf.default	168	161	1.04:1
DividerMinimalPerf.default	322	310	1.04:1
FlexMinimalPerf.default	263	252	1.04:1
RefMinimalPerf.default	187	180	1.04:1
ProviderMinimalPerf.default	326	315	1.03:1
TreeWith60ListItems.default	132	128	1.03:1
DropdownManyItemsPerf.default	561	552	1.02:1
FormMinimalPerf.default	354	348	1.02:1
MenuMinimalPerf.default	753	736	1.02:1
RadioGroupMinimalPerf.default	401	395	1.02:1
SkeletonMinimalPerf.default	305	298	1.02:1
SliderMinimalPerf.default	1350	1319	1.02:1
IconMinimalPerf.default	536	523	1.02:1
TextAreaMinimalPerf.default	436	428	1.02:1
AnimationMinimalPerf.default	473	469	1.01:1
AttachmentSlotsPerf.default	883	877	1.01:1
ButtonMinimalPerf.default	141	139	1.01:1
DropdownMinimalPerf.default	2579	2553	1.01:1
GridMinimalPerf.default	301	297	1.01:1
LayoutMinimalPerf.default	321	319	1.01:1
ListNestedPerf.default	470	466	1.01:1
ListWith60ListItems.default	506	499	1.01:1
PopupMinimalPerf.default	556	550	1.01:1
ProviderMergeThemesPerf.default	992	984	1.01:1
ReactionMinimalPerf.default	336	333	1.01:1
TooltipMinimalPerf.default	950	938	1.01:1
AttachmentMinimalPerf.default	129	129	1:1
CarouselMinimalPerf.default	354	354	1:1
ChatDuplicateMessagesPerf.default	233	232	1:1
ChatMinimalPerf.default	654	651	1:1
CheckboxMinimalPerf.default	1942	1951	1:1
InputMinimalPerf.default	992	994	1:1
ListMinimalPerf.default	458	459	1:1
RosterPerf.default	851	852	1:1
SplitButtonMinimalPerf.default	3291	3281	1:1
StatusMinimalPerf.default	601	604	1:1
TableManyItemsPerf.default	1582	1584	1:1
CustomToolbarPrototype.default	2170	2168	1:1
ToolbarMinimalPerf.default	814	811	1:1
TreeMinimalPerf.default	706	708	1:1
ButtonOverridesMissPerf.default	1185	1191	0.99:1
ButtonSlotsPerf.default	421	427	0.99:1
DialogMinimalPerf.default	685	690	0.99:1
EmbedMinimalPerf.default	2972	2991	0.99:1
HeaderSlotsPerf.default	683	692	0.99:1
ItemLayoutMinimalPerf.default	981	989	0.99:1
LoaderMinimalPerf.default	528	534	0.99:1
SegmentMinimalPerf.default	305	309	0.99:1
TextMinimalPerf.default	304	307	0.99:1
BoxMinimalPerf.default	298	304	0.98:1
CardMinimalPerf.default	470	479	0.98:1
ChatWithPopoverPerf.default	300	305	0.98:1
ImageMinimalPerf.default	330	338	0.98:1
MenuButtonMinimalPerf.default	1324	1347	0.98:1
TableMinimalPerf.default	355	361	0.98:1
VideoMinimalPerf.default	552	564	0.98:1
DatepickerMinimalPerf.default	4541	4663	0.97:1
PortalMinimalPerf.default	139	143	0.97:1
ListCommonPerf.default	506	531	0.95:1

fabricteam · 2022-08-05T08:40:15Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	776	790	5000
Breadcrumb	mount	2368	2360	1000
Checkbox	mount	2215	2204	5000
CheckboxBase	mount	1944	1953	5000
ChoiceGroup	mount	4053	4029	5000
ComboBox	mount	835	849	1000
CommandBar	mount	9042	8991	1000
ContextualMenu	mount	10236	9909	1000
DefaultButton	mount	966	965	5000
DetailsRow	mount	3235	3283	5000
DetailsRowFast	mount	3276	3282	5000
DetailsRowNoStyles	mount	3130	3169	5000
Dialog	mount	2438	2463	1000
DocumentCardTitle	mount	148	153	1000
Dropdown	mount	2833	2835	5000
FocusTrapZone	mount	1623	1599	5000
FocusZone	mount	1568	1548	5000
IconButton	mount	1506	1519	5000
Label	mount	302	302	5000
Layer	mount	2683	2735	5000
Link	mount	408	409	5000
MenuButton	mount	1264	1279	5000
MessageBar	mount	1849	1836	5000
Nav	mount	2856	2857	1000
OverflowSet	mount	942	938	5000
Panel	mount	1845	1899	1000
Persona	mount	844	893	1000
Pivot	mount	1240	1247	1000
PrimaryButton	mount	1095	1097	5000
Rating	mount	6602	6617	5000
SearchBox	mount	1127	1127	5000
Shimmer	mount	2132	2178	5000
Slider	mount	1662	1677	5000
SpinButton	mount	4317	4381	5000
Spinner	mount	378	371	5000
SplitButton	mount	2760	2767	5000
Stack	mount	452	437	5000
StackWithIntrinsicChildren	mount	1986	1960	5000
StackWithTextChildren	mount	4514	4494	5000
SwatchColorPicker	mount	9991	10085	5000
TagPicker	mount	2354	2303	5000
TeachingBubble	mount	80197	81355	5000
Text	mount	364	376	5000
TextField	mount	1178	1197	5000
ThemeProvider	mount	1035	1050	5000
ThemeProvider	virtual-rerender	598	584	5000
ThemeProvider	virtual-rerender-with-unmount	1561	1526	5000
Toggle	mount	686	706	5000
buttonNative	mount	104	109	5000

codesandbox-ci · 2022-08-05T09:16:45Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0df748e:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

…gering

Raluca Pelin and others added 30 commits July 27, 2022 15:18

Add screener workflows

090e9f1

Remove screener jobs from pipeline

a9a8f47

Additional documentation

924bbd2

Add checkout action option

8974b12

Make changes suggested in PR review

2a371d0

Add change suggested by review

8ea283b

Restore pipeline from master branch

8cd922d

Restore fetch path from master branch

1cc9223

Update step name

9304e1d

Co-authored-by: ling1726 <lingfangao@hotmail.com>

Make changes proposed in review

05814f9

Merge branch 'screenerChecksTransition' of https://github.com/microso…

ebc5667

…ft/fluentui into screenerChecksTransition

Fix typo for environment variable value

356967f

Change workflow trigger event and remove ADO screener jobs

4101b78

Merge branch 'master' into enable-screener-workflows

9a22997

Comment out screener code check

30383b7

Remove screener code check

e1a682a

Solve rebase conflict

1b00a58

Solve screener code conflict

e25a471

Merge branch 'enable-screener-workflows' of https://github.com/micros…

a72af69

…oft/fluentui into enable-screener-workflows

Merge remote-tracking branch 'upstream/master' into enable-screener-w…

892090c

…orkflows

Set checkout action repository

39469f7

Test checkout action option

2ca4ada

Change checkout action option

47f73a0

Debug screener run workflow

5929770

Set ref option for checkout action

cd6c21b

Merge remote-tracking branch 'upstream/master' into enable-screener-w…

e1699c9

…orkflows

Clean up workflow code

93288a4

Set env variables for build workflow

e13b9b7

Set env variables for each screener job

75eca97

Raluca Pelin added 5 commits August 3, 2022 12:14

Change trigger event for build workflow

1e7b6d6

Add workflow dispatch trigger event for screener build workflow

9627327

Remove checkout ref option

56e1700

Add workflow dispatch inputs

0f13fe3

Rebase

bb36830

msft-fluent-ui-bot assigned TristanWatanabe Aug 5, 2022

Get PR ID via GH contexts

50cdc1a

Raluca Pelin added 9 commits August 5, 2022 12:25

Update environment variables setting conditions

1b49c52

Remove pull request trigger event

15f94bb

Remove debug message

f319aff

Change env variables setting condition

a3f6209

Fix condition for env vars setting

c900a93

Update env variable value

daa4fad

Update env variable value

b55e7b9

Change inputs description

db3950c

Merge remote-tracking branch 'upstream/master' into enable-proxy-trig…

0df748e

…gering

ralucapelin added the Area: Build System label Aug 5, 2022

TristanWatanabe removed their assignment Aug 12, 2022

ralucapelin closed this Sep 30, 2022

khmakoto deleted the enable-proxy-triggering branch April 11, 2023 20:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Enable proxy triggering#24248

Enable proxy triggering#24248
ralucapelin wants to merge 45 commits into
masterfrom
enable-proxy-triggering

ralucapelin commented Aug 5, 2022

Uh oh!

fabricteam commented Aug 5, 2022 •

edited

Loading

Uh oh!

size-auditor Bot commented Aug 5, 2022 •

edited

Loading

Uh oh!

fabricteam commented Aug 5, 2022 •

edited

Loading

Uh oh!

fabricteam commented Aug 5, 2022 •

edited

Loading

Uh oh!

fabricteam commented Aug 5, 2022 •

edited

Loading

Uh oh!

codesandbox-ci Bot commented Aug 5, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

ralucapelin commented Aug 5, 2022

Current Behavior

New Behavior

Related Issue(s)

Uh oh!

fabricteam commented Aug 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

size-auditor Bot commented Aug 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

fabricteam commented Aug 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented Aug 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Aug 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

codesandbox-ci Bot commented Aug 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fabricteam commented Aug 5, 2022 •

edited

Loading

size-auditor Bot commented Aug 5, 2022 •

edited

Loading

fabricteam commented Aug 5, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented Aug 5, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Aug 5, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react`)

codesandbox-ci Bot commented Aug 5, 2022 •

edited

Loading