feat: add toolbar controlled state example for toggle buttons#24380
Conversation
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 625f79c61c8a496a31d19c615a0b8e0d9a72e55b (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1653 | 1646 | 5000 | |
| Button | mount | 1142 | 1204 | 5000 | |
| FluentProvider | mount | 1944 | 1925 | 5000 | |
| FluentProviderWithTheme | mount | 714 | 715 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 653 | 659 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 712 | 708 | 10 | |
| MakeStyles | mount | 2239 | 2286 | 50000 | |
| SpinButton | mount | 3315 | 3147 | 5000 |
…uentui into feat/toolbar-controlled-state
|
Was this a bad commit ? You created context values that are never used |
@ling1726 which values? I have created |
|
@ling1726 check if last commit was what you meant. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 39dd491:
|
bsunderhus
left a comment
There was a problem hiding this comment.
Overall LGTM, I only got one open question: the modification of ToggleButtonState types, they seem to be inconsistent, I might be completely wrong though, but I'm assuming this inconsistency is hard to track due to casting on useToggleState.
Overview
Add controlled state feature for
ToolbarToggleButton