Skip to content

feat(react-textarea): Add shadow variant of filled appearance #24512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sopranopillow merged 4 commits into from
Sep 15, 2022
Merged

feat(react-textarea): Add shadow variant of filled appearance #24512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e1f61f7
feat: Adding filled with shadow appearance.
sopranopillow Aug 24, 2022
554d0c7
change files
sopranopillow Aug 24, 2022
4d4fec6
updating appearance background for filled examples
sopranopillow Sep 8, 2022
d2b7cfa
Merge branch 'master' of https://www.github.com/microsoft/fluentui in…
sopranopillow Sep 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-textarea-0dad2dd6-d586-4358-ba42-c9a6b9a0bfc9.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "minor",
"comment": "feat: Adding filled with shadow appearance.",
"packageName": "@fluentui/react-textarea",
"email": "esteban.230@hotmail.com",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion packages/react-components/react-textarea/etc/react-textarea.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export const textareaClassNames: SlotClassNames<TextareaSlots>;

// @public
export type TextareaProps = Omit<ComponentProps<Partial<TextareaSlots>, 'textarea'>, 'defaultValue' | 'onChange' | 'size' | 'value'> & {
appearance?: 'outline' | 'filled-darker' | 'filled-lighter';
appearance?: 'outline' | 'filled-darker' | 'filled-lighter' | 'filled-darker-shadow' | 'filled-lighter-shadow';
defaultValue?: string;
onChange?: (ev: React_2.ChangeEvent<HTMLTextAreaElement>, data: TextareaOnChangeData) => void;
resize?: 'none' | 'horizontal' | 'vertical' | 'both';
Expand Down
2 changes: 1 addition & 1 deletion packages/react-components/react-textarea/src/components/Textarea/Textarea.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export type TextareaProps = Omit<
*
* @default outline
*/
appearance?: 'outline' | 'filled-darker' | 'filled-lighter';
appearance?: 'outline' | 'filled-darker' | 'filled-lighter' | 'filled-darker-shadow' | 'filled-lighter-shadow';
Comment thread
sopranopillow marked this conversation as resolved.

/**
* The default value of the Textarea.
Expand Down
12 changes: 12 additions & 0 deletions packages/react-components/react-textarea/src/components/Textarea/useTextareaStyles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,18 @@ const useRootStyles = makeStyles({
backgroundColor: tokens.colorNeutralBackground1,
},

'filled-darker-shadow': {
backgroundColor: tokens.colorNeutralBackground3,
...shorthands.border(tokens.strokeWidthThin, 'solid', tokens.colorTransparentStrokeInteractive),
boxShadow: tokens.shadow2,
},

'filled-lighter-shadow': {
backgroundColor: tokens.colorNeutralBackground1,
...shorthands.border(tokens.strokeWidthThin, 'solid', tokens.colorTransparentStrokeInteractive),
boxShadow: tokens.shadow2,
},

outline: {
backgroundColor: tokens.colorNeutralBackground1,
...shorthands.border(tokens.strokeWidthThin, 'solid', tokens.colorNeutralStroke1),
Expand Down
22 changes: 22 additions & 0 deletions packages/react-components/react-textarea/src/stories/Textarea/TextareaAppearance.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ const useStyles = makeStyles({
export const Appearance = () => {
const outlineId = useId('textarea-outline');
const filledDarkerId = useId('textarea-filleddarker');
const filledDarkerShadowId = useId('textarea-filleddarkershadow');
const filledLighterId = useId('textarea-filledlighter');
const filledLighterShadowId = useId('textarea-filledlightershadow');
const styles = useStyles();

return (
Expand All @@ -54,6 +56,26 @@ export const Appearance = () => {
<Label htmlFor={filledLighterId}>Textarea with Filled Lighter appearance.</Label>
<Textarea id={filledLighterId} appearance="filled-lighter" placeholder="type here..." resize="both" />
</div>

<div className={styles.filledDarker}>
Comment thread
sopranopillow marked this conversation as resolved.
<Label htmlFor={filledDarkerShadowId}>Textarea with Filled Darker with shadow appearance.</Label>
<Textarea
id={filledDarkerShadowId}
appearance="filled-darker-shadow"
placeholder="type here..."
resize="both"
/>
</div>

<div className={styles.filledLighter}>
<Label htmlFor={filledLighterShadowId}>Textarea with Filled Lighter with shadow appearance.</Label>
<Textarea
id={filledLighterShadowId}
appearance="filled-lighter-shadow"
placeholder="type here..."
resize="both"
/>
</div>
</div>
);
};
Expand Down