Add field to proxy request body#24564
Merged
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ad7791d:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 50ccc512c2c0010b9f330f7cf200427f8fe1317d (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1573 | 1570 | 5000 | |
| Button | mount | 1138 | 1115 | 5000 | |
| FluentProvider | mount | 1931 | 1890 | 5000 | |
| FluentProviderWithTheme | mount | 773 | 747 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 695 | 696 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 759 | 751 | 10 | |
| MakeStyles | mount | 2292 | 2279 | 50000 | |
| SpinButton | mount | 3014 | 3018 | 5000 |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AttachmentMinimalPerf.default | 130 | 102 | 1.27:1 |
| TreeWith60ListItems.default | 139 | 119 | 1.17:1 |
| LayoutMinimalPerf.default | 296 | 256 | 1.16:1 |
| ProviderMinimalPerf.default | 340 | 296 | 1.15:1 |
| CarouselMinimalPerf.default | 394 | 346 | 1.14:1 |
| RefMinimalPerf.default | 176 | 156 | 1.13:1 |
| HeaderMinimalPerf.default | 279 | 249 | 1.12:1 |
| ListCommonPerf.default | 520 | 466 | 1.12:1 |
| PopupMinimalPerf.default | 510 | 463 | 1.1:1 |
| RadioGroupMinimalPerf.default | 355 | 323 | 1.1:1 |
| ButtonMinimalPerf.default | 131 | 120 | 1.09:1 |
| PortalMinimalPerf.default | 149 | 137 | 1.09:1 |
| ButtonOverridesMissPerf.default | 1200 | 1110 | 1.08:1 |
| MenuMinimalPerf.default | 672 | 624 | 1.08:1 |
| AccordionMinimalPerf.default | 108 | 101 | 1.07:1 |
| LoaderMinimalPerf.default | 539 | 502 | 1.07:1 |
| MenuButtonMinimalPerf.default | 1396 | 1299 | 1.07:1 |
| IconMinimalPerf.default | 488 | 455 | 1.07:1 |
| ChatDuplicateMessagesPerf.default | 226 | 213 | 1.06:1 |
| DatepickerMinimalPerf.default | 4662 | 4402 | 1.06:1 |
| DropdownManyItemsPerf.default | 537 | 509 | 1.06:1 |
| DialogMinimalPerf.default | 588 | 568 | 1.04:1 |
| DividerMinimalPerf.default | 266 | 256 | 1.04:1 |
| RosterPerf.default | 1630 | 1570 | 1.04:1 |
| CustomToolbarPrototype.default | 2289 | 2206 | 1.04:1 |
| ImageMinimalPerf.default | 279 | 272 | 1.03:1 |
| StatusMinimalPerf.default | 543 | 525 | 1.03:1 |
| InputMinimalPerf.default | 971 | 951 | 1.02:1 |
| SplitButtonMinimalPerf.default | 3322 | 3250 | 1.02:1 |
| TableMinimalPerf.default | 299 | 293 | 1.02:1 |
| ToolbarMinimalPerf.default | 694 | 678 | 1.02:1 |
| ChatMinimalPerf.default | 534 | 529 | 1.01:1 |
| FormMinimalPerf.default | 269 | 266 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 887 | 878 | 1.01:1 |
| ReactionMinimalPerf.default | 306 | 304 | 1.01:1 |
| TableManyItemsPerf.default | 1384 | 1371 | 1.01:1 |
| CheckboxMinimalPerf.default | 1976 | 1971 | 1:1 |
| FlexMinimalPerf.default | 210 | 210 | 1:1 |
| ListNestedPerf.default | 411 | 411 | 1:1 |
| SegmentMinimalPerf.default | 253 | 253 | 1:1 |
| SkeletonMinimalPerf.default | 249 | 249 | 1:1 |
| TextMinimalPerf.default | 250 | 250 | 1:1 |
| TooltipMinimalPerf.default | 1758 | 1751 | 1:1 |
| TreeMinimalPerf.default | 592 | 593 | 1:1 |
| VideoMinimalPerf.default | 537 | 536 | 1:1 |
| AlertMinimalPerf.default | 188 | 190 | 0.99:1 |
| ButtonSlotsPerf.default | 410 | 414 | 0.99:1 |
| CardMinimalPerf.default | 382 | 384 | 0.99:1 |
| DropdownMinimalPerf.default | 2428 | 2457 | 0.99:1 |
| ListMinimalPerf.default | 373 | 377 | 0.99:1 |
| SliderMinimalPerf.default | 1256 | 1265 | 0.99:1 |
| AttachmentSlotsPerf.default | 805 | 821 | 0.98:1 |
| ChatWithPopoverPerf.default | 284 | 290 | 0.98:1 |
| EmbedMinimalPerf.default | 3074 | 3126 | 0.98:1 |
| ListWith60ListItems.default | 443 | 453 | 0.98:1 |
| HeaderSlotsPerf.default | 583 | 621 | 0.94:1 |
| LabelMinimalPerf.default | 295 | 316 | 0.93:1 |
| ProviderMergeThemesPerf.default | 960 | 1051 | 0.91:1 |
| TextAreaMinimalPerf.default | 343 | 378 | 0.91:1 |
| AnimationMinimalPerf.default | 397 | 439 | 0.9:1 |
| AvatarMinimalPerf.default | 138 | 155 | 0.89:1 |
| BoxMinimalPerf.default | 244 | 274 | 0.89:1 |
| GridMinimalPerf.default | 240 | 273 | 0.88:1 |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 889 | 885 | 5000 | |
| Breadcrumb | mount | 2983 | 2855 | 1000 | |
| Checkbox | mount | 2622 | 2589 | 5000 | |
| CheckboxBase | mount | 2317 | 2334 | 5000 | |
| ChoiceGroup | mount | 4684 | 4734 | 5000 | |
| ComboBox | mount | 981 | 973 | 1000 | |
| CommandBar | mount | 10780 | 10765 | 1000 | |
| ContextualMenu | mount | 12373 | 12424 | 1000 | |
| DefaultButton | mount | 1149 | 1158 | 5000 | |
| DetailsRow | mount | 3859 | 3838 | 5000 | |
| DetailsRowFast | mount | 3958 | 3965 | 5000 | |
| DetailsRowNoStyles | mount | 3781 | 3679 | 5000 | |
| Dialog | mount | 3150 | 3125 | 1000 | |
| DocumentCardTitle | mount | 176 | 185 | 1000 | |
| Dropdown | mount | 3394 | 3447 | 5000 | |
| FocusTrapZone | mount | 1910 | 1986 | 5000 | |
| FocusZone | mount | 1822 | 1882 | 5000 | |
| IconButton | mount | 1833 | 1752 | 5000 | |
| Label | mount | 354 | 354 | 5000 | |
| Layer | mount | 4663 | 4584 | 5000 | |
| Link | mount | 477 | 485 | 5000 | |
| MenuButton | mount | 1520 | 1515 | 5000 | |
| MessageBar | mount | 2279 | 2168 | 5000 | |
| Nav | mount | 3400 | 3434 | 1000 | |
| OverflowSet | mount | 1103 | 1171 | 5000 | |
| Panel | mount | 2541 | 2561 | 1000 | |
| Persona | mount | 1010 | 1009 | 1000 | |
| Pivot | mount | 1443 | 1450 | 1000 | |
| PrimaryButton | mount | 1306 | 1344 | 5000 | |
| Rating | mount | 7877 | 7784 | 5000 | |
| SearchBox | mount | 1304 | 1308 | 5000 | |
| Shimmer | mount | 2916 | 2877 | 5000 | |
| Slider | mount | 1951 | 1988 | 5000 | |
| SpinButton | mount | 5079 | 5084 | 5000 | |
| Spinner | mount | 434 | 432 | 5000 | |
| SplitButton | mount | 3241 | 3217 | 5000 | |
| Stack | mount | 506 | 490 | 5000 | |
| StackWithIntrinsicChildren | mount | 2348 | 2275 | 5000 | |
| StackWithTextChildren | mount | 5263 | 5234 | 5000 | |
| SwatchColorPicker | mount | 11929 | 11909 | 5000 | |
| TagPicker | mount | 2677 | 2650 | 5000 | |
| TeachingBubble | mount | 96489 | 96836 | 5000 | |
| Text | mount | 436 | 417 | 5000 | |
| TextField | mount | 1384 | 1401 | 5000 | |
| ThemeProvider | mount | 1323 | 1335 | 5000 | |
| ThemeProvider | virtual-rerender | 776 | 792 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2064 | 2078 | 5000 | |
| Toggle | mount | 818 | 827 | 5000 | |
| buttonNative | mount | 133 | 132 | 5000 |
ralucapelin
marked this pull request as ready for review
August 29, 2022 12:04
Hotell
approved these changes
Aug 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
In order to check if a screener test should be skipped or not, the proxy sends a GET request to the blob storage address where test apps should be deployed and checks whether the response is 200(test app deployed) or 404(test app not deployed). However, test apps from previous build will still be accessible from the same address for builds that have not uploaded test apps so the response would still be 200 instead of 404.
New Behavior
The proxy receives, besides the payload used for calling the screener API, the status of the test app artifact through another field of the request body:
isArtifactPresent, so that the proxy can instantly decide if a screener check should be skipped or not without the need for any additional requests.Addresses #24466