Skip to content

Remove check for commit existence and make it optional #24587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralucapelin merged 1 commit into from
Aug 30, 2022
Merged

Remove check for commit existence and make it optional #24587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions scripts/screener/screener.runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ async function scheduleScreenerBuild(
buildInfo: {
build: string;
branchName: string;
commit: string;
commit?: string;
pullRequest?: string;
},
): Promise<ScheduleScreenerBuildResponse> {
Expand Down Expand Up @@ -78,9 +78,6 @@ export async function screenerRunner(screenerConfig: ScreenerRunnerConfig) {
// https://github.com/screener-io/screener-runner/blob/2a8291fb1b0219c96c8428ea6644678b0763a1a1/src/ci.js#L101
let branchName = process.env.SYSTEM_PULLREQUEST_SOURCEBRANCH || process.env.BUILD_SOURCEBRANCHNAME;

if (!commit) {
throw new Error('SYSTEM_PULLREQUEST_SOURCECOMMITID env variable doesnt exist');
}
if (!branchName) {
throw new Error('SYSTEM_PULLREQUEST_SOURCEBRANCH or BUILD_SOURCEBRANCHNAME env variable doesnt exist');
}
Expand Down