Skip to content

v7 fix: remove explicit readonly semantics from Calendar grid in office-ui-fabric-react package #24601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smhigley merged 2 commits into from
Sep 2, 2022
+7 −2
Merged

v7 fix: remove explicit readonly semantics from Calendar grid in office-ui-fabric-react package #24601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c840910
fix: v7 fabric port: remove explicit readonly semantics from Calendar…
smhigley Aug 30, 2022
4e8f644
Change files
smhigley Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/office-ui-fabric-react-6392d55f-1850-4bee-b31c-a0ff57e7c83f.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: v7 fabric port: remove explicit readonly semantics from Calendar grid",
"packageName": "office-ui-fabric-react",
"email": "sarah.higley@microsoft.com",
"dependentChangeType": "patch"
}
1 change: 0 additions & 1 deletion packages/office-ui-fabric-react/src/components/Calendar/CalendarDay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,6 @@ export class CalendarDay extends React.Component<ICalendarDayProps, ICalendarDay
<FocusZone>
<table
className={css('ms-DatePicker-table', styles.table)}
aria-readonly="true"
aria-multiselectable="false"
aria-labelledby={monthAndYearId}
aria-activedescendant={activeDescendantId}
Expand Down
1 change: 0 additions & 1 deletion packages/office-ui-fabric-react/src/components/Calendar/__snapshots__/Calendar.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ exports[`Calendar Test rendering simplest calendar Renders simple calendar corre
aria-activedescendant="DatePickerDay-active0"
aria-labelledby="DatePickerDay-monthAndYear2"
aria-multiselectable="false"
aria-readonly="true"
className="ms-DatePicker-table"
role="grid"
>
Expand Down