feat(react-dialog): moves backdrop slot from Dialog to DialogSurface#24669
Merged
bsunderhus merged 7 commits intoSep 7, 2022
Merged
Conversation
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 23d731b8da7c1488b339a195d3caadd2c45ce52b (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1263 | 1242 | 5000 | |
| Button | mount | 920 | 931 | 5000 | |
| FluentProvider | mount | 1474 | 1489 | 5000 | |
| FluentProviderWithTheme | mount | 587 | 572 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 537 | 547 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 569 | 586 | 10 | |
| MakeStyles | mount | 1923 | 1943 | 50000 | |
| SpinButton | mount | 2358 | 2343 | 5000 |
bsunderhus
force-pushed
the
react-dialog/move-backdrop-to-dialog-surface
branch
2 times, most recently
from
September 6, 2022 10:57
2ed07db to
e8587b8
Compare
bsunderhus
marked this pull request as ready for review
September 6, 2022 10:57
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 761e10d:
|
bsunderhus
marked this pull request as draft
September 6, 2022 11:58
bsunderhus
force-pushed
the
react-dialog/move-backdrop-to-dialog-surface
branch
from
September 6, 2022 12:03
9eca58e to
c9483b1
Compare
bsunderhus
marked this pull request as ready for review
September 6, 2022 12:11
bsunderhus
force-pushed
the
react-dialog/move-backdrop-to-dialog-surface
branch
from
September 6, 2022 12:17
c9483b1 to
e506f4d
Compare
ling1726
reviewed
Sep 6, 2022
ling1726
reviewed
Sep 6, 2022
ling1726
reviewed
Sep 6, 2022
ling1726
reviewed
Sep 7, 2022
ling1726
reviewed
Sep 7, 2022
ling1726
approved these changes
Sep 7, 2022
…Element.ts Co-authored-by: ling1726 <lingfangao@hotmail.com>
bsunderhus
enabled auto-merge (squash)
September 7, 2022 08:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitting from #24525
Moves
backdropslot fromDialogcomponent toDialogSurface, this will be required to support nativedialogelement with native::backdropat #24525