Skip to content

Textarea/hc bug #24701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sopranopillow merged 2 commits into from
Sep 8, 2022
Merged

Textarea/hc bug #24701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66fabcc
fix: Change filled appearances' normal state's token.
sopranopillow Sep 7, 2022
d8b6b7a
change files
sopranopillow Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-textarea-a60f7be9-9011-4b41-81f6-b700be755b8e.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: Change filled appearances' normal state's token.",
"packageName": "@fluentui/react-textarea",
"email": "esteban.230@hotmail.com",
"dependentChangeType": "patch"
}
13 changes: 9 additions & 4 deletions packages/react-components/react-textarea/src/components/Textarea/useTextareaStyles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,14 +102,17 @@ const useRootStyles = makeStyles({
},
},

filled: {
...shorthands.border(tokens.strokeWidthThin, 'solid', tokens.colorTransparentStroke),
':hover,:focus-within': {
...shorthands.borderColor(tokens.colorTransparentStrokeInteractive),
},
},
'filled-darker': {
backgroundColor: tokens.colorNeutralBackground3,
...shorthands.border(tokens.strokeWidthThin, 'solid', tokens.colorTransparentStrokeInteractive),
},

'filled-lighter': {
backgroundColor: tokens.colorNeutralBackground1,
...shorthands.border(tokens.strokeWidthThin, 'solid', tokens.colorTransparentStrokeInteractive),
},

outline: {
Expand Down Expand Up @@ -217,14 +220,16 @@ const useTextareaResizeStyles = makeStyles({
* Apply styling to the Textarea slots based on the state
*/
export const useTextareaStyles_unstable = (state: TextareaState): TextareaState => {
const disabled = state.textarea.disabled;
const { size, appearance, resize } = state;
const disabled = state.textarea.disabled;
const filled = appearance.startsWith('filled');

const rootStyles = useRootStyles();
state.root.className = mergeClasses(
textareaClassNames.root,
rootStyles.base,
rootStyles[appearance],
filled && rootStyles.filled,
disabled && rootStyles.disabled,
!disabled && rootStyles.interactive,
!disabled && appearance === 'outline' && rootStyles.outlineInteractive,
Expand Down