Skip to content

Fix greyed out legend key contrast ratio #24714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AtishayMsft merged 2 commits into from
Sep 8, 2022
Merged

Fix greyed out legend key contrast ratio #24714

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecb3ccb
fix greyed out legend key contrast ratio
krkshitij Sep 8, 2022
c21725d
add change file
krkshitij Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-charting-d686895a-39e2-4755-a198-862dec13351f.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Fix greyed out legend key contrast ratio",
"packageName": "@fluentui/react-charting",
"email": "kumarkshitij@microsoft.com",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion packages/react-charting/src/components/Legends/Legends.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export const getStyles = (props: ILegendStyleProps): ILegendsStyles => {
...fonts.small,
lineHeight: '16px',
color: theme?.semanticColors.bodyText,

@AtishayMsft AtishayMsft Sep 8, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a change file as well.

@krkshitij krkshitij Sep 8, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

opacity: props.colorOnSelectedState === palette.white ? '0.6' : '',
opacity: props.colorOnSelectedState === palette.white ? '0.67' : '',
},
hoverChange: {
width: '12px',
Expand Down
8 changes: 4 additions & 4 deletions packages/react-charting/src/components/Legends/__snapshots__/Legends.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1578,7 +1578,7 @@ exports[`Legends snapShot testing renders Legends correctly 1`] = `
font-size: 12px;
font-weight: 400;
line-height: 16px;
opacity: 0.6;
opacity: 0.67;
}
>
Legend 17
Expand Down Expand Up @@ -3171,7 +3171,7 @@ exports[`Legends snapShot testing renders allowFocusOnLegends correctly 1`] = `
font-size: 12px;
font-weight: 400;
line-height: 16px;
opacity: 0.6;
opacity: 0.67;
}
>
Legend 17
Expand Down Expand Up @@ -4764,7 +4764,7 @@ exports[`Legends snapShot testing renders canSelectMultipleLegends correctly 1`]
font-size: 12px;
font-weight: 400;
line-height: 16px;
opacity: 0.6;
opacity: 0.67;
}
>
Legend 17
Expand Down Expand Up @@ -6357,7 +6357,7 @@ exports[`Legends snapShot testing renders styles correctly 1`] = `
font-size: 12px;
font-weight: 400;
line-height: 16px;
opacity: 0.6;
opacity: 0.67;
}
>
Legend 17
Expand Down