Skip to content

feat(react-input): Add optional shadow to filled appearances#24730

Merged
sopranopillow merged 5 commits into
microsoft:masterfrom
sopranopillow:input/add-shadows-input
Sep 15, 2022
Merged

feat(react-input): Add optional shadow to filled appearances#24730
sopranopillow merged 5 commits into
microsoft:masterfrom
sopranopillow:input/add-shadows-input

Conversation

@sopranopillow

Copy link
Copy Markdown
Contributor

image

Related Issue(s)

Fixes #24642

@fabricteam

fabricteam commented Sep 8, 2022

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-input
Input
23.598 kB
7.661 kB
23.757 kB
7.704 kB
159 B
43 B
react-spinbutton
SpinButton
43.943 kB
12.382 kB
44.102 kB
12.425 kB
159 B
43 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
187.939 kB
52.05 kB
react-components
react-components: FluentProvider & webLightTheme
33.394 kB
11.007 kB
react-portal-compat
PortalCompatProvider
5.851 kB
1.964 kB
🤖 This report was generated against 5c78472d96502d05a10016d9502eceada4edfd8a

@codesandbox-ci

codesandbox-ci Bot commented Sep 8, 2022

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dba651d:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor

size-auditor Bot commented Sep 8, 2022

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 5c78472d96502d05a10016d9502eceada4edfd8a (build)

@fabricteam

fabricteam commented Sep 8, 2022

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1657 1622 5000
Button mount 1136 1136 5000
FluentProvider mount 1925 1919 5000
FluentProviderWithTheme mount 714 783 10
FluentProviderWithTheme virtual-rerender 664 663 10
FluentProviderWithTheme virtual-rerender-with-unmount 706 713 10
MakeStyles mount 2280 2288 50000
SpinButton mount 3323 3248 5000

Comment thread packages/react-components/react-input/etc/react-input.api.md
@sopranopillow
sopranopillow merged commit 2f46a7a into microsoft:master Sep 15, 2022
@sopranopillow
sopranopillow deleted the input/add-shadows-input branch September 15, 2022 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inputs: Add optional shadows to each component

4 participants