Skip to content

chore(react-aria): improve internal typings #24742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bsunderhus merged 1 commit into from
Sep 9, 2022
Merged

chore(react-aria): improve internal typings #24742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-aria-5aba4f44-2e23-4c1d-810b-dcc2426ae694.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "chore(react-aria): improve internal typings",
"packageName": "@fluentui/react-aria",
"email": "bernardo.sunderhus@gmail.com",
"dependentChangeType": "patch"
}
9 changes: 5 additions & 4 deletions packages/react-components/react-aria/src/hooks/useARIAButton/useARIAButtonProps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { Enter, Space } from '@fluentui/keyboard-keys';
import { useEventCallback } from '@fluentui/react-utilities';
import type { ARIAButtonProps, ARIAButtonResultProps, ARIAButtonType } from './types';
import * as React from 'react';
import type { ARIAButtonElementIntersection, ARIAButtonProps, ARIAButtonResultProps, ARIAButtonType } from './types';

/**
* @internal
Expand Down Expand Up @@ -48,7 +49,7 @@ export function useARIAButtonProps<Type extends ARIAButtonType, Props extends AR

const isDisabled = disabled || disabledFocusable || normalizedARIADisabled;

const handleClick: Props['onClick'] = useEventCallback(ev => {
const handleClick = useEventCallback((ev: React.MouseEvent<ARIAButtonElementIntersection>) => {
if (isDisabled) {
ev.preventDefault();
ev.stopPropagation();
Expand All @@ -57,7 +58,7 @@ export function useARIAButtonProps<Type extends ARIAButtonType, Props extends AR
}
});

const handleKeyDown: Props['onKeyDown'] = useEventCallback(ev => {
const handleKeyDown = useEventCallback((ev: React.KeyboardEvent<ARIAButtonElementIntersection>) => {
onKeyDown?.(ev);

if (ev.isDefaultPrevented()) {
Expand All @@ -84,7 +85,7 @@ export function useARIAButtonProps<Type extends ARIAButtonType, Props extends AR
}
});

const handleKeyUp: Props['onKeyUp'] = useEventCallback(ev => {
const handleKeyUp = useEventCallback((ev: React.KeyboardEvent<ARIAButtonElementIntersection>) => {
onKeyUp?.(ev);

if (ev.isDefaultPrevented()) {
Expand Down