Skip to content

feat(react-select): Adding optional shadows to filled appearances#24801

Closed
sopranopillow wants to merge 3 commits into
microsoft:masterfrom
sopranopillow:input/add-shadows-select
Closed

feat(react-select): Adding optional shadows to filled appearances#24801
sopranopillow wants to merge 3 commits into
microsoft:masterfrom
sopranopillow:input/add-shadows-select

Conversation

@sopranopillow

Copy link
Copy Markdown
Contributor

image

Related Issue(s)

Fixes #24642

@fabricteam

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-select
Select
20.846 kB
7.346 kB
21.005 kB
7.383 kB
159 B
37 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
187.939 kB
52.05 kB
react-components
react-components: FluentProvider & webLightTheme
33.394 kB
11.007 kB
react-portal-compat
PortalCompatProvider
5.851 kB
1.964 kB
🤖 This report was generated against 17b9063802b28bf7f4b1c4d439623819ad8940fa

@codesandbox-ci

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 55edb5b:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor

size-auditor Bot commented Sep 15, 2022

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 17b9063802b28bf7f4b1c4d439623819ad8940fa (build)

@fabricteam

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1676 1608 5000
Button mount 1176 1176 5000
FluentProvider mount 2013 1945 5000
FluentProviderWithTheme mount 723 726 10
FluentProviderWithTheme virtual-rerender 668 682 10
FluentProviderWithTheme virtual-rerender-with-unmount 736 726 10
MakeStyles mount 2301 2335 50000
SpinButton mount 3265 3205 5000

@smhigley smhigley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but same comment as in combobox -- I can't see the shadow at all in the appearance variant example. Do we have an example of where this appearance variant should be used in a way that is still accessible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inputs: Add optional shadows to each component

5 participants