feat(react-select): Adding optional shadows to filled appearances#24801
Closed
sopranopillow wants to merge 3 commits into
Closed
feat(react-select): Adding optional shadows to filled appearances#24801sopranopillow wants to merge 3 commits into
sopranopillow wants to merge 3 commits into
Conversation
Collaborator
📊 Bundle size report
Unchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 55edb5b:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 17b9063802b28bf7f4b1c4d439623819ad8940fa (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1676 | 1608 | 5000 | |
| Button | mount | 1176 | 1176 | 5000 | |
| FluentProvider | mount | 2013 | 1945 | 5000 | |
| FluentProviderWithTheme | mount | 723 | 726 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 668 | 682 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 736 | 726 | 10 | |
| MakeStyles | mount | 2301 | 2335 | 50000 | |
| SpinButton | mount | 3265 | 3205 | 5000 |
5 tasks
khmakoto
approved these changes
Sep 15, 2022
smhigley
approved these changes
Sep 15, 2022
smhigley
left a comment
Contributor
There was a problem hiding this comment.
Approved, but same comment as in combobox -- I can't see the shadow at all in the appearance variant example. Do we have an example of where this appearance variant should be used in a way that is still accessible?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Related Issue(s)
Fixes #24642