feat(react-combobox): Adding optional shadows to filled appearances#24802
Closed
sopranopillow wants to merge 2 commits into
Closed
feat(react-combobox): Adding optional shadows to filled appearances#24802sopranopillow wants to merge 2 commits into
sopranopillow wants to merge 2 commits into
Conversation
msft-fluent-ui-bot
added
Component: Input
Component: Select
Component: Textarea
Collaborator
📊 Bundle size report
Unchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 054a610:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 17b9063802b28bf7f4b1c4d439623819ad8940fa (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1293 | 1319 | 5000 | |
| Button | mount | 882 | 974 | 5000 | |
| FluentProvider | mount | 1566 | 1558 | 5000 | |
| FluentProviderWithTheme | mount | 574 | 633 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 591 | 597 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 548 | 631 | 10 | |
| MakeStyles | mount | 1689 | 1940 | 50000 | |
| SpinButton | mount | 2563 | 2550 | 5000 |
5 tasks
khmakoto
approved these changes
Sep 15, 2022
smhigley
approved these changes
Sep 15, 2022
smhigley
left a comment
smhigley
left a comment
Contributor
There was a problem hiding this comment.
Approving this for react-combobox, but I can't see the shadow at all in the story. Is there a purpose for the shadow, beyond encouranging devs to use the filled appearance variants in a way that doesn't meet contrast requirements?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
Fixes #24642