Skip to content

fix(scripts): v9 release should not include v8 docsite in scope #24809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ling1726 wants to merge 2 commits into from
Closed

fix(scripts): v9 release should not include v8 docsite in scope #24809

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9414c48
fix(runPublished): v9 release should not include v8 docsite
ling1726 Sep 15, 2022
e791e1c
add isConverged back
ling1726 Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions scripts/monorepo/runPublished.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,23 +23,26 @@ const websitePackages = [
'@fluentui/api-docs',
];

const releaseScope = process.env.RELEASE_VNEXT ? 'v9' : 'v8';

@Hotell Hotell Sep 15, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add more docs to this ? there is something for beachbalPackagesScopes but Im not sure its up to date


// Only include the packages that are published daily by beachball, and some website/doc packages
// (which must be built and uploaded with each release). This is similar to "--scope \"!packages/fluentui/*\""
// in the root package.json's publishing-related scripts and will need to be updated if --scope changes.
const beachballPackageScopes = Object.entries(getAllPackageInfo())
.filter(([, { packageJson, packagePath }]) => {
const isNorthstar = /[\\/]fluentui[\\/]/.test(packagePath);

// Northstar has separate release tooling, always ignore northstar
if (isNorthstar) {
return false;
}

const isConverged = isConvergedPackage({ packagePathOrJson: packageJson });
if (process.env.RELEASE_VNEXT && isConverged) {
if (releaseScope === 'v9' && isConverged) {

@Hotell Hotell Sep 15, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we unify this one way or another for both if statements? (release scope check first , isConverged 2nd )
releaseScope === 'v9' && isConverged or isConverged && releaseScope === 'v9'

return packageJson.private !== true;
}

if (!isConverged) {
if (!isConverged && releaseScope === 'v8') {

@Hotell Hotell Sep 15, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (!isConverged && releaseScope === 'v8') {
if (releaseScope === 'v8' && !isConverged) {

// v8 scope
return websitePackages.includes(packageJson.name) || packageJson.private !== true;
}
Expand Down