Skip to content

Set minimum width of 1% for multi stacked horizontal bar chart #24835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AtishayMsft merged 2 commits into from
Sep 20, 2022
Merged

Set minimum width of 1% for multi stacked horizontal bar chart #24835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02fd413
Fix multi stacked bar chart min width
AtishayMsft Sep 16, 2022
2c1e640
Add change file
AtishayMsft Sep 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-charting-3df6df5e-105a-42a8-813e-82c2bb4f5eef.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Fix multi stacked bar chart min width",
"packageName": "@fluentui/react-charting",
"email": "atishay.jain@microsoft.com",
"dependentChangeType": "patch"
}
23 changes: 23 additions & 0 deletions packages/react-charting/src/components/StackedBarChart/MultiStackedBarChart.base.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,22 @@ export class MultiStackedBarChartBase extends React.Component<IMultiStackedBarCh
0,
);

let sumOfPercent = 0;
data.chartData!.map((point: IChartDataPoint, index: number) => {
const pointData = point.data ? point.data : 0;
value = (pointData / total) * 100 ? (pointData / total) * 100 : 0;
if (value < 1 && value !== 0) {
value = 1;
} else if (value > 99 && value !== 100) {
value = 99;
}
sumOfPercent += value;

return sumOfPercent;
});

const scalingRatio = sumOfPercent !== 0 ? sumOfPercent / 100 : 1;

let prevPosition = 0;
let value = 0;

Expand All @@ -154,6 +170,13 @@ export class MultiStackedBarChartBase extends React.Component<IMultiStackedBarCh
prevPosition += value;
}
value = (pointData / total) * 100 ? (pointData / total) * 100 : 0;
if (value < 1 && value !== 0) {
value = 1 / scalingRatio;
} else if (value > 99 && value !== 100) {
value = 99 / scalingRatio;
} else {
value = value / scalingRatio;
}

startingPoint.push(prevPosition);

Expand Down