fix: Nightly releases should use `rm -f` by ling1726 · Pull Request #24877 · microsoft/fluentui

ling1726 · 2022-09-21T05:21:54Z

If there are no changefiles nightly release fails because there is no folder change/ use rm -f to force delete the directory so it doesn't fail if the folder doesn't exist (which can happen after official release)

If there are no changefiles nightly release fails because there is no folder `change/` use `rm -f` to force delete the directory so it doesn't fail if the folder doesn't exist

codesandbox-ci · 2022-09-21T05:32:06Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b588e7f:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

size-auditor · 2022-09-21T05:34:20Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: cef8c1c773366a88759aa44e6a7aaa63ff7ac0df (build)

fabricteam · 2022-09-21T05:35:37Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1262	1276	5000
Button	mount	928	939	5000
FluentProvider	mount	1476	1501	5000
FluentProviderWithTheme	mount	580	584	10
FluentProviderWithTheme	virtual-rerender	531	546	10
FluentProviderWithTheme	virtual-rerender-with-unmount	578	572	10
MakeStyles	mount	1926	1904	50000
SpinButton	mount	2319	2327	5000

fabricteam · 2022-09-21T05:40:10Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`554 B` `348 B`
`priority-overflow` createOverflowManager	`2.936 kB` `1.212 kB`
`react-accordion` Accordion (including children components)	`78.914 kB` `24.06 kB`
`react-alert` Alert	`83.511 kB` `20.921 kB`
`react-avatar` Avatar	`48.381 kB` `13.696 kB`
`react-avatar` AvatarGroup	`14.95 kB` `5.989 kB`
`react-avatar` AvatarGroupItem	`68.349 kB` `19.039 kB`
`react-badge` Badge	`22.6 kB` `7.205 kB`
`react-badge` CounterBadge	`23.503 kB` `7.497 kB`
`react-badge` PresenceBadge	`24.05 kB` `7.067 kB`
`react-button` Button	`36.119 kB` `9.647 kB`
`react-button` CompoundButton	`43.144 kB` `10.86 kB`
`react-button` MenuButton	`38.813 kB` `10.551 kB`
`react-button` SplitButton	`46.228 kB` `11.933 kB`
`react-button` ToggleButton	`51.888 kB` `11.127 kB`
`react-card` Card - All	`67.002 kB` `19.261 kB`
`react-card` Card	`62.684 kB` `18.177 kB`
`react-card` CardFooter	`8.561 kB` `3.601 kB`
`react-card` CardHeader	`9.604 kB` `3.94 kB`
`react-card` CardPreview	`8.662 kB` `3.656 kB`
`react-combobox` Combobox (including child components)	`74.636 kB` `24.186 kB`
`react-combobox` Dropdown (including child components)	`74.236 kB` `24.086 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`188.672 kB` `52.359 kB`
`react-components` react-components: FluentProvider & webLightTheme	`33.394 kB` `11.007 kB`
`react-dialog` Dialog (including children components)	`81.199 kB` `24.196 kB`
`react-divider` Divider	`16.459 kB` `5.902 kB`
`react-image` Image	`10.78 kB` `4.264 kB`
`react-input` Input	`23.757 kB` `7.704 kB`
`react-label` Label	`9.338 kB` `3.86 kB`
`react-link` Link	`11.784 kB` `4.867 kB`
`react-menu` Menu (including children components)	`116.572 kB` `35.778 kB`
`react-menu` Menu (including selectable components)	`119.641 kB` `36.297 kB`
`react-overflow` hooks only	`10.685 kB` `4.104 kB`
`react-popover` Popover	`102.963 kB` `31.553 kB`
`react-portal` Portal	`10.576 kB` `3.875 kB`
`react-portal-compat` PortalCompatProvider	`5.851 kB` `1.964 kB`
`react-positioning` usePositioning	`19.7 kB` `7.404 kB`
`react-provider` FluentProvider	`15.755 kB` `5.883 kB`
`react-radio` Radio	`35.56 kB` `11.929 kB`
`react-radio` RadioGroup	`14.248 kB` `5.7 kB`
`react-select` Select	`20.846 kB` `7.346 kB`
`react-slider` Slider	`31.526 kB` `10.046 kB`
`react-spinbutton` SpinButton	`44.102 kB` `12.425 kB`
`react-spinner` Spinner	`19.977 kB` `6.438 kB`
`react-switch` Switch	`32.097 kB` `10.27 kB`
`react-text` Text - Default	`11.782 kB` `4.605 kB`
`react-text` Text - Wrappers	`15.092 kB` `5.044 kB`
`react-textarea` Textarea	`25.013 kB` `8.133 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`29.65 kB` `6.444 kB`
`react-theme` Teams: Light theme	`17.486 kB` `5.057 kB`
`react-tooltip` Tooltip	`41.535 kB` `14.639 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against cef8c1c773366a88759aa44e6a7aaa63ff7ac0df}

fabricteam · 2022-09-21T05:43:42Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
ButtonMinimalPerf.default	138	121	1.14:1
TreeWith60ListItems.default	140	128	1.09:1
ReactionMinimalPerf.default	319	298	1.07:1
BoxMinimalPerf.default	284	267	1.06:1
AttachmentSlotsPerf.default	947	902	1.05:1
FlexMinimalPerf.default	241	230	1.05:1
AccordionMinimalPerf.default	120	115	1.04:1
AvatarMinimalPerf.default	157	151	1.04:1
DividerMinimalPerf.default	297	286	1.04:1
LoaderMinimalPerf.default	569	545	1.04:1
PortalMinimalPerf.default	141	136	1.04:1
TableMinimalPerf.default	334	322	1.04:1
DropdownManyItemsPerf.default	556	539	1.03:1
GridMinimalPerf.default	279	272	1.03:1
HeaderMinimalPerf.default	298	288	1.03:1
LabelMinimalPerf.default	319	311	1.03:1
SegmentMinimalPerf.default	281	274	1.03:1
SkeletonMinimalPerf.default	282	274	1.03:1
TreeMinimalPerf.default	674	657	1.03:1
AttachmentMinimalPerf.default	123	120	1.02:1
CarouselMinimalPerf.default	388	380	1.02:1
ChatMinimalPerf.default	598	589	1.02:1
HeaderSlotsPerf.default	632	619	1.02:1
ItemLayoutMinimalPerf.default	973	955	1.02:1
ButtonOverridesMissPerf.default	1091	1085	1.01:1
CardMinimalPerf.default	425	422	1.01:1
ChatDuplicateMessagesPerf.default	231	229	1.01:1
EmbedMinimalPerf.default	3041	3013	1.01:1
MenuMinimalPerf.default	695	689	1.01:1
MenuButtonMinimalPerf.default	1409	1397	1.01:1
ProviderMergeThemesPerf.default	1063	1054	1.01:1
RadioGroupMinimalPerf.default	364	360	1.01:1
RefMinimalPerf.default	182	180	1.01:1
StatusMinimalPerf.default	556	552	1.01:1
CustomToolbarPrototype.default	2250	2234	1.01:1
ToolbarMinimalPerf.default	763	753	1.01:1
AlertMinimalPerf.default	215	216	1:1
CheckboxMinimalPerf.default	1723	1728	1:1
DialogMinimalPerf.default	641	643	1:1
DropdownMinimalPerf.default	2245	2236	1:1
InputMinimalPerf.default	940	941	1:1
ListMinimalPerf.default	429	429	1:1
ListNestedPerf.default	459	460	1:1
ListWith60ListItems.default	505	505	1:1
RosterPerf.default	1774	1768	1:1
SliderMinimalPerf.default	1331	1336	1:1
SplitButtonMinimalPerf.default	3616	3609	1:1
TableManyItemsPerf.default	1547	1552	1:1
VideoMinimalPerf.default	576	577	1:1
ButtonSlotsPerf.default	446	452	0.99:1
DatepickerMinimalPerf.default	4768	4831	0.99:1
LayoutMinimalPerf.default	285	289	0.99:1
PopupMinimalPerf.default	519	523	0.99:1
ProviderMinimalPerf.default	326	328	0.99:1
TextAreaMinimalPerf.default	389	391	0.99:1
TooltipMinimalPerf.default	1894	1904	0.99:1
AnimationMinimalPerf.default	427	437	0.98:1
FormMinimalPerf.default	300	305	0.98:1
ListCommonPerf.default	521	532	0.98:1
ImageMinimalPerf.default	316	325	0.97:1
TextMinimalPerf.default	276	284	0.97:1
ChatWithPopoverPerf.default	290	303	0.96:1
IconMinimalPerf.default	525	558	0.94:1

fabricteam · 2022-09-21T05:56:59Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	1207	1183	5000
Breadcrumb	mount	2794	2738	1000
Checkbox	mount	2647	2646	5000
CheckboxBase	mount	2371	2385	5000
ChoiceGroup	mount	4171	4270	5000
ComboBox	mount	1175	1172	1000
CommandBar	mount	9284	9220	1000
ContextualMenu	mount	10201	10221	1000
DefaultButton	mount	1343	1383	5000
DetailsRow	mount	3385	3359	5000
DetailsRowFast	mount	3345	3369	5000
DetailsRowNoStyles	mount	3225	3221	5000
Dialog	mount	2955	2974	1000
DocumentCardTitle	mount	582	585	1000
Dropdown	mount	3186	3156	5000
FocusTrapZone	mount	1939	1962	5000
FocusZone	mount	1931	1899	5000
GroupedList	mount	48046	52769	2
GroupedList	virtual-rerender	22909	22663	2
GroupedList	virtual-rerender-with-unmount	81561	81979	2
GroupedListV2	mount	559	551	2
GroupedListV2	virtual-rerender	517	529	2
GroupedListV2	virtual-rerender-with-unmount	548	557	2
IconButton	mount	1790	1802	5000
Label	mount	742	740	5000
Layer	mount	4081	4098	5000
Link	mount	867	844	5000
MenuButton	mount	1629	1621	5000
MessageBar	mount	2310	2307	5000
Nav	mount	3080	3097	1000
OverflowSet	mount	1406	1433	5000
Panel	mount	2472	2475	1000
Persona	mount	1265	1242	1000
Pivot	mount	1518	1514	1000
PrimaryButton	mount	1473	1492	5000
Rating	mount	6993	6996	5000
SearchBox	mount	1486	1521	5000
Shimmer	mount	2897	2917	5000
Slider	mount	2097	2095	5000
SpinButton	mount	4266	4266	5000
Spinner	mount	817	837	5000
SplitButton	mount	2829	2823	5000
Stack	mount	880	897	5000
StackWithIntrinsicChildren	mount	2209	2242	5000
StackWithTextChildren	mount	4916	4884	5000
SwatchColorPicker	mount	10351	9482	5000
TagPicker	mount	2332	2363	5000
TeachingBubble	mount	74638	74537	5000
Text	mount	816	820	5000
TextField	mount	1551	1545	5000
ThemeProvider	mount	1425	1440	5000
ThemeProvider	virtual-rerender	1127	1140	5000
ThemeProvider	virtual-rerender-with-unmount	1983	1990	5000
Toggle	mount	1142	1135	5000
buttonNative	mount	531	542	5000

ling1726 · 2022-09-21T12:36:46Z

Changes moved to #24850

fix: Nightly releases should use rm -f

b588e7f

If there are no changefiles nightly release fails because there is no folder `change/` use `rm -f` to force delete the directory so it doesn't fail if the folder doesn't exist

ling1726 requested a review from a team as a code owner September 21, 2022 05:21

msft-fluent-ui-bot assigned tomi-msft Sep 21, 2022

ling1726 enabled auto-merge (squash) September 21, 2022 05:22

github-actions Bot added this to the September Project Cycle Q1 2022 milestone Sep 21, 2022

ling1726 closed this Sep 21, 2022

auto-merge was automatically disabled September 21, 2022 12:36
Pull request was closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Nightly releases should use `rm -f`#24877

fix: Nightly releases should use `rm -f`#24877
ling1726 wants to merge 1 commit into
microsoft:masterfrom
ling1726:fix/nightly-force-delete

ling1726 commented Sep 21, 2022 •

edited

Loading

Uh oh!

codesandbox-ci Bot commented Sep 21, 2022

Uh oh!

size-auditor Bot commented Sep 21, 2022

Uh oh!

fabricteam commented Sep 21, 2022

Uh oh!

fabricteam commented Sep 21, 2022

Uh oh!

fabricteam commented Sep 21, 2022

Uh oh!

fabricteam commented Sep 21, 2022

Uh oh!

ling1726 commented Sep 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

ling1726 commented Sep 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codesandbox-ci Bot commented Sep 21, 2022

Uh oh!

size-auditor Bot commented Sep 21, 2022

Asset size changes

Uh oh!

fabricteam commented Sep 21, 2022

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented Sep 21, 2022

📊 Bundle size report

Uh oh!

fabricteam commented Sep 21, 2022

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Sep 21, 2022

Perf Analysis (@fluentui/react)

Uh oh!

ling1726 commented Sep 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ling1726 commented Sep 21, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

Perf Analysis (`@fluentui/react-northstar`)

Perf Analysis (`@fluentui/react`)