Skip to content

fix: Dropdown icon layout with no placeholder/value #25049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smhigley merged 2 commits into from
Oct 6, 2022
Merged

fix: Dropdown icon layout with no placeholder/value #25049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4add8c
fix: Dropdown arrow icon layout when no placeholder or value is present
smhigley Sep 29, 2022
c872f1f
change file
smhigley Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-combobox-d1ed182f-ed98-446f-8cb6-4c9de248b0ff.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "fix: Dropdown arrow icon layout when no placeholder or value is present",
"packageName": "@fluentui/react-combobox",
"email": "sarah.higley@microsoft.com",
"dependentChangeType": "patch"
}
4 changes: 3 additions & 1 deletion packages/react-components/react-combobox/src/components/Dropdown/useDropdownStyles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ const useStyles = makeStyles({
cursor: 'pointer',
display: 'grid',
fontFamily: tokens.fontFamilyBase,
gridTemplateColumns: '1fr auto',
gridTemplateColumns: '[content] 1fr [icon] auto [end]',
justifyContent: 'space-between',
textAlign: 'left',
width: '100%',
Expand Down Expand Up @@ -167,6 +167,8 @@ const useIconStyles = makeStyles({
color: tokens.colorNeutralStrokeAccessible,
display: 'block',
fontSize: tokens.fontSizeBase500,
gridColumnStart: 'icon',

@GeoffCoxMSFT GeoffCoxMSFT Oct 5, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need a vr-test for this case?

@smhigley smhigley Oct 6, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! I need to add vr-tests for Dropdown in general, so I'll put those in a separate PR 👍

gridColumnEnd: 'end',

// the SVG must have display: block for accurate positioning
// otherwise an extra inline space is inserted after the svg element
Expand Down