Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
59f642f
Move button and stack stories into migration shim component
GeoffCoxMSFT Oct 6, 2022
f376b0d
Update packages/react-migration-v8-v9/src/components/Button/ActionBut…
GeoffCoxMSFT Oct 6, 2022
06f5100
Update packages/react-migration-v8-v9/src/components/Button/ButtonShi…
GeoffCoxMSFT Oct 6, 2022
1ec524f
Update packages/react-migration-v8-v9/src/components/Button/CompoundB…
GeoffCoxMSFT Oct 6, 2022
e9afb45
Update packages/react-migration-v8-v9/src/components/Button/DefaultBu…
GeoffCoxMSFT Oct 6, 2022
d22c8ca
Update packages/react-migration-v8-v9/src/stories/ActionButtonShim/in…
GeoffCoxMSFT Oct 6, 2022
7451ec7
Update packages/react-migration-v8-v9/src/stories/CommandButtonShim/i…
GeoffCoxMSFT Oct 6, 2022
22d6dfc
Update packages/react-migration-v8-v9/src/stories/MenuButtonShim/inde…
GeoffCoxMSFT Oct 6, 2022
8e440b3
Update packages/react-migration-v8-v9/src/stories/ToggleButtonShim/in…
GeoffCoxMSFT Oct 6, 2022
7da6a48
Update packages/react-migration-v8-v9/src/stories/Stack/index.stories…
GeoffCoxMSFT Oct 6, 2022
e0db355
Improved readme
GeoffCoxMSFT Oct 6, 2022
2c0258a
Update packages/react-migration-v8-v9/src/components/Button/MenuButto…
GeoffCoxMSFT Oct 6, 2022
cd44785
Apply suggestions from code review
GeoffCoxMSFT Oct 6, 2022
0cf3382
Apply suggestions from code review
GeoffCoxMSFT Oct 6, 2022
2e3bc29
Apply suggestions from code review
GeoffCoxMSFT Oct 6, 2022
8755719
Update packages/react-migration-v8-v9/src/components/Theme/themeDupli…
GeoffCoxMSFT Oct 6, 2022
b12a235
Fix typo from committed suggestion
GeoffCoxMSFT Oct 6, 2022
a6c7924
PR build fixes
GeoffCoxMSFT Oct 6, 2022
a0c8828
trying to fix in ci build
GeoffCoxMSFT Oct 6, 2022
de2f58c
Fixing types path for api extraction
GeoffCoxMSFT Oct 7, 2022
52ddd5a
Fixed lint issues with imports
GeoffCoxMSFT Oct 7, 2022
4b39910
More lint fixes
GeoffCoxMSFT Oct 7, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ packages/react-components/react-progress @microsoft/cxe-red @tomi-msft
packages/react-components/react-persona @microsoft/cxe-red @sopranopillow
packages/react-components/react-avatar-context @microsoft/teams-prg
packages/react-components/react-infobutton @microsoft/cxe-red @sopranopillow
packages/react-migration-v8-v9 @microsoft/cxe-coastal @geoffcoxmsft
# <%= NX-CODEOWNER-PLACEHOLDER %>


Expand Down
1 change: 1 addition & 0 deletions apps/public-docsite-v9/.storybook/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ module.exports = /** @type {Omit<import('../../../.storybook/main'), 'typescript
'../src/**/*.stories.mdx',
'../src/**/*.stories.@(ts|tsx)',
...utils.getVnextStories(),
'../../../packages/react-migration-v8-v9/src/**/@(index.stories.@(ts|tsx)|*.stories.mdx)',
],
staticDirs: ['../public'],
addons: [...rootMain.addons],
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Meta } from '@storybook/addon-docs';
import { ButtonShimExamples } from './ButtonShimExamples.tsx';

<Meta title="Concepts/Migration/from v8/Components/Button Migration" />

Expand Down Expand Up @@ -71,18 +70,3 @@ To migrate a button replace the v8 usage with the corresponding v9 button varian
| theme | (use FluentProvider) |
| toggle | (use ToggleButton) |
| uniqueId | HTML key |

## Button Shims

The button shim components accept v8 `IButtonProps` and render v9 buttons.
Shims are useful when you have a large number of usage instances, want to render v9 components, and do not have time
or resources to update every instance.

Prefer to migrate your code to use v9 buttons if possible rather than take a use shims.
Shim depend on both v8 and v9 so may prevent bundle size optimizations.

You can find the button shims in the Fluent UI React repository here [apps/public-docsite-v9/src/shims/ButtonShim.tsx](https://github.com/microsoft/fluentui/blob/master/apps/public-docsite-v9/src/shims/ButtonShim.tsx)

<Canvas>
<ButtonShimExamples />
</Canvas>

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading