Skip to content

fix: The Tooltip should not hide if it gets keyboard focus #25138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
behowell merged 2 commits into from
Oct 7, 2022
Merged

fix: The Tooltip should not hide if it gets keyboard focus #25138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b2c317
fix: The Tooltip should not hide if it gets keyboard focus
behowell Oct 7, 2022
ed1c0fe
Fix comment
behowell Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-tooltip-1a523606-fad3-4e83-bd04-c3e3645d474a.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: The Tooltip should not hide if it gets keyboard focus",
"packageName": "@fluentui/react-tooltip",
"email": "behowell@microsoft.com",
"dependentChangeType": "patch"
}
6 changes: 4 additions & 2 deletions packages/react-components/react-tooltip/src/components/Tooltip/useTooltip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,10 +195,12 @@ export const useTooltip_unstable = (props: TooltipProps): TooltipState => {
[setDelayTimeout, setVisible, state.hideDelay, targetDocument],
);

// Cancel the hide timer when the pointer enters the tooltip, and restart it when the mouse leaves.
// This keeps the tooltip visible when the pointer is moved over it.
// Cancel the hide timer when the mouse or focus enters the tooltip, and restart it when the mouse or focus leaves.
// This keeps the tooltip visible when the mouse is moved over it, or it has focus within.
state.content.onPointerEnter = mergeCallbacks(state.content.onPointerEnter, clearDelayTimeout);
state.content.onPointerLeave = mergeCallbacks(state.content.onPointerLeave, onLeaveTrigger);
state.content.onFocus = mergeCallbacks(state.content.onFocus, clearDelayTimeout);
state.content.onBlur = mergeCallbacks(state.content.onBlur, onLeaveTrigger);

const child = getTriggerChild(children);

Expand Down