Skip to content

chore(global-context): migrate to new package structure #25341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TristanWatanabe merged 3 commits into from
Oct 24, 2022
Merged

chore(global-context): migrate to new package structure #25341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2fbdc7
chore: run migration generator and manually move cypress file to corr…
TristanWatanabe Oct 17, 2022
185fd39
fix: linting errors addressed
TristanWatanabe Oct 17, 2022
a4f4d36
Change File
TristanWatanabe Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-global-context-3a76592d-05b4-4b6e-a538-86abd33e1d4c.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "chore: Migrate to new package structure.",
"packageName": "@fluentui/global-context",
"email": "tristan.watanabe@gmail.com",
"dependentChangeType": "none"
}
5 changes: 3 additions & 2 deletions packages/react-components/global-context/.npmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@
bundle-size/
config/
coverage/
e2e/
docs/
etc/
node_modules/
src/
stories/
dist/types/
temp/
__fixtures__
Expand All @@ -16,7 +17,7 @@ __tests__
*.api.json
*.log
*.spec.*
*.stories.*
*.cy.*
*.test.*
*.yml

Expand Down
10 changes: 5 additions & 5 deletions ...global-context/e2e/global-context.e2e.tsx → .../global-context/src/global-context.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { createContext, createContextSelector } from '@fluentui/global-context';
import { SYMBOL_NAMESPACE } from '../src/global-context';
import { SYMBOL_NAMESPACE as CONTEXT_SELECTOR_SYMBOL_NAMESPACE } from '../src/global-context-selector';
import { SYMBOL_NAMESPACE } from './global-context';
import { SYMBOL_NAMESPACE as CONTEXT_SELECTOR_SYMBOL_NAMESPACE } from './global-context-selector';

function cleanWindowSymbols(namespace: string) {
getGlobalContextSymbols(namespace).forEach(sym => {
Expand Down Expand Up @@ -28,13 +28,13 @@ describe('createContext', () => {
beforeEach(() => cleanWindowSymbols(SYMBOL_NAMESPACE));

it('should create context on window', () => {
const MyContext = createContext({}, 'MyContext', 'package', '9.0.0');
const MyContext = createContext(undefined, 'MyContext', 'package', '9.0.0');
expect(getWindowProperty(getGlobalContextSymbols(SYMBOL_NAMESPACE)[0])).equals(MyContext);
});

it('should create single context', () => {
const MyContext = createContext({}, 'MyContext', 'package', '9.0.0');
const MyContext2 = createContext({}, 'MyContext', 'package', '9.0.0');
const MyContext = createContext(undefined, 'MyContext', 'package', '9.0.0');

@TristanWatanabe TristanWatanabe Oct 21, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes linting error: error Invalid default value for context declaration, default value should be undefined @fluentui/no-context-default-value

const MyContext2 = createContext(undefined, 'MyContext', 'package', '9.0.0');

expect(getGlobalContextSymbols(SYMBOL_NAMESPACE).length).equals(1);
expect(getWindowProperty(getGlobalContextSymbols(SYMBOL_NAMESPACE)[0])).equals(MyContext);
Expand Down
4 changes: 2 additions & 2 deletions ...mponents/global-context/e2e/tsconfig.json → ...omponents/global-context/tsconfig.cy.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"extends": "../tsconfig.json",
"extends": "./tsconfig.json",
"compilerOptions": {
"isolatedModules": false,
"types": ["node", "cypress", "cypress-storybook/cypress", "cypress-real-events"],
"lib": ["ES2019", "dom"]
},
"include": ["**/*.ts", "**/*.tsx"]
"include": ["**/*.cy.ts", "**/*.cy.tsx"]
}
2 changes: 1 addition & 1 deletion packages/react-components/global-context/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"path": "./tsconfig.spec.json"
},
{
"path": "./e2e/tsconfig.json"
"path": "./tsconfig.cy.json"
}
]
}
2 changes: 1 addition & 1 deletion packages/react-components/global-context/tsconfig.lib.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@
"inlineSources": true,
"types": ["static-assets", "environment", "node"]
},
"exclude": ["**/*.spec.ts", "**/*.spec.tsx", "**/*.test.ts", "**/*.test.tsx"],
"exclude": ["**/*.spec.ts", "**/*.spec.tsx", "**/*.test.ts", "**/*.test.tsx", "**/*.cy.ts", "**/*.cy.tsx"],
"include": ["./src/**/*.ts", "./src/**/*.tsx"]
}
10 changes: 9 additions & 1 deletion packages/react-components/global-context/tsconfig.spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,13 @@
"outDir": "dist",
"types": ["jest", "node"]
},
"include": ["**/*.spec.ts", "**/*.spec.tsx", "**/*.test.ts", "**/*.test.tsx", "**/*.d.ts"]
"include": [
"**/*.spec.ts",
"**/*.spec.tsx",
"**/*.test.ts",
"**/*.test.tsx",
"**/*.d.ts",
"./src/testing/**/*.ts",
"./src/testing/**/*.tsx"
]
}