fix: Pressed and Hover states for toolbar buttons#25835
Merged
Conversation
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 1bff9a3148961667fe516b46fead5798db794ae6 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Persona | mount | 513 | 2780 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1262 | 1291 | 5000 | |
| Button | mount | 912 | 908 | 5000 | |
| FluentProvider | mount | 1501 | 1507 | 5000 | |
| FluentProviderWithTheme | mount | 573 | 576 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 543 | 536 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 569 | 572 | 10 | |
| MakeStyles | mount | 1960 | 1946 | 50000 | |
| Persona | mount | 513 | 2780 | 5000 | Possible regression |
| SpinButton | mount | 2329 | 2375 | 5000 |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cbcd80c:
|
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
chpalac
force-pushed
the
fix/pressed-hover-buttons
branch
from
November 30, 2022 13:21
fde6e6a to
1c3442b
Compare
Contributor
Author
|
@ling1726 Does this one looks good? |
ling1726
approved these changes
Dec 2, 2022
chpalac
enabled auto-merge (squash)
December 2, 2022 12:02
ling1726
reviewed
Dec 2, 2022
auto-merge was automatically disabled
December 2, 2022 13:19
Pull request was closed
chpalac
force-pushed
the
fix/pressed-hover-buttons
branch
from
December 2, 2022 13:19
cbcd80c to
1bff9a3
Compare
chpalac
enabled auto-merge (squash)
December 2, 2022 13:28
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Dec 2, 2022
* master: fix: Pressed and Hover states for toolbar buttons (microsoft#25835) feat: add large size for toolbar (microsoft#25830) applying package updates adding perf test for Persona (microsoft#25863) fix: Fixing Slider's programmatic focus (microsoft#25869) chore(v0 docs): Add storybook stories that reference docsite examples for 1JS VR tool migration (microsoft#25663) fix: Respecting user-provided ids in ComboBox options (microsoft#25867) refactor(scripts): more domain boundaries encapsulation (microsoft#25851) docs: add documentation about how to migrate V0 createSvgIcon (microsoft#25828) support cross story linking and create example in Menu story (microsoft#25850)
Hotell
pushed a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
* chore: update default button appearance for toolbar * chore: add changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes: #25802
The correct default appearance from
react-buttonto be used forToolbarButtonis the subtle one which will respect thepressedandhoverstates.