Skip to content

fix: v8 ComboBox button is no longer aria-hidden by default #26050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smhigley merged 3 commits into from
Dec 22, 2022
Merged

fix: v8 ComboBox button is no longer aria-hidden by default #26050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2479bb5
fix: ComboBox button is not aria-hidden by default
smhigley Dec 19, 2022
a3a7878
change file
smhigley Dec 19, 2022
872874a
update experiments snapshot
smhigley Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-b2a0ebef-487f-495f-b9b6-e90e361cb18b.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: ComboBox button is not aria-hidden by default",
"packageName": "@fluentui/react",
"email": "sarah.higley@microsoft.com",
"dependentChangeType": "patch"
}
1 change: 0 additions & 1 deletion packages/react-experiments/src/components/Pagination/__snapshots__/Pagination.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1585,7 +1585,6 @@ exports[`Pagination render comboBox Pagination correctly 1`] = `
value="1"
/>
<button
aria-hidden={true}
className=
ms-Button
ms-Button--icon
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/components/ComboBox/ComboBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,7 +570,7 @@ class ComboBoxInternal extends React.Component<IComboBoxInternalProps, IComboBox
required,
errorMessage,
buttonIconProps,
isButtonAriaHidden = true,
isButtonAriaHidden,
title,
placeholder: placeholderProp,
tabIndex,
Expand Down
7 changes: 3 additions & 4 deletions packages/react/src/components/ComboBox/ComboBox.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,10 +246,9 @@ export interface IComboBoxProps
dropdownMaxWidth?: number;

/**
* Whether to hide the ComboBox's caret (expand) button element from screen readers. This is true
* (hidden) by default because all functionality is handled by the input element, and the arrow
* button is only meant to be decorative.
* @defaultvalue true
* Whether to hide the ComboBox's caret (expand) button element from screen readers. This is false
* (exposed to AT) by default because Android Talkback cannot otherwise expand the combobox.
* @defaultvalue false
*/
isButtonAriaHidden?: boolean;

Expand Down
4 changes: 0 additions & 4 deletions packages/react/src/components/ComboBox/__snapshots__/ComboBox.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,6 @@ exports[`ComboBox Renders correctly 1`] = `
value="testValue"
/>
<button
aria-hidden="true"
class=
ms-Button
ms-Button--icon
Expand Down Expand Up @@ -533,7 +532,6 @@ exports[`ComboBox Renders correctly when open 1`] = `
value="Option 2"
/>
<button
aria-hidden="true"
class=
ms-Button
ms-Button--icon
Expand Down Expand Up @@ -1302,7 +1300,6 @@ exports[`ComboBox Renders correctly when opened in multi-select mode 1`] = `
value=""
/>
<button
aria-hidden="true"
class=
ms-Button
ms-Button--icon
Expand Down Expand Up @@ -2193,7 +2190,6 @@ exports[`ComboBox renders with a Keytip correctly 1`] = `
value=""
/>
<button
aria-hidden="true"
class=
ms-Button
ms-Button--icon
Expand Down