chore: set @fluentui/react-storybook-addon dependency to a pinned version in various packages#26074
Merged
TristanWatanabe merged 2 commits intoDec 27, 2022
Conversation
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 0dced6be8495f5341e09d8e0c5af7d20d9869b48 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1318 | 1313 | 5000 | |
| Button | mount | 938 | 835 | 5000 | |
| FluentProvider | mount | 1478 | 1505 | 5000 | |
| FluentProviderWithTheme | mount | 615 | 633 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 597 | 587 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 630 | 623 | 10 | |
| MakeStyles | mount | 1910 | 1886 | 50000 | |
| Persona | mount | 2838 | 2943 | 5000 | |
| SpinButton | mount | 2437 | 2474 | 5000 |
Collaborator
📊 Bundle size reportUnchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ace0da5:
|
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
TristanWatanabe
marked this pull request as ready for review
December 22, 2022 03:50
Contributor
|
|
Member
Author
Thats a good point, what do you think @Hotell? |
Hotell
approved these changes
Dec 23, 2022
q1b
pushed a commit
to q1b/fluentui
that referenced
this pull request
Jan 24, 2023
…sion in various packages (microsoft#26074)
Hotell
pushed a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
…sion in various packages (microsoft#26074)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
@fluentui/react-storybook-addondev dependency to a pinned version in v9, v9 docsite and v9 vr-tests packages.@fluentui/react-storybook-addonis still inprereleaseand thus having it set as a caret can lead to non-deterministic resolutions.Related Issue(s)