chore(scripts): apply single version policy on scripts/package.json devDependencies - #26108
Merged
Hotell merged 6 commits intoDec 28, 2022
Merged
Conversation
Hotell
changed the title
Hotell
commented
Dec 27, 2022
| "react-vis": "1.11.7", | ||
| "read-pkg-up": "7.0.1", | ||
| "replace-in-file": "6.1.0", | ||
| "resolve": "1.22.0", |
Contributor
Author
There was a problem hiding this comment.
todo: remove after #26100
Suggested change
| "resolve": "1.22.0", |
Asset size changes
Baseline commit: 20221afa1c8dde9afe17a278ddcc0a8a9a4817e2 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1637 | 1635 | 5000 | |
| Button | mount | 1156 | 1185 | 5000 | |
| FluentProvider | mount | 1931 | 1974 | 5000 | |
| FluentProviderWithTheme | mount | 802 | 779 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 725 | 735 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 773 | 787 | 10 | |
| MakeStyles | mount | 2375 | 2357 | 50000 | |
| Persona | mount | 3773 | 3690 | 5000 | |
| SpinButton | mount | 3126 | 3086 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e167ebb:
|
….json devDependencies
…package.json devDependencies
Collaborator
🕵 fluentuiv8 Open the Visual Regressions report to inspect the 1 screenshots✅ There was 0 screenshots added, 0 screenshots removed, 1044 screenshots unchanged, 0 screenshots with different dimensions and 1 screenshots with visible difference. unknown 1 screenshots
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 1415 | 1433 | 5000 | |
| Breadcrumb | mount | 3514 | 3457 | 1000 | |
| Checkbox | mount | 3094 | 3119 | 5000 | |
| CheckboxBase | mount | 2786 | 2799 | 5000 | |
| ChoiceGroup | mount | 5202 | 5258 | 5000 | |
| ComboBox | mount | 1488 | 1540 | 1000 | |
| CommandBar | mount | 11312 | 11386 | 1000 | |
| ContextualMenu | mount | 13051 | 12909 | 1000 | |
| DefaultButton | mount | 1632 | 1671 | 5000 | |
| DetailsRow | mount | 4372 | 4340 | 5000 | |
| DetailsRowFast | mount | 4377 | 4322 | 5000 | |
| DetailsRowNoStyles | mount | 4171 | 4146 | 5000 | |
| Dialog | mount | 3670 | 3736 | 1000 | |
| DocumentCardTitle | mount | 707 | 699 | 1000 | |
| Dropdown | mount | 3854 | 3888 | 5000 | |
| FocusTrapZone | mount | 2377 | 2400 | 5000 | |
| FocusZone | mount | 2345 | 2331 | 5000 | |
| GroupedList | mount | 2226 | 2539 | 2 | |
| GroupedList | virtual-rerender | 1367 | 1358 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 2027 | 1976 | 2 | |
| GroupedListV2 | mount | 691 | 669 | 2 | |
| GroupedListV2 | virtual-rerender | 653 | 660 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 690 | 675 | 2 | |
| IconButton | mount | 2251 | 2297 | 5000 | |
| Label | mount | 873 | 880 | 5000 | |
| Layer | mount | 5154 | 5100 | 5000 | |
| Link | mount | 991 | 992 | 5000 | |
| MenuButton | mount | 2009 | 2043 | 5000 | |
| MessageBar | mount | 2758 | 2760 | 5000 | |
| Nav | mount | 3824 | 3911 | 1000 | |
| OverflowSet | mount | 1639 | 1603 | 5000 | |
| Panel | mount | 3027 | 3053 | 1000 | |
| Persona | mount | 1555 | 1555 | 1000 | |
| Pivot | mount | 1928 | 1969 | 1000 | |
| PrimaryButton | mount | 1789 | 1819 | 5000 | |
| Rating | mount | 8438 | 8339 | 5000 | |
| SearchBox | mount | 1787 | 1789 | 5000 | |
| Shimmer | mount | 3450 | 3380 | 5000 | |
| Slider | mount | 2503 | 2548 | 5000 | |
| SpinButton | mount | 5535 | 5717 | 5000 | |
| Spinner | mount | 957 | 975 | 5000 | |
| SplitButton | mount | 3644 | 3667 | 5000 | |
| Stack | mount | 1013 | 978 | 5000 | |
| StackWithIntrinsicChildren | mount | 2754 | 2731 | 5000 | |
| StackWithTextChildren | mount | 5750 | 5727 | 5000 | |
| SwatchColorPicker | mount | 12308 | 12454 | 5000 | |
| TagPicker | mount | 3087 | 3106 | 5000 | |
| TeachingBubble | mount | 99248 | 99753 | 5000 | |
| Text | mount | 972 | 948 | 5000 | |
| TextField | mount | 1889 | 1992 | 5000 | |
| ThemeProvider | mount | 1811 | 1813 | 5000 | |
| ThemeProvider | virtual-rerender | 1293 | 1281 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2568 | 2544 | 5000 | |
| Toggle | mount | 1330 | 1321 | 5000 | |
| buttonNative | mount | 635 | 662 | 5000 |
Collaborator
🕵 FluentUI-v0 No visual regressions between this PR and main |
Hotell
marked this pull request as ready for review
December 28, 2022 10:31
Hotell
commented
Dec 28, 2022
| "check:modified-files": "node -r ./scripts/ts-node-register ./scripts/executors/check-for-modified-files", | ||
| "check:affected-package": "node ./scripts/monorepo/checkIfPackagesAffected.js", | ||
| "check:installed-dependencies-versions": "satisfied --skip-invalid --ignore \"prettier|angular|lit|sass|@storybook/html|@storybook/mdx2-csf|svelte|@testing-library|vue|@cypress/react|cypress|@swc/wasm|@cactuslab/usepubsub\"", | ||
| "check:installed-dependencies-versions": "satisfied --skip-invalid --ignore \"prettier|angular|lit|sass|@storybook/html|@storybook/mdx2-csf|svelte|@testing-library|vue|@cypress/react|cypress|@swc/wasm|@cactuslab/usepubsub|react-vis\"", |
Contributor
Author
There was a problem hiding this comment.
react-vis violates its own devDeps and peerDeps 🙃
ling1726
approved these changes
Dec 28, 2022
AtishayMsft
approved these changes
Dec 28, 2022
q1b
pushed a commit
to q1b/fluentui
that referenced
this pull request
Jan 24, 2023
…evDependencies (microsoft#26108) * chore(scripts): apply single version policy on scripts/package.json devDependencies * chore: remove unnecessary resolutions declaration as requestretry is no longer needed * fixup! chore(scripts): apply single version policy on scripts/package.json devDependencies * fixup! fixup! chore(scripts): apply single version policy on scripts/package.json devDependencies * chore: resolve satisfied error on react-viz devdependency mismatch * chore(react-charting): update jest setup as react-vis is now in root which uses older d3-* versions
Hotell
added a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
…evDependencies (microsoft#26108) * chore(scripts): apply single version policy on scripts/package.json devDependencies * chore: remove unnecessary resolutions declaration as requestretry is no longer needed * fixup! chore(scripts): apply single version policy on scripts/package.json devDependencies * fixup! fixup! chore(scripts): apply single version policy on scripts/package.json devDependencies * chore: resolve satisfied error on react-viz devdependency mismatch * chore(react-charting): update jest setup as react-vis is now in root which uses older d3-* versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Behavior
/scriptswhich is also required for packaging sub-foldersRelated Issue(s)
/scripts) #24349