feat(react-tree): Actions positioning and behaviour#26113
Merged
bsunderhus merged 6 commits intoJan 9, 2023
Merged
Conversation
Collaborator
📊 Bundle size report🤖 This report was generated against 96c5a1cbb36d728bebfbf05203d372a82b1968d8 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 96c5a1cbb36d728bebfbf05203d372a82b1968d8 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8dda994:
|
bsunderhus
marked this pull request as ready for review
December 28, 2022 10:20
ling1726
reviewed
Jan 3, 2023
ling1726
reviewed
Jan 3, 2023
ling1726
reviewed
Jan 3, 2023
ling1726
reviewed
Jan 3, 2023
github-actions
Bot
modified the milestones:
October Project Cycle Q4 2022,
January Project Cycle Q1 2023
…seTreeItem.tsx Co-authored-by: ling1726 <lingfangao@hotmail.com>
bsunderhus
force-pushed
the
react-tree/feat--actions-positioning-and-behavior
branch
from
January 4, 2023 18:25
4f1bdc2 to
5a33f2e
Compare
bsunderhus
force-pushed
the
react-tree/feat--actions-positioning-and-behavior
branch
from
January 4, 2023 18:29
5a33f2e to
19ba7a2
Compare
ling1726
reviewed
Jan 9, 2023
ling1726
approved these changes
Jan 9, 2023
bsunderhus
force-pushed
the
react-tree/feat--actions-positioning-and-behavior
branch
from
January 9, 2023 12:02
a69678b to
8dda994
Compare
bsunderhus
enabled auto-merge (squash)
January 9, 2023 12:11
bsunderhus
deleted the
react-tree/feat--actions-positioning-and-behavior
branch
January 9, 2023 12:41
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jan 10, 2023
* master: (29 commits) applying package updates fix: web component menu layering bug (microsoft#26260) Azure Theme: reduced spin button height to match TextField / DropDowns at 24px height (microsoft#26265) Update styling for contentBefore and contentAfter input slots (microsoft#26115) chore: Update Switch to use griffel reset styles (microsoft#26007) Fix: Allow root slot refs to merge with focus refs in Slider (microsoft#26243) applying package updates revert: MenuItem root slot only supports div (microsoft#26261) perf: Don't render Checkbox icon when unchecked (microsoft#26248) fix: Select disabled state hover style, Combobox disabled state open on chevron click (microsoft#26068) applying package updates chore: add more temporary codeowner rools for tooling config files (microsoft#26255) fix: stops using ARIAButton types for MenuItem root (microsoft#26257) refactor: Cleanup unused code (microsoft#26219) fix: MenuList props should win over context props (microsoft#26252) feat(react-tree): Actions positioning and behaviour (microsoft#26113) BREAKING(TableCellLayout): `wrapper` slot renamed to `content` (microsoft#26220) fix(scripts): make lint errors reporting propagate to STDOUT during pre-commit (lint-staged exec) (microsoft#26212) fix: Minimum visible overflow items should be respected (microsoft#26194) docs: Fix typos in react-table docs (microsoft#26213) ...
q1b
pushed a commit
to q1b/fluentui
that referenced
this pull request
Jan 24, 2023
* feat(react-tree): properly position actions * chore: updates API * chore: fix tests and groupper className * Update packages/react-components/react-tree/src/components/TreeItem/useTreeItem.tsx Co-authored-by: ling1726 <lingfangao@hotmail.com> * chore: ensures functionality with Menu * chore: adds role presentation to groupper Co-authored-by: ling1726 <lingfangao@hotmail.com>
Hotell
pushed a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
* feat(react-tree): properly position actions * chore: updates API * chore: fix tests and groupper className * Update packages/react-components/react-tree/src/components/TreeItem/useTreeItem.tsx Co-authored-by: ling1726 <lingfangao@hotmail.com> * chore: ensures functionality with Menu * chore: adds role presentation to groupper Co-authored-by: ling1726 <lingfangao@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Behavior
ARIAButtonas the main root type for theTreeItemSpaceas an action for theTreeItemin consequence of not usingARIAButtonactionsslotsactionsslots through grouppersMenuand other portals onactionsslots