chore(scripts): remove unnecessary gulp preset configuration by Hotell · Pull Request #26145 · microsoft/fluentui

Hotell · 2023-01-03T15:06:09Z

Pre-requisite:

chore: introduce more barrel file apis within /scripts #26125

New Behavior

removes unnecessary gulp config
normalizes v0 docs to use base tsconfig for aliases

Related Issue(s)

Follows :

DustyTheBot · 2023-01-03T15:14:48Z

	Warnings
⚠️	There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS against 4f1e0e2

size-auditor · 2023-01-03T15:21:46Z

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: abae9f7

Possible causes

The baseline build abae9f7 is broken
The Size Auditor run for the baseline build abae9f7 was not triggered

Recommendations

Please merge your branch for this Pull request with the latest master build and commit your changes once again

fabricteam · 2023-01-03T15:23:44Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1172	1152	5000
Button	mount	848	855	5000
FluentProvider	mount	1450	1444	5000
FluentProviderWithTheme	mount	567	575	10
FluentProviderWithTheme	virtual-rerender	535	531	10
FluentProviderWithTheme	virtual-rerender-with-unmount	565	630	10
MakeStyles	mount	1685	1712	50000
Persona	mount	2706	2669	5000
SpinButton	mount	2256	2250	5000

codesandbox-ci · 2023-01-03T15:24:41Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4f1e0e2:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2023-01-03T15:27:10Z

🕵 fluentuiv8 Open the Visual Regressions report to inspect the 2 screenshots

✅ There was 2 screenshots added, 0 screenshots removed, 1043 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference.

unknown 2 screenshots

Image Name	Diff(in Pixels)	Image Type
Pivot - Overflow.Tabs - RTL.Narrow - Last tab selected.chromium.png	0	Added
Pivot - Overflow.Tabs - RTL.Narrow - Overflow menu.chromium.png	0	Added

fabricteam · 2023-01-03T15:28:39Z

Perf Analysis (`@fluentui/react-northstar`)

⚠️ No perf measurements available

fabricteam · 2023-01-03T15:29:46Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`554 B` `348 B`
`priority-overflow` createOverflowManager	`3.153 kB` `1.299 kB`
`react-accordion` Accordion (including children components)	`80.097 kB` `24.712 kB`
`react-alert` Alert	`84.612 kB` `21.445 kB`
`react-avatar` Avatar	`51.515 kB` `14.449 kB`
`react-avatar` AvatarGroup	`15.42 kB` `6.167 kB`
`react-avatar` AvatarGroupItem	`67.733 kB` `18.746 kB`
`react-badge` Badge	`23.78 kB` `7.542 kB`
`react-badge` CounterBadge	`24.67 kB` `7.825 kB`
`react-badge` PresenceBadge	`24.437 kB` `7.189 kB`
`react-button` Button	`33.354 kB` `8.779 kB`
`react-button` CompoundButton	`40.384 kB` `10.127 kB`
`react-button` MenuButton	`38.043 kB` `10.096 kB`
`react-button` SplitButton	`45.488 kB` `11.501 kB`
`react-button` ToggleButton	`49.184 kB` `10.875 kB`
`react-card` Card - All	`77.975 kB` `22.496 kB`
`react-card` Card	`72.92 kB` `21.108 kB`
`react-card` CardFooter	`9.04 kB` `3.807 kB`
`react-card` CardHeader	`10.805 kB` `4.443 kB`
`react-card` CardPreview	`9.847 kB` `4.159 kB`
`react-checkbox` Checkbox	`29.081 kB` `9.258 kB`
`react-checkbox` CheckboxField	`35.51 kB` `11.026 kB`
`react-combobox` Combobox (including child components)	`79.944 kB` `25.571 kB`
`react-combobox` ComboboxField	`77.14 kB` `25.536 kB`
`react-combobox` Dropdown (including child components)	`79.184 kB` `25.502 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`59.888 kB` `16.652 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`188.84 kB` `53.063 kB`
`react-components` react-components: FluentProvider & webLightTheme	`34.379 kB` `11.322 kB`
`react-dialog` Dialog (including children components)	`83.459 kB` `24.913 kB`
`react-divider` Divider	`16.938 kB` `6.103 kB`
`react-image` Image	`11.259 kB` `4.473 kB`
`react-infobutton` InfoButton	`119.608 kB` `35.893 kB`
`react-input` Input	`24.617 kB` `8.059 kB`
`react-input` InputField	`33.839 kB` `10.73 kB`
`react-label` Label	`9.817 kB` `4.067 kB`
`react-link` Link	`12.285 kB` `5.063 kB`
`react-menu` Menu (including children components)	`119.454 kB` `36.929 kB`
`react-menu` Menu (including selectable components)	`122.523 kB` `37.449 kB`
`react-overflow` hooks only	`11.004 kB` `4.188 kB`
`react-persona` Persona	`57.552 kB` `16.102 kB`
`react-popover` Popover	`105.344 kB` `32.445 kB`
`react-portal` Portal	`11.12 kB` `4.096 kB`
`react-portal-compat` PortalCompatProvider	`6.069 kB` `2.053 kB`
`react-positioning` usePositioning	`20.856 kB` `7.766 kB`
`react-progress` ProgressBar	`13.578 kB` `5.235 kB`
`react-progress` ProgressField	`22.892 kB` `8.057 kB`
`react-provider` FluentProvider	`16.446 kB` `6.127 kB`
`react-radio` Radio	`32.247 kB` `10.468 kB`
`react-radio` RadioGroup	`14.718 kB` `5.886 kB`
`react-radio` RadioGroupField	`24.024 kB` `8.796 kB`
`react-select` Select	`23.902 kB` `8.187 kB`
`react-select` SelectField	`32.162 kB` `10.406 kB`
`react-slider` Slider	`32.52 kB` `10.357 kB`
`react-slider` SliderField	`41.544 kB` `13.046 kB`
`react-spinbutton` SpinButton	`44.933 kB` `12.97 kB`
`react-spinbutton` SpinButtonField	`53.229 kB` `15.232 kB`
`react-spinner` Spinner	`20.445 kB` `6.621 kB`
`react-switch` Switch	`33.865 kB` `10.735 kB`
`react-switch` SwitchField	`40.176 kB` `12.514 kB`
`react-text` Text - Default	`12.261 kB` `4.819 kB`
`react-text` Text - Wrappers	`15.571 kB` `5.23 kB`
`react-textarea` Textarea	`26.156 kB` `8.508 kB`
`react-textarea` TextareaField	`35.38 kB` `11.157 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`30.908 kB` `6.714 kB`
`react-theme` Teams: Light theme	`17.776 kB` `5.141 kB`
`react-tooltip` Tooltip	`43.387 kB` `15.18 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against b69b35c04ebb846cb24ba6f1bc60cc9baf55a91b}

fabricteam · 2023-01-03T15:34:24Z

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam · 2023-01-03T15:43:53Z

🕵 FluentUI-v0 No visual regressions between this PR and main

fabricteam · 2023-01-03T15:44:33Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	1484	1469	5000
Breadcrumb	mount	3698	3693	1000
Checkbox	mount	3260	3333	5000
CheckboxBase	mount	2937	3000	5000
ChoiceGroup	mount	5449	5571	5000
ComboBox	mount	1608	1580	1000
CommandBar	mount	11933	11861	1000
ContextualMenu	mount	13815	13662	1000
DefaultButton	mount	1714	1701	5000
DetailsRow	mount	4441	4636	5000
DetailsRowFast	mount	4473	4544	5000
DetailsRowNoStyles	mount	4404	4251	5000
Dialog	mount	3843	3869	1000
DocumentCardTitle	mount	728	752	1000
Dropdown	mount	3942	3991	5000
FocusTrapZone	mount	2467	2562	5000
FocusZone	mount	2507	2463	5000
GroupedList	mount	2335	2682	2
GroupedList	virtual-rerender	1450	1385	2
GroupedList	virtual-rerender-with-unmount	2145	2039	2
GroupedListV2	mount	702	724	2
GroupedListV2	virtual-rerender	715	704	2
GroupedListV2	virtual-rerender-with-unmount	730	702	2
IconButton	mount	2417	2399	5000
Label	mount	922	922	5000
Layer	mount	5412	5359	5000
Link	mount	1030	1053	5000
MenuButton	mount	2110	2061	5000
MessageBar	mount	2915	2924	5000
Nav	mount	4097	4003	1000
OverflowSet	mount	1737	1729	5000
Panel	mount	3149	3212	1000
Persona	mount	1600	1644	1000
Pivot	mount	2075	2052	1000
PrimaryButton	mount	1883	1919	5000
Rating	mount	8744	8710	5000
SearchBox	mount	1944	1916	5000
Shimmer	mount	3575	3625	5000
Slider	mount	2619	2607	5000
SpinButton	mount	5763	5814	5000
Spinner	mount	1014	1088	5000
SplitButton	mount	3981	3990	5000
Stack	mount	1028	1052	5000
StackWithIntrinsicChildren	mount	2824	2880	5000
StackWithTextChildren	mount	5993	6023	5000
SwatchColorPicker	mount	12996	12908	5000
TagPicker	mount	3253	3216	5000
TeachingBubble	mount	105546	106308	5000
Text	mount	979	1009	5000
TextField	mount	2001	1954	5000
ThemeProvider	mount	1967	1894	5000
ThemeProvider	virtual-rerender	1305	1379	5000
ThemeProvider	virtual-rerender-with-unmount	2664	2669	5000
Toggle	mount	1396	1384	5000
buttonNative	mount	701	664	5000

…ft#26145) * chore(scripts): remove unnecessary gulp preset configuration * chore(northstar/docs): remove local path aliases

msft-fluent-ui-bot assigned smhigley Jan 3, 2023

github-actions Bot added this to the October Project Cycle Q4 2022 milestone Jan 3, 2023

Hotell changed the title ~~Hotell/build/scripts/ts solution config v19~~ chore(scripts): remove unnecessary gulp preset configuration Jan 3, 2023

Hotell unassigned smhigley Jan 3, 2023

Hotell added 2 commits January 4, 2023 12:05

chore(scripts): remove unnecessary gulp preset configuration

62b01b6

chore(northstar/docs): remove local path aliases

4f1e0e2

Hotell force-pushed the hotell/build/scripts/ts-solution-config-v19 branch from a82bfa2 to 4f1e0e2 Compare January 4, 2023 11:06

github-actions Bot modified the milestones: October Project Cycle Q4 2022, January Project Cycle Q1 2023 Jan 4, 2023

Hotell marked this pull request as ready for review January 4, 2023 12:46

Hotell requested review from a team as code owners January 4, 2023 12:46

layershifter approved these changes Jan 4, 2023

View reviewed changes

tudorpopams self-requested a review January 4, 2023 13:11

Hotell enabled auto-merge (squash) January 4, 2023 13:19

ling1726 approved these changes Jan 4, 2023

View reviewed changes

Hotell merged commit b5eee75 into microsoft:master Jan 4, 2023

q1b pushed a commit to q1b/fluentui that referenced this pull request Jan 24, 2023

chore(scripts): remove unnecessary gulp preset configuration (microso…

c0c6dee

…ft#26145) * chore(scripts): remove unnecessary gulp preset configuration * chore(northstar/docs): remove local path aliases

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(scripts): remove unnecessary gulp preset configuration#26145

chore(scripts): remove unnecessary gulp preset configuration#26145
Hotell merged 2 commits into
microsoft:masterfrom
Hotell:hotell/build/scripts/ts-solution-config-v19

Hotell commented Jan 3, 2023 •

edited

Loading

Uh oh!

DustyTheBot commented Jan 3, 2023 •

edited

Loading

Uh oh!

size-auditor Bot commented Jan 3, 2023 •

edited

Loading

Uh oh!

fabricteam commented Jan 3, 2023 •

edited

Loading

Uh oh!

codesandbox-ci Bot commented Jan 3, 2023 •

edited

Loading

Uh oh!

fabricteam commented Jan 3, 2023 •

edited

Loading

Uh oh!

fabricteam commented Jan 3, 2023

Uh oh!

fabricteam commented Jan 3, 2023 •

edited

Loading

Uh oh!

fabricteam commented Jan 3, 2023 •

edited

Loading

Uh oh!

fabricteam commented Jan 3, 2023 •

edited

Loading

Uh oh!

fabricteam commented Jan 3, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

Hotell commented Jan 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

New Behavior

Related Issue(s)

Uh oh!

DustyTheBot commented Jan 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

size-auditor Bot commented Jan 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

fabricteam commented Jan 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

codesandbox-ci Bot commented Jan 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabricteam commented Jan 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv8 Open the Visual Regressions report to inspect the 2 screenshots

Uh oh!

fabricteam commented Jan 3, 2023

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Jan 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

fabricteam commented Jan 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 fluentuiv9 No visual regressions between this PR and main

Uh oh!

fabricteam commented Jan 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🕵 FluentUI-v0 No visual regressions between this PR and main

Uh oh!

fabricteam commented Jan 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Hotell commented Jan 3, 2023 •

edited

Loading

DustyTheBot commented Jan 3, 2023 •

edited

Loading

size-auditor Bot commented Jan 3, 2023 •

edited

Loading

fabricteam commented Jan 3, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

codesandbox-ci Bot commented Jan 3, 2023 •

edited

Loading

fabricteam commented Jan 3, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Jan 3, 2023 •

edited

Loading

fabricteam commented Jan 3, 2023 •

edited

Loading

fabricteam commented Jan 3, 2023 •

edited

Loading

fabricteam commented Jan 3, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react`)