Skip to content

Fix suggestions no results infinite loop #26267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GeoffCoxMSFT merged 2 commits into from
Jan 10, 2023
Merged

Fix suggestions no results infinite loop #26267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ebd5f8
Set correct defaultRender
GeoffCoxMSFT Jan 9, 2023
54bac94
yarn change
GeoffCoxMSFT Jan 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-8abc6b6c-fcb2-4ec6-b72d-d68559917073.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Set correct defaultRender for no results found",
"packageName": "@fluentui/react",
"email": "gcox@microsoft.com",
"dependentChangeType": "patch"
}
22 changes: 12 additions & 10 deletions packages/react/src/components/pickers/Suggestions/Suggestions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,16 +146,18 @@ export class Suggestions<T> extends React.Component<ISuggestionsProps<T>, ISugge
className: css('ms-Suggestions-spinner', legacyStyles.suggestionsSpinner),
};

const noResults = () => (
// This ID can be used by the parent to set aria-activedescendant to this
<div id="sug-noResultsFound" role="option">
{onRenderNoResultFound ? (
onRenderNoResultFound(undefined, noResults)
) : (
<div className={this._classNames.noSuggestions}>{noResultsFoundText}</div>
)}
</div>
);
const noResults = () => {
const defaultRender = () => {
return <div className={this._classNames.noSuggestions}>{noResultsFoundText}</div>;
};

return (
// This ID can be used by the parent to set aria-activedescendant to this
<div id="sug-noResultsFound" role="option">
{onRenderNoResultFound ? onRenderNoResultFound(undefined, defaultRender) : defaultRender()}
</div>
);
};

// MostRecently Used text should supercede the header text if it's there and available.
let headerText: string | undefined = suggestionsHeaderText;
Expand Down