Skip to content

fix(TableSelectionCell): Radios should not change selection on focus #26283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ling1726 merged 3 commits into from
Jan 11, 2023
Merged

fix(TableSelectionCell): Radios should not change selection on focus #26283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73ea08a
fix(TableSelectionCell): Radios should not change selection on focus
ling1726 Jan 10, 2023
b939e71
update tests
ling1726 Jan 10, 2023
c3d9f51
changefile
ling1726 Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-table-dc36dcfe-b403-4c89-9868-b16b05e46700.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "fix(TableSelectionCell): Radios should not change selection on focus",
"packageName": "@fluentui/react-table",
"email": "lingfangao@hotmail.com",
"dependentChangeType": "patch"
}
2 changes: 2 additions & 0 deletions ...eact-components/react-table/src/components/TableSelectionCell/TableSelectionCell.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import * as React from 'react';
import { render } from '@testing-library/react';
import { resetIdsForTests } from '@fluentui/react-utilities';
import { TableSelectionCell } from './TableSelectionCell';
import { isConformant } from '../../testing/isConformant';
import { TableSelectionCellProps } from './TableSelectionCell.types';
Expand All @@ -10,6 +11,7 @@ const tr = document.createElement('tr');
describe('TableSelectionCell', () => {
beforeEach(() => {
document.body.appendChild(tr);
resetIdsForTests();
});

isConformant({
Expand Down
2 changes: 1 addition & 1 deletion ...ct-table/src/components/TableSelectionCell/__snapshots__/TableSelectionCell.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ exports[`TableSelectionCell renders a default state 1`] = `
>
<input
class="fui-Checkbox__input"
id="checkbox-9"
id="checkbox-2"
type="checkbox"
/>
<div
Expand Down
4 changes: 2 additions & 2 deletions .../react-components/react-table/src/components/TableSelectionCell/useTableSelectionCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as React from 'react';
import { resolveShorthand } from '@fluentui/react-utilities';
import { resolveShorthand, useId } from '@fluentui/react-utilities';
import { Checkbox } from '@fluentui/react-checkbox';
import { Radio } from '@fluentui/react-radio';
import type { TableSelectionCellProps, TableSelectionCellState } from './TableSelectionCell.types';
Expand Down Expand Up @@ -36,7 +36,7 @@ export const useTableSelectionCell_unstable = (
}),
radioIndicator: resolveShorthand(props.radioIndicator, {
required: type === 'radio',
defaultProps: { checked: !!checked },
defaultProps: { checked: !!checked, input: { name: useId('table-selection-radio') } },
}),
type,
checked,
Expand Down