Skip to content

feat(react-tabster): add id to useModalAttributes options #26387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YuanboXue-Amber merged 3 commits into from
Jan 18, 2023
Merged

feat(react-tabster): add id to useModalAttributes options #26387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e60ac4
add id
YuanboXue-Amber Jan 17, 2023
e7786aa
chg
YuanboXue-Amber Jan 17, 2023
5c0c973
api
YuanboXue-Amber Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-tabster-5065c018-0a25-4a76-9359-7f114ddf23e8.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "minor",
"comment": "feat: add modalizer id to `useModalAttributes` option",
"packageName": "@fluentui/react-tabster",
"email": "yuanboxue@microsoft.com",
"dependentChangeType": "patch"
}
1 change: 1 addition & 0 deletions packages/react-components/react-tabster/etc/react-tabster.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ export const useModalAttributes: (options?: UseModalAttributesOptions) => {
// @public (undocumented)
export interface UseModalAttributesOptions {
alwaysFocusable?: boolean;
id?: string;
legacyTrapFocus?: boolean;
trapFocus?: boolean;
}
Expand Down
7 changes: 6 additions & 1 deletion packages/react-components/react-tabster/src/hooks/useModalAttributes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ export interface UseModalAttributesOptions {
* Always reachabled in Tab order
*/
alwaysFocusable?: boolean;

/**
* Id to use for the modalizer. An id will be generated if not provided.
*/
id?: string;
Comment thread
YuanboXue-Amber marked this conversation as resolved.
}

/**
Expand All @@ -44,7 +49,7 @@ export const useModalAttributes = (
getDeloser(tabster);
}

const id = useId('modal-');
const id = useId('modal-', options.id);
const modalAttributes = useTabsterAttributes({
deloser: {},
modalizer: {
Expand Down