Skip to content

chore: Refactor Field into a standalone component#26416

Closed
behowell wants to merge 27 commits into
microsoft:masterfrom
behowell:field/standalone-component
Closed

chore: Refactor Field into a standalone component#26416
behowell wants to merge 27 commits into
microsoft:masterfrom
behowell:field/standalone-component

Conversation

@behowell

Copy link
Copy Markdown
Contributor

Previous Behavior

New Behavior

Related Issue(s)

  • Fixes #

@size-auditor

size-auditor Bot commented Jan 18, 2023

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8dd29bf9dcabf85f89afd4d291a730821bf55f75 (build)

@fabricteam

fabricteam commented Jan 18, 2023

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-progress
ProgressField
23.766 kB
8.301 kB
246 B
183 B
-23.52 kB
-8.118 kB
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-checkbox
Checkbox
32.658 kB
10.169 kB
react-combobox
Combobox (including child components)
80.888 kB
25.842 kB
react-combobox
Dropdown (including child components)
79.674 kB
25.637 kB
react-components
react-components: Button, FluentProvider & webLightTheme
59.888 kB
16.652 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
187.539 kB
52.638 kB
react-components
react-components: FluentProvider & webLightTheme
34.379 kB
11.322 kB
react-input
Input
24.673 kB
8.065 kB
react-portal-compat
PortalCompatProvider
6.069 kB
2.053 kB
react-progress
ProgressBar
13.573 kB
5.232 kB
react-radio
Radio
32.247 kB
10.468 kB
react-radio
RadioGroup
14.718 kB
5.886 kB
react-select
Select
23.963 kB
8.206 kB
react-slider
Slider
32.663 kB
10.403 kB
react-spinbutton
SpinButton
44.989 kB
12.975 kB
react-switch
Switch
27.791 kB
8.605 kB
react-table
DataGrid
129.317 kB
35.207 kB
react-table
Table (Primitives only)
42.971 kB
11.781 kB
react-table
Table as DataGrid
127.563 kB
32.864 kB
react-table
Table (Selection only)
81 kB
20.124 kB
react-table
Table (Sort only)
80.429 kB
19.97 kB
react-textarea
Textarea
26.156 kB
8.508 kB
🤖 This report was generated against 8dd29bf9dcabf85f89afd4d291a730821bf55f75

@fabricteam

fabricteam commented Jan 18, 2023

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1287 1310 5000
Button mount 918 924 5000
FluentProvider mount 1500 1506 5000
FluentProviderWithTheme mount 590 573 10
FluentProviderWithTheme virtual-rerender 530 539 10
FluentProviderWithTheme virtual-rerender-with-unmount 572 566 10
InfoButton mount 518 512 5000
MakeStyles mount 1970 1947 50000
Persona mount 2821 2781 5000
SpinButton mount 2267 2337 5000

@codesandbox-ci

codesandbox-ci Bot commented Jan 19, 2023

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d455df2:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam

fabricteam commented Jan 19, 2023

Copy link
Copy Markdown
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@behowell

Copy link
Copy Markdown
Contributor Author

Closing in favor of #26430

@behowell behowell closed this Jan 20, 2023
@behowell
behowell deleted the field/standalone-component branch February 15, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants