feat: add Dropdown field#26488
Closed
smhigley wants to merge 2 commits into
Closed
Conversation
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 4f3871db826e542114d853b57fb2f740787f91e8 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1526 | 1552 | 5000 | |
| Button | mount | 1117 | 1111 | 5000 | |
| FluentProvider | mount | 1912 | 1952 | 5000 | |
| FluentProviderWithTheme | mount | 749 | 747 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 714 | 712 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 765 | 755 | 10 | |
| InfoButton | mount | 687 | 670 | 5000 | |
| MakeStyles | mount | 2259 | 2257 | 50000 | |
| Persona | mount | 3624 | 3557 | 5000 | |
| SpinButton | mount | 3025 | 2984 | 5000 |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
fabricteam
reviewed
Jan 24, 2023
| @@ -3,6 +3,7 @@ import { Steps, StoryWright } from 'storywright'; | |||
| import { storiesOf } from '@storybook/react'; | |||
Collaborator
There was a problem hiding this comment.
🕵 fluentuiv9 Open the Visual Regressions report to inspect the 7 screenshots
✅ There was 7 screenshots added, 0 screenshots removed, 1775 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference.
unknown 7 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| DropdownField converged.base.default.chromium.png | 0 | Added |
| DropdownField converged.hint.default.chromium.png | 0 | Added |
| DropdownField converged.horizontal.default.chromium.png | 0 | Added |
| DropdownField converged.required.default.chromium.png | 0 | Added |
| DropdownField converged.size-large.default.chromium.png | 0 | Added |
| DropdownField converged.size-small.default.chromium.png | 0 | Added |
| DropdownField converged.validation.default.chromium.png | 0 | Added |
Contributor
Author
|
Closing, since #26430 is almost ready to be merged, and will make ComboboxField/DropdownField obsolete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had ComboboxField, but DropdownField was missing 😅